From: Boqun Feng <boqun.feng@gmail.com>
To: Michael Kelley <mikelley@microsoft.com>
Cc: "linux-hyperv@vger.kernel.org" <linux-hyperv@vger.kernel.org>,
"linux-input@vger.kernel.org" <linux-input@vger.kernel.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
"netdev@vger.kernel.org" <netdev@vger.kernel.org>,
"linux-scsi@vger.kernel.org" <linux-scsi@vger.kernel.org>,
KY Srinivasan <kys@microsoft.com>,
Haiyang Zhang <haiyangz@microsoft.com>,
Stephen Hemminger <sthemmin@microsoft.com>,
Wei Liu <wei.liu@kernel.org>, Jiri Kosina <jikos@kernel.org>,
Benjamin Tissoires <benjamin.tissoires@redhat.com>,
Dmitry Torokhov <dmitry.torokhov@gmail.com>,
"David S. Miller" <davem@davemloft.net>,
Jakub Kicinski <kuba@kernel.org>,
"James E.J. Bottomley" <jejb@linux.ibm.com>,
"Martin K. Petersen" <martin.petersen@oracle.com>
Subject: Re: [RFC v2 07/11] hv_netvsc: Use HV_HYP_PAGE_SIZE for Hyper-V communication
Date: Mon, 7 Sep 2020 08:09:12 +0800 [thread overview]
Message-ID: <20200907000912.GF7503@debian-boqun.qqnc3lrjykvubdpftowmye0fmh.lx.internal.cloudapp.net> (raw)
In-Reply-To: <MW2PR2101MB10521041242835B2D6E3EA0AD72A0@MW2PR2101MB1052.namprd21.prod.outlook.com>
On Sat, Sep 05, 2020 at 12:30:48AM +0000, Michael Kelley wrote:
> From: Boqun Feng <boqun.feng@gmail.com> Sent: Tuesday, September 1, 2020 8:01 PM
[...]
> > struct rndis_request {
> > struct list_head list_ent;
> > struct completion wait_event;
> > @@ -215,18 +215,18 @@ static int rndis_filter_send_request(struct rndis_device *dev,
> > packet->page_buf_cnt = 1;
> >
> > pb[0].pfn = virt_to_phys(&req->request_msg) >>
> > - PAGE_SHIFT;
> > + HV_HYP_PAGE_SHIFT;
> > pb[0].len = req->request_msg.msg_len;
> > pb[0].offset =
> > - (unsigned long)&req->request_msg & (PAGE_SIZE - 1);
> > + (unsigned long)&req->request_msg & (HV_HYP_PAGE_SIZE - 1);
>
> Use offset_in_hvpage() as defined in patch 6 of the series?
>
Fair enough, I will use offset_in_hvpage() in the next version
Regards,
Boqun
> >
> > /* Add one page_buf when request_msg crossing page boundary */
> > - if (pb[0].offset + pb[0].len > PAGE_SIZE) {
> > + if (pb[0].offset + pb[0].len > HV_HYP_PAGE_SIZE) {
> > packet->page_buf_cnt++;
> > - pb[0].len = PAGE_SIZE -
> > + pb[0].len = HV_HYP_PAGE_SIZE -
> > pb[0].offset;
> > pb[1].pfn = virt_to_phys((void *)&req->request_msg
> > - + pb[0].len) >> PAGE_SHIFT;
> > + + pb[0].len) >> HV_HYP_PAGE_SHIFT;
> > pb[1].offset = 0;
> > pb[1].len = req->request_msg.msg_len -
> > pb[0].len;
> > --
> > 2.28.0
>
next prev parent reply other threads:[~2020-09-07 0:09 UTC|newest]
Thread overview: 23+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-09-02 3:00 [RFC v2 00/11] Hyper-V: Support PAGE_SIZE larger than 4K Boqun Feng
2020-09-02 3:00 ` [RFC v2 01/11] Drivers: hv: vmbus: Always use HV_HYP_PAGE_SIZE for gpadl Boqun Feng
2020-09-02 3:00 ` [RFC v2 02/11] Drivers: hv: vmbus: Move __vmbus_open() Boqun Feng
2020-09-05 0:04 ` Michael Kelley
2020-09-02 3:00 ` [RFC v2 03/11] Drivers: hv: vmbus: Introduce types of GPADL Boqun Feng
2020-09-05 0:19 ` Michael Kelley
2020-09-06 4:51 ` Boqun Feng
2020-09-02 3:01 ` [RFC v2 04/11] Drivers: hv: Use HV_HYP_PAGE in hv_synic_enable_regs() Boqun Feng
2020-09-02 3:01 ` [RFC v2 05/11] Drivers: hv: vmbus: Move virt_to_hvpfn() to hyperv header Boqun Feng
2020-09-02 3:01 ` [RFC v2 06/11] hv: hyperv.h: Introduce some hvpfn helper functions Boqun Feng
2020-09-02 3:01 ` [RFC v2 07/11] hv_netvsc: Use HV_HYP_PAGE_SIZE for Hyper-V communication Boqun Feng
2020-09-05 0:30 ` Michael Kelley
2020-09-07 0:09 ` Boqun Feng [this message]
2020-09-02 3:01 ` [RFC v2 08/11] Input: hyperv-keyboard: Make ringbuffer at least take two pages Boqun Feng
2020-09-02 3:01 ` [RFC v2 09/11] HID: hyperv: " Boqun Feng
2020-09-02 5:43 ` kernel test robot
2020-09-02 7:54 ` kernel test robot
2020-09-02 8:18 ` Jiri Kosina
2020-09-02 3:01 ` [RFC v2 10/11] Driver: hv: util: " Boqun Feng
2020-09-02 3:01 ` [RFC v2 11/11] scsi: storvsc: Support PAGE_SIZE larger than 4K Boqun Feng
2020-09-05 2:55 ` Michael Kelley
2020-09-05 14:15 ` Boqun Feng
2020-09-05 15:37 ` Michael Kelley
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200907000912.GF7503@debian-boqun.qqnc3lrjykvubdpftowmye0fmh.lx.internal.cloudapp.net \
--to=boqun.feng@gmail.com \
--cc=benjamin.tissoires@redhat.com \
--cc=davem@davemloft.net \
--cc=dmitry.torokhov@gmail.com \
--cc=haiyangz@microsoft.com \
--cc=jejb@linux.ibm.com \
--cc=jikos@kernel.org \
--cc=kuba@kernel.org \
--cc=kys@microsoft.com \
--cc=linux-hyperv@vger.kernel.org \
--cc=linux-input@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-scsi@vger.kernel.org \
--cc=martin.petersen@oracle.com \
--cc=mikelley@microsoft.com \
--cc=netdev@vger.kernel.org \
--cc=sthemmin@microsoft.com \
--cc=wei.liu@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.