From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-3.8 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS, URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id EA52CC43461 for ; Mon, 7 Sep 2020 11:52:22 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id ACA6421481 for ; Mon, 7 Sep 2020 11:52:22 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1729175AbgIGLwS (ORCPT ); Mon, 7 Sep 2020 07:52:18 -0400 Received: from mga18.intel.com ([134.134.136.126]:31253 "EHLO mga18.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1729160AbgIGLwJ (ORCPT ); Mon, 7 Sep 2020 07:52:09 -0400 IronPort-SDR: hQr39yb3q66Yek1DAlVR9FPRCNPx9kP3gP7DFahOrT8xkjm40+JjVsUngxgYagt0+gZVRFo5SQ dRVLbQhCPbqA== X-IronPort-AV: E=McAfee;i="6000,8403,9736"; a="145701516" X-IronPort-AV: E=Sophos;i="5.76,401,1592895600"; d="scan'208";a="145701516" X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from orsmga008.jf.intel.com ([10.7.209.65]) by orsmga106.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 07 Sep 2020 04:52:06 -0700 IronPort-SDR: uvr2VwyZ4SxhVRvEAjJl/5Qfroyr0fgq08DkGSizqWWalIL1aBVCwym291h/o+Ug99zXiM+Hvb BA0rZVPHxRMg== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.76,401,1592895600"; d="scan'208";a="333142853" Received: from smile.fi.intel.com (HELO smile) ([10.237.68.40]) by orsmga008.jf.intel.com with ESMTP; 07 Sep 2020 04:52:02 -0700 Received: from andy by smile with local (Exim 4.94) (envelope-from ) id 1kFFgl-00EwLw-NM; Mon, 07 Sep 2020 14:51:59 +0300 Date: Mon, 7 Sep 2020 14:51:59 +0300 From: Andy Shevchenko To: Bartosz Golaszewski Cc: Linus Walleij , Jonathan Corbet , Mika Westerberg , Kent Gibson , "open list:GPIO SUBSYSTEM" , linux-doc , Linux Kernel Mailing List , linux-acpi@vger.kernel.org, Bartosz Golaszewski Subject: Re: [PATCH 16/23] gpio: mockup: refactor the module init function Message-ID: <20200907115159.GZ1891694@smile.fi.intel.com> References: <20200904154547.3836-1-brgl@bgdev.pl> <20200904154547.3836-17-brgl@bgdev.pl> <20200904165029.GD1891694@smile.fi.intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: Organization: Intel Finland Oy - BIC 0357606-4 - Westendinkatu 7, 02160 Espoo Sender: linux-acpi-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-acpi@vger.kernel.org On Mon, Sep 07, 2020 at 01:05:54PM +0200, Bartosz Golaszewski wrote: > On Fri, Sep 4, 2020 at 6:57 PM Andy Shevchenko > wrote: > > On Fri, Sep 04, 2020 at 05:45:40PM +0200, Bartosz Golaszewski wrote: > > > From: Bartosz Golaszewski > > > > > > This is in preparation for dynamically created chips. > > > > > > Let's split out the code that can be reused when creating chips at > > > run-time. Let's also move the code preparing the device properties into > > > a separate routine. This has the advantage of simplifying the error > > > handling. > > > > Almost all contents of this patch should go to proposed helper as I mentioned > > before. Will make this patch quite small and understandable. > Sorry, I'm not sure what you're referring to. I meant if you move changes done here to the patch where I complained about indentation you might have better series. Have you considered that? -- With Best Regards, Andy Shevchenko