From: Jarkko Sakkinen <jarkko.sakkinen@linux.intel.com>
To: James Bottomley <James.Bottomley@HansenPartnership.com>
Cc: linux-integrity@vger.kernel.org, Mimi Zohar <zohar@linux.ibm.com>,
linux-api@vger.kernel.org, Jason Gunthorpe <jgg@ziepe.ca>
Subject: Re: [PATCH RESEND v4 1/1] tpm: add sysfs exports for all banks of PCR registers
Date: Mon, 7 Sep 2020 16:21:21 +0300 [thread overview]
Message-ID: <20200907132121.GA106839@linux.intel.com> (raw)
In-Reply-To: <20200906203245.18429-2-James.Bottomley@HansenPartnership.com>
On Sun, Sep 06, 2020 at 01:32:45PM -0700, James Bottomley wrote:
> Create sysfs per hash groups with 24 PCR files in them one group,
> named pcr-<hash>, for each agile hash of the TPM. The files are
> plugged in to a PCR read function which is TPM version agnostic, so
> this works also for TPM 1.2 but the hash is only sha1 in that case.
>
> Note: the macros used to create the hashes emit spurious checkpatch
> warnings. Do not try to "fix" them as checkpatch recommends, otherwise
> they'll break.
>
> Signed-off-by: James Bottomley <James.Bottomley@HansenPartnership.com>
> Reviewed-by: Jerry Snitselaar <jsnitsel@redhat.com>
> Tested-by: Thiago Jung Bauermann <bauerman@linux.ibm.com>
I'm not sure why this should be in sysfs when event log is in
securityfs.
Also, securityfs does not have to follow sysfs requirements,
which gives ability to dump all PCRs in a single binary file.
Using ASCII for this is inefficient.
/Jarkko
next prev parent reply other threads:[~2020-09-07 17:25 UTC|newest]
Thread overview: 25+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-09-06 20:32 [PATCH RESEND v4 0/1] add sysfs exports for TPM 2 PCR registers James Bottomley
2020-09-06 20:32 ` [PATCH RESEND v4 1/1] tpm: add sysfs exports for all banks of " James Bottomley
2020-09-07 5:39 ` Greg KH
2020-09-07 5:59 ` James Bottomley
2020-09-07 13:21 ` Jarkko Sakkinen [this message]
2020-09-07 17:37 ` Greg KH
2020-09-08 17:39 ` Jarkko Sakkinen
2020-09-07 5:38 ` [PATCH RESEND v4 0/1] add sysfs exports for TPM 2 " Greg KH
2020-09-07 13:23 ` Jarkko Sakkinen
2020-09-07 13:36 ` Greg KH
2020-09-07 21:52 ` James Bottomley
2020-09-08 5:45 ` Greg KH
2020-09-08 18:05 ` Jarkko Sakkinen
2020-09-08 18:14 ` James Bottomley
2020-09-09 7:07 ` Greg KH
2020-09-11 11:48 ` Jarkko Sakkinen
2020-09-11 11:47 ` Jarkko Sakkinen
2020-11-29 22:30 James Bottomley
2020-11-29 22:30 ` [PATCH RESEND v4 1/1] tpm: add sysfs exports for all banks of " James Bottomley
2020-11-30 8:17 ` Greg KH
2020-11-30 19:00 ` Elliott, Robert (Servers)
2020-11-30 19:53 ` James Bottomley
2020-11-30 22:50 ` Elliott, Robert (Servers)
2020-11-30 22:57 ` James Bottomley
2020-12-23 15:58 ` Ken Goldman
2020-12-04 4:55 ` Jarkko Sakkinen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200907132121.GA106839@linux.intel.com \
--to=jarkko.sakkinen@linux.intel.com \
--cc=James.Bottomley@HansenPartnership.com \
--cc=jgg@ziepe.ca \
--cc=linux-api@vger.kernel.org \
--cc=linux-integrity@vger.kernel.org \
--cc=zohar@linux.ibm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.