From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-6.9 required=3.0 tests=BAYES_00,DKIM_ADSP_CUSTOM_MED, DKIM_INVALID,DKIM_SIGNED,FSL_HELO_FAKE,HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_NONE, URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 6709CC43461 for ; Tue, 8 Sep 2020 11:02:32 +0000 (UTC) Received: from mm01.cs.columbia.edu (mm01.cs.columbia.edu [128.59.11.253]) by mail.kernel.org (Postfix) with ESMTP id CA054208DB for ; Tue, 8 Sep 2020 11:02:31 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=fail reason="signature verification failed" (2048-bit key) header.d=google.com header.i=@google.com header.b="b1dr7Of+" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org CA054208DB Authentication-Results: mail.kernel.org; dmarc=fail (p=reject dis=none) header.from=google.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=kvmarm-bounces@lists.cs.columbia.edu Received: from localhost (localhost [127.0.0.1]) by mm01.cs.columbia.edu (Postfix) with ESMTP id 4724A4B44E; Tue, 8 Sep 2020 07:02:31 -0400 (EDT) X-Virus-Scanned: at lists.cs.columbia.edu Authentication-Results: mm01.cs.columbia.edu (amavisd-new); dkim=softfail (fail, message has been altered) header.i=@google.com Received: from mm01.cs.columbia.edu ([127.0.0.1]) by localhost (mm01.cs.columbia.edu [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id yqL5GJpLcqoU; Tue, 8 Sep 2020 07:02:30 -0400 (EDT) Received: from mm01.cs.columbia.edu (localhost [127.0.0.1]) by mm01.cs.columbia.edu (Postfix) with ESMTP id 5115D4B4F1; Tue, 8 Sep 2020 07:02:30 -0400 (EDT) Received: from localhost (localhost [127.0.0.1]) by mm01.cs.columbia.edu (Postfix) with ESMTP id A01F14B44E for ; Tue, 8 Sep 2020 07:02:29 -0400 (EDT) X-Virus-Scanned: at lists.cs.columbia.edu Received: from mm01.cs.columbia.edu ([127.0.0.1]) by localhost (mm01.cs.columbia.edu [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id lFSztV71KLpJ for ; Tue, 8 Sep 2020 07:02:28 -0400 (EDT) Received: from mail-wm1-f68.google.com (mail-wm1-f68.google.com [209.85.128.68]) by mm01.cs.columbia.edu (Postfix) with ESMTPS id 993124B30B for ; Tue, 8 Sep 2020 07:02:28 -0400 (EDT) Received: by mail-wm1-f68.google.com with SMTP id l9so16718098wme.3 for ; Tue, 08 Sep 2020 04:02:28 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20161025; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to; bh=ukRFS2c9kQoV0ZHewMEPqAGuZjsAWs/CsNrEJEq1jGs=; b=b1dr7Of+AcozrYtjVhgnYWTfqOAe7Go1Ua1gItyhju31PiiJ7B/fFjWmmzjrHoSWP7 XHfsdP3Gm+o+STk+0YuHKk2Su/kBsxqqVZhMD2zUjOpzMZKHWUNN7zEAB07Zd8y4u01I k+cIkt33uhxUp9c/fq+LoDXkUZK+Tf7AFLIRVF0rFJsCSO5BA0zPIQD0f5iQadkqxL7O 8oK9MZfIHlR3uoJmh92Dg+5nFjkwWa8GKph2UFBDnmFX8RUMT7sb3A105Q0QVyqRQC00 tUAUh/ActjmP5C506NPrTPF+YqAzkyQB5LnimOQIApIkUU6N2S9KsEoN4nTewa21gftr O5VA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=ukRFS2c9kQoV0ZHewMEPqAGuZjsAWs/CsNrEJEq1jGs=; b=CejNya4tPGMMwW4DRIlPazdqcBjS2OksFIqOoqzxhEeEKPM20jFZmhbh+bKnu42Fnq 16//MpM6ys+MD9Adc+EJ+YIIRhaBLgeb0Lq2EtH7X8U6wpRDxw5uwPjBeY8ilOvG6jzL oQ9vxC4jK/Co4n8sO3q3ODwnWgjEpmJyhh/EGkSKwmjFXqr9pVhMoeyIj5cb/Jjt9smy cVk0M8HeuXo58g3C4upzv0JfTioPtaRVS4HMdpgtmxChQEkpPUKgUG/X68sF0SHtKok+ eB/JPocuYhhYJhP7vz7AFKw3SAzvbM8dl22apUoSw4C0abWVaXl7yZtHIx8cxJys0EZs 3GqA== X-Gm-Message-State: AOAM532KWAt3ECHG4PnzEY1hIM/43ruTR/SAaaZI8rqonjc88kJXHOCf Kjgk3+kc/7gpXj6xNlsivStHwg== X-Google-Smtp-Source: ABdhPJwoSvNMFVJfZn/T4Sse44Bn5jyzINix2w2Rt4VLmZDdUQPWjxIJJJ2/pU1GAZwXegW0S1VY5Q== X-Received: by 2002:a1c:ba42:: with SMTP id k63mr3749849wmf.31.1599562947440; Tue, 08 Sep 2020 04:02:27 -0700 (PDT) Received: from google.com ([2a00:79e0:d:109:4a0f:cfff:fe4a:6363]) by smtp.gmail.com with ESMTPSA id 8sm36211588wrl.7.2020.09.08.04.02.26 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 08 Sep 2020 04:02:26 -0700 (PDT) Date: Tue, 8 Sep 2020 12:02:22 +0100 From: Andrew Scull To: Marc Zyngier Subject: Re: [PATCH v3 16/18] KVM: arm64: nVHE: Migrate hyp interface to SMCCC Message-ID: <20200908110222.GF3268721@google.com> References: <20200903135307.251331-1-ascull@google.com> <20200903135307.251331-17-ascull@google.com> <87o8mhlld4.wl-maz@kernel.org> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <87o8mhlld4.wl-maz@kernel.org> Cc: kernel-team@android.com, catalin.marinas@arm.com, linux-arm-kernel@lists.infradead.org, Sudeep Holla , will@kernel.org, kvmarm@lists.cs.columbia.edu X-BeenThere: kvmarm@lists.cs.columbia.edu X-Mailman-Version: 2.1.14 Precedence: list List-Id: Where KVM/ARM decisions are made List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: kvmarm-bounces@lists.cs.columbia.edu Sender: kvmarm-bounces@lists.cs.columbia.edu On Mon, Sep 07, 2020 at 03:20:07PM +0100, Marc Zyngier wrote: > On Thu, 03 Sep 2020 14:53:05 +0100, > Andrew Scull wrote: > > > > Rather than passing arbitrary function pointers to run at hyp, define > > and equivalent set of SMCCC functions. > > > > Since the SMCCC functions are strongly tied to the original function > > prototypes, it is not expected for the host to ever call an invalid ID > > but a warning is raised if this does ever occur. > > > > As __kvm_vcpu_run is used for every switch between the host and a guest, > > it is explicitly singled out to be identified before the other function > > IDs to improve the performance of the hot path. > > > > Signed-off-by: Andrew Scull > > Signed-off-by: David Brazdil > > --- > > arch/arm64/include/asm/kvm_asm.h | 24 ++++++ > > arch/arm64/include/asm/kvm_host.h | 25 ++++--- > > arch/arm64/kvm/arm.c | 2 +- > > arch/arm64/kvm/hyp.S | 24 ++---- > > arch/arm64/kvm/hyp/nvhe/hyp-main.c | 113 +++++++++++++++++++++++++---- > > 5 files changed, 145 insertions(+), 43 deletions(-) > > > > diff --git a/arch/arm64/include/asm/kvm_asm.h b/arch/arm64/include/asm/kvm_asm.h > > index 4bbde3d3989c..4a73f1349151 100644 > > --- a/arch/arm64/include/asm/kvm_asm.h > > +++ b/arch/arm64/include/asm/kvm_asm.h > > @@ -38,6 +38,30 @@ > > > > #define __SMCCC_WORKAROUND_1_SMC_SZ 36 > > > > +#define KVM_HOST_SMCCC_ID(id) \ > > + ARM_SMCCC_CALL_VAL(ARM_SMCCC_FAST_CALL, \ > > + ARM_SMCCC_SMC_64, \ > > + ARM_SMCCC_OWNER_STANDARD_HYP, \ > > + (id)) > > + > > +#define KVM_HOST_SMCCC_FUNC(name) KVM_HOST_SMCCC_ID(__KVM_HOST_SMCCC_FUNC_##name) > > + > > +#define __KVM_HOST_SMCCC_FUNC___kvm_hyp_init 0 > > +#define __KVM_HOST_SMCCC_FUNC___kvm_flush_vm_context 1 > > +#define __KVM_HOST_SMCCC_FUNC___kvm_tlb_flush_vmid_ipa 2 > > +#define __KVM_HOST_SMCCC_FUNC___kvm_tlb_flush_vmid 3 > > +#define __KVM_HOST_SMCCC_FUNC___kvm_tlb_flush_local_vmid 4 > > +#define __KVM_HOST_SMCCC_FUNC___kvm_timer_set_cntvoff 5 > > +#define __KVM_HOST_SMCCC_FUNC___kvm_vcpu_run 6 > > +#define __KVM_HOST_SMCCC_FUNC___kvm_enable_ssbs 7 > > +#define __KVM_HOST_SMCCC_FUNC___vgic_v3_get_ich_vtr_el2 8 > > +#define __KVM_HOST_SMCCC_FUNC___vgic_v3_read_vmcr 9 > > +#define __KVM_HOST_SMCCC_FUNC___vgic_v3_write_vmcr 10 > > +#define __KVM_HOST_SMCCC_FUNC___vgic_v3_init_lrs 11 > > +#define __KVM_HOST_SMCCC_FUNC___kvm_get_mdcr_el2 12 > > +#define __KVM_HOST_SMCCC_FUNC___vgic_v3_save_aprs 13 > > +#define __KVM_HOST_SMCCC_FUNC___vgic_v3_restore_aprs 14 > > Wait. This looks broken. How do you distinguish between these and the > stubs? The __KVM_HOST_SMCCC_FUNC_* definitions are just the function ID part of the SMCCC x0 argument. KVM_HOST_SMCCC_ID builds it into a 64-bit fastcall owner by the hypervisor. The stubs fall into the legacy region so these don't conflict. _______________________________________________ kvmarm mailing list kvmarm@lists.cs.columbia.edu https://lists.cs.columbia.edu/mailman/listinfo/kvmarm From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-7.1 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_ADSP_CUSTOM_MED,DKIM_SIGNED,DKIM_VALID,FSL_HELO_FAKE, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY, SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id A129BC43461 for ; Tue, 8 Sep 2020 11:03:48 +0000 (UTC) Received: from merlin.infradead.org (merlin.infradead.org [205.233.59.134]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 39479208DB for ; Tue, 8 Sep 2020 11:03:48 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="tMU2eOQD"; dkim=fail reason="signature verification failed" (2048-bit key) header.d=google.com header.i=@google.com header.b="b1dr7Of+" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 39479208DB Authentication-Results: mail.kernel.org; dmarc=fail (p=reject dis=none) header.from=google.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=merlin.20170209; h=Sender:Content-Transfer-Encoding: Content-Type:Cc:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References:Message-ID: Subject:To:From:Date:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=HUn+Hfqc/mGflrgj10GxE3KRg10Z3SpPWwknkbUfF4M=; b=tMU2eOQDqGi/GwNSWEpleXF0f NppViE7qZ/R7BeAx8Ktoj4d/xS7KzHy3nIWaynbKa3AfDPflV07sQYNg+6VhAV1mceqMegYB1y2tD a7u96jKgGUFkjtZFql0rNe9balY5b7D8kv/AV1+/COCsI3VblAtdUC7qOqloN+R9X/xeuNWVor1/j Sn+eRuO783apG4PU9oGFTJ8TRoIUoElLrY6WiV4EUjHmuLFuOLBxYZRE8ltq+/SDLKXZ1wXq9Nw1I QBcUPqS8isAJIRvoCWlarXJD8qz7xADLNan9yScmG29Sr7XLdCk0gv6LJRt4ciGVdRdQSFTs9Vxw9 OV3SuuHvA==; Received: from localhost ([::1] helo=merlin.infradead.org) by merlin.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1kFbOR-0000bZ-1K; Tue, 08 Sep 2020 11:02:31 +0000 Received: from mail-wm1-x342.google.com ([2a00:1450:4864:20::342]) by merlin.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1kFbOO-0000bA-Ja for linux-arm-kernel@lists.infradead.org; Tue, 08 Sep 2020 11:02:29 +0000 Received: by mail-wm1-x342.google.com with SMTP id w2so16848026wmi.1 for ; Tue, 08 Sep 2020 04:02:28 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20161025; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to; bh=ukRFS2c9kQoV0ZHewMEPqAGuZjsAWs/CsNrEJEq1jGs=; b=b1dr7Of+AcozrYtjVhgnYWTfqOAe7Go1Ua1gItyhju31PiiJ7B/fFjWmmzjrHoSWP7 XHfsdP3Gm+o+STk+0YuHKk2Su/kBsxqqVZhMD2zUjOpzMZKHWUNN7zEAB07Zd8y4u01I k+cIkt33uhxUp9c/fq+LoDXkUZK+Tf7AFLIRVF0rFJsCSO5BA0zPIQD0f5iQadkqxL7O 8oK9MZfIHlR3uoJmh92Dg+5nFjkwWa8GKph2UFBDnmFX8RUMT7sb3A105Q0QVyqRQC00 tUAUh/ActjmP5C506NPrTPF+YqAzkyQB5LnimOQIApIkUU6N2S9KsEoN4nTewa21gftr O5VA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=ukRFS2c9kQoV0ZHewMEPqAGuZjsAWs/CsNrEJEq1jGs=; b=Wes0DbhLK0btOC+uPGz1UD63/Y/jCgrfWOw/eo7fRhHGAXUSo2iVObXPZ9oMm5XmoX aaVVOYqKxg5mmQJlQyIW8ARS4E2IU9FQh7GZtm/hNz3riTgCfIufz4CqJLVMLpcvwOUq 6LO871BOROLKCXCRUSIKS9+1fLGJg1gV3WZR8QmSf2X+lszR05UOdK3Xee5Ka16JVwXv nRJw9u2op1tFpaAdC8NFonYXFBwgXgZhJ7b8FHcrK9c4dmfhXNyXzu5P3PYB8qYxWyvh G9KZEXA4pJnDPfN4NdCcNRC8ZtaHGjRGFiS2vuLnLH7PpGQh5/Xc5wG0hYTBPrag2RFT IBwQ== X-Gm-Message-State: AOAM531jVVL+sbz4gGlbKcCPz6kWUWWkqzFd+0Ip9/t275adJIGyo8aN E+MSQjVKmrkgZWFZ+Ncn3qaSWQ== X-Google-Smtp-Source: ABdhPJwoSvNMFVJfZn/T4Sse44Bn5jyzINix2w2Rt4VLmZDdUQPWjxIJJJ2/pU1GAZwXegW0S1VY5Q== X-Received: by 2002:a1c:ba42:: with SMTP id k63mr3749849wmf.31.1599562947440; Tue, 08 Sep 2020 04:02:27 -0700 (PDT) Received: from google.com ([2a00:79e0:d:109:4a0f:cfff:fe4a:6363]) by smtp.gmail.com with ESMTPSA id 8sm36211588wrl.7.2020.09.08.04.02.26 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 08 Sep 2020 04:02:26 -0700 (PDT) Date: Tue, 8 Sep 2020 12:02:22 +0100 From: Andrew Scull To: Marc Zyngier Subject: Re: [PATCH v3 16/18] KVM: arm64: nVHE: Migrate hyp interface to SMCCC Message-ID: <20200908110222.GF3268721@google.com> References: <20200903135307.251331-1-ascull@google.com> <20200903135307.251331-17-ascull@google.com> <87o8mhlld4.wl-maz@kernel.org> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <87o8mhlld4.wl-maz@kernel.org> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20200908_070228_731783_E2FCE55E X-CRM114-Status: GOOD ( 26.65 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: kernel-team@android.com, suzuki.poulose@arm.com, catalin.marinas@arm.com, james.morse@arm.com, linux-arm-kernel@lists.infradead.org, Sudeep Holla , David Brazdil , will@kernel.org, kvmarm@lists.cs.columbia.edu, julien.thierry.kdev@gmail.com Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Mon, Sep 07, 2020 at 03:20:07PM +0100, Marc Zyngier wrote: > On Thu, 03 Sep 2020 14:53:05 +0100, > Andrew Scull wrote: > > > > Rather than passing arbitrary function pointers to run at hyp, define > > and equivalent set of SMCCC functions. > > > > Since the SMCCC functions are strongly tied to the original function > > prototypes, it is not expected for the host to ever call an invalid ID > > but a warning is raised if this does ever occur. > > > > As __kvm_vcpu_run is used for every switch between the host and a guest, > > it is explicitly singled out to be identified before the other function > > IDs to improve the performance of the hot path. > > > > Signed-off-by: Andrew Scull > > Signed-off-by: David Brazdil > > --- > > arch/arm64/include/asm/kvm_asm.h | 24 ++++++ > > arch/arm64/include/asm/kvm_host.h | 25 ++++--- > > arch/arm64/kvm/arm.c | 2 +- > > arch/arm64/kvm/hyp.S | 24 ++---- > > arch/arm64/kvm/hyp/nvhe/hyp-main.c | 113 +++++++++++++++++++++++++---- > > 5 files changed, 145 insertions(+), 43 deletions(-) > > > > diff --git a/arch/arm64/include/asm/kvm_asm.h b/arch/arm64/include/asm/kvm_asm.h > > index 4bbde3d3989c..4a73f1349151 100644 > > --- a/arch/arm64/include/asm/kvm_asm.h > > +++ b/arch/arm64/include/asm/kvm_asm.h > > @@ -38,6 +38,30 @@ > > > > #define __SMCCC_WORKAROUND_1_SMC_SZ 36 > > > > +#define KVM_HOST_SMCCC_ID(id) \ > > + ARM_SMCCC_CALL_VAL(ARM_SMCCC_FAST_CALL, \ > > + ARM_SMCCC_SMC_64, \ > > + ARM_SMCCC_OWNER_STANDARD_HYP, \ > > + (id)) > > + > > +#define KVM_HOST_SMCCC_FUNC(name) KVM_HOST_SMCCC_ID(__KVM_HOST_SMCCC_FUNC_##name) > > + > > +#define __KVM_HOST_SMCCC_FUNC___kvm_hyp_init 0 > > +#define __KVM_HOST_SMCCC_FUNC___kvm_flush_vm_context 1 > > +#define __KVM_HOST_SMCCC_FUNC___kvm_tlb_flush_vmid_ipa 2 > > +#define __KVM_HOST_SMCCC_FUNC___kvm_tlb_flush_vmid 3 > > +#define __KVM_HOST_SMCCC_FUNC___kvm_tlb_flush_local_vmid 4 > > +#define __KVM_HOST_SMCCC_FUNC___kvm_timer_set_cntvoff 5 > > +#define __KVM_HOST_SMCCC_FUNC___kvm_vcpu_run 6 > > +#define __KVM_HOST_SMCCC_FUNC___kvm_enable_ssbs 7 > > +#define __KVM_HOST_SMCCC_FUNC___vgic_v3_get_ich_vtr_el2 8 > > +#define __KVM_HOST_SMCCC_FUNC___vgic_v3_read_vmcr 9 > > +#define __KVM_HOST_SMCCC_FUNC___vgic_v3_write_vmcr 10 > > +#define __KVM_HOST_SMCCC_FUNC___vgic_v3_init_lrs 11 > > +#define __KVM_HOST_SMCCC_FUNC___kvm_get_mdcr_el2 12 > > +#define __KVM_HOST_SMCCC_FUNC___vgic_v3_save_aprs 13 > > +#define __KVM_HOST_SMCCC_FUNC___vgic_v3_restore_aprs 14 > > Wait. This looks broken. How do you distinguish between these and the > stubs? The __KVM_HOST_SMCCC_FUNC_* definitions are just the function ID part of the SMCCC x0 argument. KVM_HOST_SMCCC_ID builds it into a 64-bit fastcall owner by the hypervisor. The stubs fall into the legacy region so these don't conflict. _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel