From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-4.1 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,MAILING_LIST_MULTI,SPF_HELO_NONE, SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 6BA25C43461 for ; Tue, 8 Sep 2020 19:15:10 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 36CE72087D for ; Tue, 8 Sep 2020 19:15:10 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1599592510; bh=2HfdP+uSD5/p7nJvzoH7AHXzOMn2xyhHfqtxGKx4uEg=; h=Date:From:To:Cc:Subject:In-Reply-To:References:List-ID:From; b=0x8neBJNiDH7I0QvZMNCPh9PZei4KNoP7IZA1bclQorS1J4Io0blvVPfu37mutfCS SDf/Bso9FC8w4ZDhY0n25ipGCmv0IgmEUz3eUAXFGJdCy4CiAR9iuscbvYKJm90pco mwDc6Wl96hBLbFdaGa/P1UwUwAtJnlfp36XtvKzU= Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1731803AbgIHTPI (ORCPT ); Tue, 8 Sep 2020 15:15:08 -0400 Received: from mail.kernel.org ([198.145.29.99]:60364 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1731770AbgIHTPB (ORCPT ); Tue, 8 Sep 2020 15:15:01 -0400 Received: from kicinski-fedora-pc1c0hjn.dhcp.thefacebook.com (unknown [163.114.132.6]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 2B62F2087D; Tue, 8 Sep 2020 19:14:59 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1599592499; bh=2HfdP+uSD5/p7nJvzoH7AHXzOMn2xyhHfqtxGKx4uEg=; h=Date:From:To:Cc:Subject:In-Reply-To:References:From; b=HO9sK1Anvq+u++KVP3n4AQ2N/ifsSKCyR+HPXhxwlgt56x/6MhqfVQzNgfGEE93UI WUChRLBf3kpsDzgTYDuykNEmqPy/7WUZruF8hr+QhbOQCNkc5avG+EMKZ6hD5kaziw Mp3Rzlv9MnGRDXgLmt+aoe73zV/k2IHSQpObBgGQ= Date: Tue, 8 Sep 2020 12:14:57 -0700 From: Jakub Kicinski To: David Awogbemila Cc: netdev@vger.kernel.org, Catherine Sullivan , Yangchun Fu Subject: Re: [PATCH net-next v3 4/9] gve: Add support for dma_mask register Message-ID: <20200908121457.0dc67f75@kicinski-fedora-pc1c0hjn.dhcp.thefacebook.com> In-Reply-To: <20200908183909.4156744-5-awogbemila@google.com> References: <20200908183909.4156744-1-awogbemila@google.com> <20200908183909.4156744-5-awogbemila@google.com> MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Sender: netdev-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org On Tue, 8 Sep 2020 11:39:04 -0700 David Awogbemila wrote: > + dma_mask = readb(®_bar->dma_mask); > + // Default to 64 if the register isn't set > + if (!dma_mask) > + dma_mask = 64; > gve_write_version(®_bar->driver_version); > /* Get max queues to alloc etherdev */ > max_rx_queues = ioread32be(®_bar->max_tx_queues); > max_tx_queues = ioread32be(®_bar->max_rx_queues); > + > + err = pci_set_dma_mask(pdev, DMA_BIT_MASK(64)); You use the constant 64, not dma_mask? You jump through hoops to get GFP_DMA allocations yet you don't set the right DMA mask. Why would swiotlb become an issue to you if there never was any reasonable mask set? > + if (err) { > + dev_err(&pdev->dev, "Failed to set dma mask: err=%d\n", err); > + goto abort_with_reg_bar; > + } > + > + err = pci_set_consistent_dma_mask(pdev, DMA_BIT_MASK(64)); dma_set_mask_and_coherent() > + if (err) { > + dev_err(&pdev->dev, > + "Failed to set consistent dma mask: err=%d\n", err); > + goto abort_with_reg_bar; > + }