From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from list by lists.gnu.org with archive (Exim 4.90_1) id 1kFdD9-0003Zh-Ey for mharc-grub-devel@gnu.org; Tue, 08 Sep 2020 08:58:59 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:42766) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1kFdD7-0003XO-Hz for grub-devel@gnu.org; Tue, 08 Sep 2020 08:58:57 -0400 Received: from userp2120.oracle.com ([156.151.31.85]:43318) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1kFdD5-0003Zk-Ba for grub-devel@gnu.org; Tue, 08 Sep 2020 08:58:57 -0400 Received: from pps.filterd (userp2120.oracle.com [127.0.0.1]) by userp2120.oracle.com (8.16.0.42/8.16.0.42) with SMTP id 088Crufl105558; Tue, 8 Sep 2020 12:58:41 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oracle.com; h=date : from : to : cc : subject : message-id : references : mime-version : content-type : in-reply-to; s=corp-2020-01-29; bh=67BA1NrA4bstlA31bMm5D33qblpk5W+mzOIAoRBOEzg=; b=GZ9q8HJED8HZ6Ark8DPHeswWIm26ufhemmE4p1g3vjEof5kbFS9alq3fE+tIggLtl0H+ Zgr/YgTvVAnridnXgAMAAfCshRGynvj/7TpwycDjEOlFz78Me3eRpMUJPM7AqyLxTAsV 5QoRIjgP7BJ4P5l/b5SdNNowEuG0dx/a0jpFgpu36vkxhZ/4nAZcpfE1GLxl5GzMsRZP gU/UlQvQBC6Q4bW0//H5beF7B5qv5vkKMJoZEKJfcW3P6ik5kYQfNvw8Q5AWYb5W7nak UEHWoWRKYc3YO7FfrWqe5lI+QPO8FgZxsjmi/NHP/rT00b/kHZWvvUrUIDRXbtPKgPv5 AQ== Received: from aserp3030.oracle.com (aserp3030.oracle.com [141.146.126.71]) by userp2120.oracle.com with ESMTP id 33c3amu78e-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=FAIL); Tue, 08 Sep 2020 12:58:41 +0000 Received: from pps.filterd (aserp3030.oracle.com [127.0.0.1]) by aserp3030.oracle.com (8.16.0.42/8.16.0.42) with SMTP id 088CtX9S063764; Tue, 8 Sep 2020 12:58:40 GMT Received: from aserv0122.oracle.com (aserv0122.oracle.com [141.146.126.236]) by aserp3030.oracle.com with ESMTP id 33dachtfpq-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Tue, 08 Sep 2020 12:58:40 +0000 Received: from abhmp0006.oracle.com (abhmp0006.oracle.com [141.146.116.12]) by aserv0122.oracle.com (8.14.4/8.14.4) with ESMTP id 088CwcMO030933; Tue, 8 Sep 2020 12:58:38 GMT Received: from tomti.i.net-space.pl (/10.175.199.180) by default (Oracle Beehive Gateway v4.0) with ESMTP ; Tue, 08 Sep 2020 05:58:37 -0700 Date: Tue, 8 Sep 2020 14:58:33 +0200 From: Daniel Kiper To: Patrick Steinhardt Cc: grub-devel@gnu.org, Denis GNUtoo Carikli , Glenn Washburn Subject: Re: [PATCH v3 3/9] luks2: Fix use of incorrect index and some error messages Message-ID: <20200908125833.veiqznw47a23dxc5@tomti.i.net-space.pl> References: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: NeoMutt/20170113 (1.7.2) X-Proofpoint-Virus-Version: vendor=nai engine=6000 definitions=9737 signatures=668679 X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 mlxlogscore=999 malwarescore=0 bulkscore=0 phishscore=0 adultscore=0 suspectscore=0 spamscore=0 mlxscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2006250000 definitions=main-2009080122 X-Proofpoint-Virus-Version: vendor=nai engine=6000 definitions=9737 signatures=668679 X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 phishscore=0 priorityscore=1501 clxscore=1011 bulkscore=0 malwarescore=0 lowpriorityscore=0 mlxlogscore=999 suspectscore=0 adultscore=0 mlxscore=0 impostorscore=0 spamscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2006250000 definitions=main-2009080122 Received-SPF: pass client-ip=156.151.31.85; envelope-from=daniel.kiper@oracle.com; helo=userp2120.oracle.com X-detected-operating-system: by eggs.gnu.org: First seen = 2020/09/08 08:58:51 X-ACL-Warn: Detected OS = Linux 3.1-3.10 [fuzzy] X-Spam_score_int: -43 X-Spam_score: -4.4 X-Spam_bar: ---- X-Spam_report: (-4.4 / 5.0 requ) BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.001, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_MED=-2.3, RCVD_IN_MSPIKE_H2=-0.001, SPF_HELO_PASS=-0.001, SPF_PASS=-0.001, UNPARSEABLE_RELAY=0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: grub-devel@gnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: The development of GNU GRUB List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 08 Sep 2020 12:58:57 -0000 On Mon, Sep 07, 2020 at 05:27:41PM +0200, Patrick Steinhardt wrote: > From: Glenn Washburn It seems to me this patch should be split into two and and begs for commit message improvement. In general it would be nice to know why we need these fixes. Daniel