From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from list by lists.gnu.org with archive (Exim 4.90_1) id 1kFdfX-0001ej-Rt for mharc-grub-devel@gnu.org; Tue, 08 Sep 2020 09:28:19 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:50842) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1kFdfW-0001eV-8h for grub-devel@gnu.org; Tue, 08 Sep 2020 09:28:18 -0400 Received: from userp2120.oracle.com ([156.151.31.85]:41396) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1kFdfT-0007LZ-Ad for grub-devel@gnu.org; Tue, 08 Sep 2020 09:28:17 -0400 Received: from pps.filterd (userp2120.oracle.com [127.0.0.1]) by userp2120.oracle.com (8.16.0.42/8.16.0.42) with SMTP id 088DO0vS161301; Tue, 8 Sep 2020 13:28:10 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oracle.com; h=date : from : to : cc : subject : message-id : references : mime-version : content-type : in-reply-to; s=corp-2020-01-29; bh=84hY1Y2/865TSzh7kUSxgEq7v5DiNWGtNgMO2yQyQ5w=; b=hoyvmCXyew76cATtSV7ceRDbi9pgHrXI7Sitw2TzYReBJaTFb4Kwr5JWxWzKgx82d8/C LHFJgEAj7fhrHoz4QVY2IncVtEqPsK0kq/t0NCAF1iaLMHd11cCx5u4HL+uz4C3JFFOs EPq66oiu5LYugkMzamd1kD2+ik/EA/WQxLfXJTZ9n547aCWfVA8SxbpVfUEquffYSVQi zBw9LpInern6dFisYIvA8fO/hDYn8exEW8lH2QGVrFn5kn4+0ytlQix2R5C+ThYByJtT 9UHz1poC+uoA0N5rxwMQ/tODj9pdIV7Dsf01SLHIUuuyaeA8eQOCcc/yc1D11W2TiWka ag== Received: from aserp3020.oracle.com (aserp3020.oracle.com [141.146.126.70]) by userp2120.oracle.com with ESMTP id 33c3amudjt-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=FAIL); Tue, 08 Sep 2020 13:28:10 +0000 Received: from pps.filterd (aserp3020.oracle.com [127.0.0.1]) by aserp3020.oracle.com (8.16.0.42/8.16.0.42) with SMTP id 088DP01a013586; Tue, 8 Sep 2020 13:28:09 GMT Received: from userv0122.oracle.com (userv0122.oracle.com [156.151.31.75]) by aserp3020.oracle.com with ESMTP id 33cmk3e2qt-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Tue, 08 Sep 2020 13:28:09 +0000 Received: from abhmp0017.oracle.com (abhmp0017.oracle.com [141.146.116.23]) by userv0122.oracle.com (8.14.4/8.14.4) with ESMTP id 088DS8Yd015385; Tue, 8 Sep 2020 13:28:08 GMT Received: from tomti.i.net-space.pl (/10.175.199.180) by default (Oracle Beehive Gateway v4.0) with ESMTP ; Tue, 08 Sep 2020 06:28:07 -0700 Date: Tue, 8 Sep 2020 15:28:03 +0200 From: Daniel Kiper To: Patrick Steinhardt Cc: grub-devel@gnu.org, Denis GNUtoo Carikli , Glenn Washburn Subject: Re: [PATCH v3 6/9] cryptodisk: Unregister cryptomount command when removing module Message-ID: <20200908132803.47zheuofojcvpc6u@tomti.i.net-space.pl> References: <7ef38470b44756db74928b0ade215b566503ef0f.1599492346.git.ps@pks.im> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <7ef38470b44756db74928b0ade215b566503ef0f.1599492346.git.ps@pks.im> User-Agent: NeoMutt/20170113 (1.7.2) X-Proofpoint-Virus-Version: vendor=nai engine=6000 definitions=9737 signatures=668679 X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 spamscore=0 malwarescore=0 phishscore=0 mlxlogscore=999 bulkscore=0 adultscore=0 mlxscore=0 suspectscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2006250000 definitions=main-2009080127 X-Proofpoint-Virus-Version: vendor=nai engine=6000 definitions=9737 signatures=668679 X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 phishscore=0 priorityscore=1501 clxscore=1015 bulkscore=0 malwarescore=0 lowpriorityscore=0 mlxlogscore=999 suspectscore=0 adultscore=0 mlxscore=0 impostorscore=0 spamscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2006250000 definitions=main-2009080127 Received-SPF: pass client-ip=156.151.31.85; envelope-from=daniel.kiper@oracle.com; helo=userp2120.oracle.com X-detected-operating-system: by eggs.gnu.org: First seen = 2020/09/08 08:58:51 X-ACL-Warn: Detected OS = Linux 3.1-3.10 [fuzzy] X-Spam_score_int: -43 X-Spam_score: -4.4 X-Spam_bar: ---- X-Spam_report: (-4.4 / 5.0 requ) BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.001, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_MED=-2.3, RCVD_IN_MSPIKE_H2=-0.001, SPF_HELO_PASS=-0.001, SPF_PASS=-0.001, UNPARSEABLE_RELAY=0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: grub-devel@gnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: The development of GNU GRUB List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 08 Sep 2020 13:28:18 -0000 On Mon, Sep 07, 2020 at 05:27:55PM +0200, Patrick Steinhardt wrote: > From: Glenn Washburn > > Signed-off-by: Glenn Washburn > Reviewed-by: Patrick Steinhardt > --- > grub-core/disk/cryptodisk.c | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/grub-core/disk/cryptodisk.c b/grub-core/disk/cryptodisk.c > index 1897acc4b..b2c6e9a7d 100644 > --- a/grub-core/disk/cryptodisk.c > +++ b/grub-core/disk/cryptodisk.c > @@ -1311,5 +1311,6 @@ GRUB_MOD_FINI (cryptodisk) > { > grub_disk_dev_unregister (&grub_cryptodisk_dev); > cryptodisk_cleanup (); I am OK with this patch but I realized that cryptodisk_cleanup() body is commented out, So, could you add another patch which drops cryptodisk_cleanup() entirely from the GRUB code? Or make it work as it supposed to work. Maybe the latter is better... Daniel