From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-9.8 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH, MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id A588BC2D0E2 for ; Tue, 8 Sep 2020 20:13:20 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 2EA7720936 for ; Tue, 8 Sep 2020 20:13:20 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (1024-bit key) header.d=ideasonboard.com header.i=@ideasonboard.com header.b="b2/TxslK" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1729779AbgIHUND (ORCPT ); Tue, 8 Sep 2020 16:13:03 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:46408 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1729961AbgIHPLR (ORCPT ); Tue, 8 Sep 2020 11:11:17 -0400 Received: from perceval.ideasonboard.com (perceval.ideasonboard.com [IPv6:2001:4b98:dc2:55:216:3eff:fef7:d647]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 79FAAC09B050; Tue, 8 Sep 2020 07:48:55 -0700 (PDT) Received: from pendragon.ideasonboard.com (62-78-145-57.bb.dnainternet.fi [62.78.145.57]) by perceval.ideasonboard.com (Postfix) with ESMTPSA id 0E6623B; Tue, 8 Sep 2020 16:43:41 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com; s=mail; t=1599576222; bh=BdI0mo6eUHVfUXSrDwJy0WdXPPXWR7rIn+Hw/QeDrUw=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=b2/TxslKry0QOEPzP+VPWZS2buO+bF1ApD4YuLmYmBCQVnezP83TYeYXiqUxsFVUQ gb1DC0bMQtlZydH4ZklFF2exgipcn//n+6y3E5R3RLI1taAiyIT1TVNCVh5iP+Rwi2 8wL3ttJUUp3OTR/nRVCQmRzvrRlf54Q4xNaEmFSE= Date: Tue, 8 Sep 2020 17:43:17 +0300 From: Laurent Pinchart To: Kieran Bingham Cc: Kuninori Morimoto , Rob Herring , Geert Uytterhoeven , David Airlie , Daniel Vetter , Magnus , Linux-Renesas , Linux-DT , "(Renesas) shimoda" , dri-devel@lists.freedesktop.org Subject: Re: [PATCH v2 02/10] dt-bindings: display: renesas: dw-hdmi: tidyup example compatible. Message-ID: <20200908144317.GA11405@pendragon.ideasonboard.com> References: <87o8mhrtxo.wl-kuninori.morimoto.gx@renesas.com> <87lfhlrtwp.wl-kuninori.morimoto.gx@renesas.com> <6e1eedf0-d05f-81cd-e437-33fc4c7337f3@ideasonboard.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: <6e1eedf0-d05f-81cd-e437-33fc4c7337f3@ideasonboard.com> Sender: devicetree-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: devicetree@vger.kernel.org Hi Kieran, On Tue, Sep 08, 2020 at 03:18:20PM +0100, Kieran Bingham wrote: > On 08/09/2020 01:34, Kuninori Morimoto wrote: > > From: Kuninori Morimoto > > > > required is "renesas,r8a7795-hdmi", instead of "renesas,r8a7795-dw-hdmi" > > Hrm, technically the driver will currently only match on : > "renesas,rcar-gen3-hdmi" > > But I see how the '-dw-' has probably snuck in from other devices, and > is inappropriate. > > Perhaps this should be more clear that it matches on the generic compatible: > renesas,rcar-gen3-hdmi > > (or a combination of both?) > > > Signed-off-by: Kuninori Morimoto > > But if the generic isn't required, then this patch alone does fix what I > would call an error, so ... You're right, the generic compatible string should be required. I'll update this patch accordingly, and will address the bindings as part of the conversion to YAML. > Reviewed-by: Kieran Bingham > > We could always make this more clear when converting to YAML. > > > --- > > .../devicetree/bindings/display/bridge/renesas,dw-hdmi.txt | 2 +- > > 1 file changed, 1 insertion(+), 1 deletion(-) > > > > diff --git a/Documentation/devicetree/bindings/display/bridge/renesas,dw-hdmi.txt b/Documentation/devicetree/bindings/display/bridge/renesas,dw-hdmi.txt > > index 819f3e31013c..e6526ab485d0 100644 > > --- a/Documentation/devicetree/bindings/display/bridge/renesas,dw-hdmi.txt > > +++ b/Documentation/devicetree/bindings/display/bridge/renesas,dw-hdmi.txt > > @@ -42,7 +42,7 @@ Optional properties: > > Example: > > > > hdmi0: hdmi@fead0000 { > > - compatible = "renesas,r8a7795-dw-hdmi"; > > + compatible = "renesas,r8a7795-hdmi"; > > reg = <0 0xfead0000 0 0x10000>; > > interrupts = <0 389 IRQ_TYPE_LEVEL_HIGH>; > > clocks = <&cpg CPG_CORE R8A7795_CLK_S0D4>, <&cpg CPG_MOD 729>; > > -- Regards, Laurent Pinchart From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-9.6 required=3.0 tests=BAYES_00,DKIM_INVALID, DKIM_SIGNED,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI, SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 441BBC43461 for ; Tue, 8 Sep 2020 14:43:54 +0000 (UTC) Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 81DC2223E4 for ; Tue, 8 Sep 2020 14:43:53 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=fail reason="signature verification failed" (1024-bit key) header.d=ideasonboard.com header.i=@ideasonboard.com header.b="b2/TxslK" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 81DC2223E4 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=ideasonboard.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=dri-devel-bounces@lists.freedesktop.org Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id 9A5606E1D7; Tue, 8 Sep 2020 14:43:52 +0000 (UTC) Received: from perceval.ideasonboard.com (perceval.ideasonboard.com [IPv6:2001:4b98:dc2:55:216:3eff:fef7:d647]) by gabe.freedesktop.org (Postfix) with ESMTPS id 6E22E6E1D7 for ; Tue, 8 Sep 2020 14:43:50 +0000 (UTC) Received: from pendragon.ideasonboard.com (62-78-145-57.bb.dnainternet.fi [62.78.145.57]) by perceval.ideasonboard.com (Postfix) with ESMTPSA id 0E6623B; Tue, 8 Sep 2020 16:43:41 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com; s=mail; t=1599576222; bh=BdI0mo6eUHVfUXSrDwJy0WdXPPXWR7rIn+Hw/QeDrUw=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=b2/TxslKry0QOEPzP+VPWZS2buO+bF1ApD4YuLmYmBCQVnezP83TYeYXiqUxsFVUQ gb1DC0bMQtlZydH4ZklFF2exgipcn//n+6y3E5R3RLI1taAiyIT1TVNCVh5iP+Rwi2 8wL3ttJUUp3OTR/nRVCQmRzvrRlf54Q4xNaEmFSE= Date: Tue, 8 Sep 2020 17:43:17 +0300 From: Laurent Pinchart To: Kieran Bingham Subject: Re: [PATCH v2 02/10] dt-bindings: display: renesas: dw-hdmi: tidyup example compatible. Message-ID: <20200908144317.GA11405@pendragon.ideasonboard.com> References: <87o8mhrtxo.wl-kuninori.morimoto.gx@renesas.com> <87lfhlrtwp.wl-kuninori.morimoto.gx@renesas.com> <6e1eedf0-d05f-81cd-e437-33fc4c7337f3@ideasonboard.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <6e1eedf0-d05f-81cd-e437-33fc4c7337f3@ideasonboard.com> X-BeenThere: dri-devel@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Direct Rendering Infrastructure - Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Linux-DT , Kuninori Morimoto , Geert Uytterhoeven , David Airlie , "\(Renesas\) shimoda" , Magnus , dri-devel@lists.freedesktop.org, Linux-Renesas , Rob Herring Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" Hi Kieran, On Tue, Sep 08, 2020 at 03:18:20PM +0100, Kieran Bingham wrote: > On 08/09/2020 01:34, Kuninori Morimoto wrote: > > From: Kuninori Morimoto > > > > required is "renesas,r8a7795-hdmi", instead of "renesas,r8a7795-dw-hdmi" > > Hrm, technically the driver will currently only match on : > "renesas,rcar-gen3-hdmi" > > But I see how the '-dw-' has probably snuck in from other devices, and > is inappropriate. > > Perhaps this should be more clear that it matches on the generic compatible: > renesas,rcar-gen3-hdmi > > (or a combination of both?) > > > Signed-off-by: Kuninori Morimoto > > But if the generic isn't required, then this patch alone does fix what I > would call an error, so ... You're right, the generic compatible string should be required. I'll update this patch accordingly, and will address the bindings as part of the conversion to YAML. > Reviewed-by: Kieran Bingham > > We could always make this more clear when converting to YAML. > > > --- > > .../devicetree/bindings/display/bridge/renesas,dw-hdmi.txt | 2 +- > > 1 file changed, 1 insertion(+), 1 deletion(-) > > > > diff --git a/Documentation/devicetree/bindings/display/bridge/renesas,dw-hdmi.txt b/Documentation/devicetree/bindings/display/bridge/renesas,dw-hdmi.txt > > index 819f3e31013c..e6526ab485d0 100644 > > --- a/Documentation/devicetree/bindings/display/bridge/renesas,dw-hdmi.txt > > +++ b/Documentation/devicetree/bindings/display/bridge/renesas,dw-hdmi.txt > > @@ -42,7 +42,7 @@ Optional properties: > > Example: > > > > hdmi0: hdmi@fead0000 { > > - compatible = "renesas,r8a7795-dw-hdmi"; > > + compatible = "renesas,r8a7795-hdmi"; > > reg = <0 0xfead0000 0 0x10000>; > > interrupts = <0 389 IRQ_TYPE_LEVEL_HIGH>; > > clocks = <&cpg CPG_CORE R8A7795_CLK_S0D4>, <&cpg CPG_MOD 729>; > > -- Regards, Laurent Pinchart _______________________________________________ dri-devel mailing list dri-devel@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/dri-devel