From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-11.2 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY, SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id A4EE2C43461 for ; Tue, 8 Sep 2020 20:00:06 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 73CCD20658 for ; Tue, 8 Sep 2020 20:00:06 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1731075AbgIHUAF (ORCPT ); Tue, 8 Sep 2020 16:00:05 -0400 Received: from foss.arm.com ([217.140.110.172]:55914 "EHLO foss.arm.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1730480AbgIHPfg (ORCPT ); Tue, 8 Sep 2020 11:35:36 -0400 Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id 579E91045; Tue, 8 Sep 2020 08:12:05 -0700 (PDT) Received: from arm.com (usa-sjc-imap-foss1.foss.arm.com [10.121.207.14]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPSA id 760ED3F73C; Tue, 8 Sep 2020 08:12:03 -0700 (PDT) Date: Tue, 8 Sep 2020 16:12:01 +0100 From: Dave Martin To: Peter Collingbourne Cc: Catalin Marinas , Evgenii Stepanov , Kostya Serebryany , Vincenzo Frascino , Will Deacon , Oleg Nesterov , "Eric W. Biederman" , "James E.J. Bottomley" , linux-parisc@vger.kernel.org, Andrey Konovalov , Kevin Brodsky , David Spickett , Linux ARM , Richard Henderson Subject: Re: [PATCH v10 1/7] parisc: start using signal-defs.h Message-ID: <20200908151200.GR6642@arm.com> References: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.5.23 (2014-03-12) Sender: linux-parisc-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-parisc@vger.kernel.org On Fri, Aug 21, 2020 at 10:10:11PM -0700, Peter Collingbourne wrote: > We currently include signal-defs.h on all architectures except parisc. > Make parisc fall in line. This will make maintenance easier once the > flag bits are moved here. > > Signed-off-by: Peter Collingbourne > --- > View this change in Gerrit: https://linux-review.googlesource.com/q/If03a5135fb514fe96548fb74610e6c3586a04064 > > arch/parisc/include/uapi/asm/signal.h | 9 +-------- > include/uapi/asm-generic/signal-defs.h | 6 ++++++ > 2 files changed, 7 insertions(+), 8 deletions(-) > > diff --git a/arch/parisc/include/uapi/asm/signal.h b/arch/parisc/include/uapi/asm/signal.h > index d38563a394f2..92a1c7ea44b4 100644 > --- a/arch/parisc/include/uapi/asm/signal.h > +++ b/arch/parisc/include/uapi/asm/signal.h > @@ -69,14 +69,7 @@ > #define MINSIGSTKSZ 2048 > #define SIGSTKSZ 8192 > > - > -#define SIG_BLOCK 0 /* for blocking signals */ > -#define SIG_UNBLOCK 1 /* for unblocking signals */ > -#define SIG_SETMASK 2 /* for setting the signal mask */ > - > -#define SIG_DFL ((__sighandler_t)0) /* default signal handling */ > -#define SIG_IGN ((__sighandler_t)1) /* ignore signal */ > -#define SIG_ERR ((__sighandler_t)-1) /* error return from signal */ > +#include > > # ifndef __ASSEMBLY__ > > diff --git a/include/uapi/asm-generic/signal-defs.h b/include/uapi/asm-generic/signal-defs.h > index e9304c95ceea..ecdf6312bfa5 100644 > --- a/include/uapi/asm-generic/signal-defs.h > +++ b/include/uapi/asm-generic/signal-defs.h > @@ -15,8 +15,14 @@ > #endif > > #ifndef __ASSEMBLY__ > +#ifndef __hppa__ > +/* > + * These have a special definition on parisc, see: > + * arch/parisc/include/uapi/asm/signal.h > + */ > typedef void __signalfn_t(int); > typedef __signalfn_t __user *__sighandler_t; > +#endif Could we do something like #ifndef __sighandler_t /* ... */ #define __sighandler_t __sighandler_t #endif Then we don't have to have anything parisc-specific in the common header, and arches can override this definition independently. Not a big deal either way, though, and best to keep the comment about why this is here in any case. Cheers ---Dave From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-11.3 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH, MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED, USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 83D6AC43461 for ; Tue, 8 Sep 2020 15:13:31 +0000 (UTC) Received: from merlin.infradead.org (merlin.infradead.org [205.233.59.134]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 20E9823C31 for ; Tue, 8 Sep 2020 15:13:31 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="H58FtPxi" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 20E9823C31 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=arm.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=merlin.20170209; h=Sender:Content-Transfer-Encoding: Content-Type:Cc:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References:Message-ID: Subject:To:From:Date:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=cYtFVDGDMn6PkFxDdkZD+4AbQyUJYLfuIPxd4A9Ot9Q=; b=H58FtPxiN6qkKtB3K7yonIYHd hJFwkyyW14MrPtNBbD0El63+FDmRSPdafENT7FVGMHUI/BxfclUy0wCTD9aKmFjfrz2uxQyZGhTht +5oLRoQfdM4dDok19A/VeDcH35Etl8Lv2HF1IZheE5nJ4jb8a6xmQw1Enih2kq6EOf1e7sDVIUJO9 LbyI7+I7Pdl7DLFLpzenYLjThvS4mpoMiNly5OdY4uOb1TvxDsQzfoiDdxIXKxJSe/E9R061+Qu15 tUQ3YHchrCJh4vn21MTTU1isxGvz8hxie3+GDPYMUcDNdHyS8t4KHlEiC/SOER/s/ODIx7gMwmyVu /Hgbs7+TQ==; Received: from localhost ([::1] helo=merlin.infradead.org) by merlin.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1kFfI3-0007JO-5V; Tue, 08 Sep 2020 15:12:11 +0000 Received: from foss.arm.com ([217.140.110.172]) by merlin.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1kFfHz-0007I4-5Y for linux-arm-kernel@lists.infradead.org; Tue, 08 Sep 2020 15:12:08 +0000 Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id 579E91045; Tue, 8 Sep 2020 08:12:05 -0700 (PDT) Received: from arm.com (usa-sjc-imap-foss1.foss.arm.com [10.121.207.14]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPSA id 760ED3F73C; Tue, 8 Sep 2020 08:12:03 -0700 (PDT) Date: Tue, 8 Sep 2020 16:12:01 +0100 From: Dave Martin To: Peter Collingbourne Subject: Re: [PATCH v10 1/7] parisc: start using signal-defs.h Message-ID: <20200908151200.GR6642@arm.com> References: MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.5.23 (2014-03-12) X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20200908_111207_308110_28EE56F4 X-CRM114-Status: GOOD ( 20.79 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Linux ARM , linux-parisc@vger.kernel.org, Catalin Marinas , Kevin Brodsky , Oleg Nesterov , "James E.J. Bottomley" , Kostya Serebryany , "Eric W. Biederman" , Andrey Konovalov , David Spickett , Vincenzo Frascino , Will Deacon , Evgenii Stepanov , Richard Henderson Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Fri, Aug 21, 2020 at 10:10:11PM -0700, Peter Collingbourne wrote: > We currently include signal-defs.h on all architectures except parisc. > Make parisc fall in line. This will make maintenance easier once the > flag bits are moved here. > > Signed-off-by: Peter Collingbourne > --- > View this change in Gerrit: https://linux-review.googlesource.com/q/If03a5135fb514fe96548fb74610e6c3586a04064 > > arch/parisc/include/uapi/asm/signal.h | 9 +-------- > include/uapi/asm-generic/signal-defs.h | 6 ++++++ > 2 files changed, 7 insertions(+), 8 deletions(-) > > diff --git a/arch/parisc/include/uapi/asm/signal.h b/arch/parisc/include/uapi/asm/signal.h > index d38563a394f2..92a1c7ea44b4 100644 > --- a/arch/parisc/include/uapi/asm/signal.h > +++ b/arch/parisc/include/uapi/asm/signal.h > @@ -69,14 +69,7 @@ > #define MINSIGSTKSZ 2048 > #define SIGSTKSZ 8192 > > - > -#define SIG_BLOCK 0 /* for blocking signals */ > -#define SIG_UNBLOCK 1 /* for unblocking signals */ > -#define SIG_SETMASK 2 /* for setting the signal mask */ > - > -#define SIG_DFL ((__sighandler_t)0) /* default signal handling */ > -#define SIG_IGN ((__sighandler_t)1) /* ignore signal */ > -#define SIG_ERR ((__sighandler_t)-1) /* error return from signal */ > +#include > > # ifndef __ASSEMBLY__ > > diff --git a/include/uapi/asm-generic/signal-defs.h b/include/uapi/asm-generic/signal-defs.h > index e9304c95ceea..ecdf6312bfa5 100644 > --- a/include/uapi/asm-generic/signal-defs.h > +++ b/include/uapi/asm-generic/signal-defs.h > @@ -15,8 +15,14 @@ > #endif > > #ifndef __ASSEMBLY__ > +#ifndef __hppa__ > +/* > + * These have a special definition on parisc, see: > + * arch/parisc/include/uapi/asm/signal.h > + */ > typedef void __signalfn_t(int); > typedef __signalfn_t __user *__sighandler_t; > +#endif Could we do something like #ifndef __sighandler_t /* ... */ #define __sighandler_t __sighandler_t #endif Then we don't have to have anything parisc-specific in the common header, and arches can override this definition independently. Not a big deal either way, though, and best to keep the comment about why this is here in any case. Cheers ---Dave _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel