All of lore.kernel.org
 help / color / mirror / Atom feed
From: Guenter Roeck <linux@roeck-us.net>
To: Naveen Krishna Ch <naveenkrishna.ch@gmail.com>
Cc: linux-hwmon@vger.kernel.org, Guenter Roeck <groeck7@gmail.com>
Subject: Re: FW: [PATCH 4/6] hwmon: amd_energy: let user enable/disable the sw accumulation
Date: Tue, 8 Sep 2020 09:36:25 -0700	[thread overview]
Message-ID: <20200908163625.GB169609@roeck-us.net> (raw)
In-Reply-To: <CAHfPSqDO3_KgSToQs9GNy3Ag8e4Am8z85qmi2fRSAz=62ztHmg@mail.gmail.com>

On Tue, Sep 08, 2020 at 09:51:23PM +0530, Naveen Krishna Ch wrote:
> Hi Guenter
> 
> On Tue, 8 Sep 2020 at 21:42, Chatradhi, Naveen Krishna
> <NaveenKrishna.Chatradhi@amd.com> wrote:
> >
> > [AMD Public Use]
> >
> > [CAUTION: External Email]
> >
> > On 9/5/20 8:17 AM, Guenter Roeck wrote:
> > > On 9/5/20 7:32 AM, Naveen Krishna Chatradhi wrote:
> > >> Provide an option "accumulator_status" via sysfs to enable/disable
> > >> the software accumulation of energy counters.
> > >>
> > >> Signed-off-by: Naveen Krishna Chatradhi <nchatrad@amd.com>
> > >
> > > I am quite substantially opposed to this. I'd be willing to accept a
> > > module parameter. However, the code is there, and it is enabled by
> > > default, and it should stay enabled by default.
> Sure, I will change it back.
> 
> > > I don't want to have to deal with people complaining that it suddenly
> > > no longer works.
> Understood.
> > >
> > > Also, there needs to be an explanation for why this is needed.
> > >
> >
> > No, wait, without accumulator this driver has zero value.
> > Users should just not load the driver if they don't want the overhead associated with accumulation.
> 
> The use case we have is to provide an interface to enable/disable
> accumulation by the admins, without having to reboot or install
> something.
> A userspace API is provided which will be used by the applications.
> 

Really, that should not be done. If accumulation is not wanted, the
driver is pointless and should be unloaded (or not be loaded to start
with).

Guenter

  reply	other threads:[~2020-09-08 16:36 UTC|newest]

Thread overview: 24+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-09-05 14:32 [PATCH 0/6] RFC: hwmon: few improvements to amd_energy driver Naveen Krishna Chatradhi
2020-09-05 14:32 ` [PATCH 1/6] hwmon: amd_energy: Move label out of accumulation structure Naveen Krishna Chatradhi
2020-09-05 14:32 ` [PATCH 2/6] hwmon: amd_energy: optimize accumulation interval Naveen Krishna Chatradhi
2020-09-05 15:11   ` Guenter Roeck
     [not found]     ` <DM6PR12MB4388DCF9B42BA0093774606FE82A0@DM6PR12MB4388.namprd12.prod.outlook.com>
2020-09-05 16:27       ` Naveen Krishna Ch
2020-09-05 14:32 ` [PATCH 3/6] hwmon: amd_energy: Improve the accumulation logic Naveen Krishna Chatradhi
2020-09-05 15:14   ` Guenter Roeck
     [not found]     ` <DM6PR12MB438850F9DFD14163F11AA946E82A0@DM6PR12MB4388.namprd12.prod.outlook.com>
2020-09-05 16:31       ` FW: " Naveen Krishna Ch
2020-09-05 14:32 ` [PATCH 4/6] hwmon: amd_energy: let user enable/disable the sw accumulation Naveen Krishna Chatradhi
2020-09-05 15:17   ` Guenter Roeck
2020-09-05 15:33     ` Guenter Roeck
     [not found]       ` <DM6PR12MB4388A21B749811BBE1309AA3E8290@DM6PR12MB4388.namprd12.prod.outlook.com>
2020-09-08 16:21         ` FW: " Naveen Krishna Ch
2020-09-08 16:36           ` Guenter Roeck [this message]
2020-09-05 14:32 ` [PATCH 5/6] hwmon: amd_energy: dump energy counters via debugfs Naveen Krishna Chatradhi
2020-09-05 15:19   ` Guenter Roeck
     [not found]     ` <DM6PR12MB4388C77E35BD61F4DC2EAEC9E82A0@DM6PR12MB4388.namprd12.prod.outlook.com>
2020-09-05 16:41       ` FW: " Naveen Krishna Ch
2020-09-05 16:58         ` Guenter Roeck
2020-09-08 16:10           ` Naveen Krishna Ch
2020-09-08 16:34             ` Guenter Roeck
2020-09-08 16:46               ` Naveen Krishna Ch
2020-09-08 17:11                 ` Guenter Roeck
2020-09-25  7:23                   ` Chatradhi, Naveen Krishna
2020-09-05 14:32 ` [PATCH 6/6] hwmon: (amd_energy) Update driver documentation Naveen Krishna Chatradhi
2020-09-25  7:26 ` [PATCH 0/6] RFC: hwmon: few improvements to amd_energy driver Chatradhi, Naveen Krishna

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20200908163625.GB169609@roeck-us.net \
    --to=linux@roeck-us.net \
    --cc=groeck7@gmail.com \
    --cc=linux-hwmon@vger.kernel.org \
    --cc=naveenkrishna.ch@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.