From: Bryan O'Donoghue <bryan.odonoghue@linaro.org>
To: kvalo@codeaurora.org, wcn36xx@lists.infradead.org,
linux-wireless@vger.kernel.org
Cc: bryan.odonoghue@linaro.org, shawn.guo@linaro.org,
loic.poulain@linaro.org
Subject: [PATCH v3 0/7] wcn36xx: Tidy up BSS/STA config
Date: Tue, 8 Sep 2020 19:24:48 +0100 [thread overview]
Message-ID: <20200908182455.2870345-1-bryan.odonoghue@linaro.org> (raw)
This series is three in a set of seven to add support for wcn3680 at 802.11ac
data-rates.
Both the BSS and STA config paths have redundant/duplicate code. Before
adding more code to either it makes sense to reduce/reuse and functionally
decompose as much as possible.
While not strictly necessary to get the wcn3680/80211.ac functioning in
this driver, it seems like a missed opportunity to leave the code as is.
Lets reduce down before adding more.
V3:
- No functional difference to V2
https://lore.kernel.org/linux-wireless/CAMZdPi___9yry0icuZVdnyiO7ZT0w=Xt8f8Pn7wkxRejxhXyYw@mail.gmail.com/T/#t
- Adds Loic's Reviewed-by as indicated
https://lore.kernel.org/linux-wireless/CAMZdPi___9yry0icuZVdnyiO7ZT0w=Xt8f8Pn7wkxRejxhXyYw@mail.gmail.com/T/#m2256137b97859c8eac26a2836f96db5e82475d3f
V2:
- Adds a memset to wcn36xx_smd_config_bss_v1()
Since we are doing one less kzalloc() we need to make sure we clear
out the bss config.
V1:
https://lore.kernel.org/linux-wireless/87eensldhi.fsf@codeaurora.org/T/#t
Bryan O'Donoghue (7):
wcn36xx: Functionally decompose wcn36xx_smd_config_sta()
wcn36xx: Move wcn36xx_smd_set_sta_params() inside
wcn36xx_smd_config_bss()
wcn36xx: Move BSS parameter setup to wcn36xx_smd_set_bss_params()
wcn36xx: Update wcn36xx_smd_config_bss_v1() to operate internally
wcn36xx: Add wcn36xx_smd_config_bss_v0
wcn36xx: Convert to using wcn36xx_smd_config_bss_v0()
wcn36xx: Remove dead code in wcn36xx_smd_config_bss()
drivers/net/wireless/ath/wcn36xx/smd.c | 416 ++++++++++++++-----------
1 file changed, 228 insertions(+), 188 deletions(-)
--
2.27.0
next reply other threads:[~2020-09-08 18:35 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-09-08 18:24 Bryan O'Donoghue [this message]
2020-09-08 18:24 ` [PATCH v3 1/7] wcn36xx: Functionally decompose wcn36xx_smd_config_sta() Bryan O'Donoghue
2020-09-08 18:24 ` [PATCH v3 2/7] wcn36xx: Move wcn36xx_smd_set_sta_params() inside wcn36xx_smd_config_bss() Bryan O'Donoghue
2020-09-08 18:24 ` [PATCH v3 3/7] wcn36xx: Move BSS parameter setup to wcn36xx_smd_set_bss_params() Bryan O'Donoghue
2020-09-08 18:24 ` [PATCH v3 4/7] wcn36xx: Update wcn36xx_smd_config_bss_v1() to operate internally Bryan O'Donoghue
2020-09-08 18:24 ` [PATCH v3 5/7] wcn36xx: Add wcn36xx_smd_config_bss_v0 Bryan O'Donoghue
2020-09-08 18:24 ` [PATCH v3 6/7] wcn36xx: Convert to using wcn36xx_smd_config_bss_v0() Bryan O'Donoghue
2020-09-08 18:24 ` [PATCH v3 7/7] wcn36xx: Remove dead code in wcn36xx_smd_config_bss() Bryan O'Donoghue
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200908182455.2870345-1-bryan.odonoghue@linaro.org \
--to=bryan.odonoghue@linaro.org \
--cc=kvalo@codeaurora.org \
--cc=linux-wireless@vger.kernel.org \
--cc=loic.poulain@linaro.org \
--cc=shawn.guo@linaro.org \
--cc=wcn36xx@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.