From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-11.7 required=3.0 tests=BAYES_00,DKIMWL_WL_MED, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,FSL_HELO_FAKE, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE, SPF_PASS,USER_IN_DEF_DKIM_WL autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 6EE03C2BC11 for ; Tue, 8 Sep 2020 21:23:23 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 323F82145D for ; Tue, 8 Sep 2020 21:23:23 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=google.com header.i=@google.com header.b="W3Pr3Jck" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1730184AbgIHVXW (ORCPT ); Tue, 8 Sep 2020 17:23:22 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:49342 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1730161AbgIHVXM (ORCPT ); Tue, 8 Sep 2020 17:23:12 -0400 Received: from mail-pg1-x544.google.com (mail-pg1-x544.google.com [IPv6:2607:f8b0:4864:20::544]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 953ADC061573 for ; Tue, 8 Sep 2020 14:23:10 -0700 (PDT) Received: by mail-pg1-x544.google.com with SMTP id 67so434597pgd.12 for ; Tue, 08 Sep 2020 14:23:10 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20161025; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to; bh=ih6QbdC2BlMXbYNA/XrG1Rz+rSEU4l2iSukj1ZYcfcE=; b=W3Pr3JckrBkhsvVBPRqyalyPCHmDdjwsO8lMz82fl3992mSkJBCa/ynKYFlOpa29KS YrQvjiSk8Gsj+2F0XyIFg6bT/TX3bdtqIzg+X9zApTyghMxBvgeVK7VjGnj0Xvez1x1T vtDDvMHWVF2Q9VElpy4Et4CUBV2fAGlDpuHSIHxSfO2vTMGl2CEODJDA3aVOsYuSr2rb 54oZUVIzZ6F0vJ0E2vHEj9aGY9uEozAJoPE35B9/ZkY30GF+FwBSaPHMJZxUW1Gwmrih hraJxCrNOD15xVsyVUJ11S0Z4yNK+aS0/3uKyQbwkUQtxQoq+M+Ub2vQlfRLbEhbUoo0 TnTQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=ih6QbdC2BlMXbYNA/XrG1Rz+rSEU4l2iSukj1ZYcfcE=; b=d5AJxaZO/2rKEyQIzRo7OPlfl/aRb1l+N3HCd3okj+nloQZjV3lUZ4SqUELUooftpS CcKktF/Kvy5eyLEj92cWQHvoRQhfsOqVaYTvcUP76d2RGxUO7vo4mo6OAeAlSQr4T+Za EciGeVxtT0aoyBb/ti91CTbhFbRT5fbZDh5HfUhmWQvcBLj7DxnTAY8nX5OklXv0kxZ8 0OFDX/RWz1DN15+xIqLs/fkro69m8uHyYawDIERbqh02I/s+GAOotELeuDKwS5ZIhcmx MTPGKH9dqb/S4A7QivV1/CSnsJ3GmqL7LeVkY8GBWC0mfYpblWs5bq8rlaQtKVbw0GI9 hmew== X-Gm-Message-State: AOAM5328JmYZBTKCWtjirjlHXqEfzlEAXUpxXZC5f7JtmCquF+0ZCGSk WUuJgl2+by0BZCDTOevfz7DkdA== X-Google-Smtp-Source: ABdhPJxZtQ6suAAYIvComwJnL/d5p58yR7wkXLgcU+gM/W/qIhxDDa8Jsi9la7BgYDO45OUXHd5G6Q== X-Received: by 2002:a05:6a00:1356:b029:13e:d13d:a084 with SMTP id k22-20020a056a001356b029013ed13da084mr947839pfu.27.1599600189879; Tue, 08 Sep 2020 14:23:09 -0700 (PDT) Received: from google.com ([2620:15c:201:2:f693:9fff:fef4:1b6d]) by smtp.gmail.com with ESMTPSA id gk14sm161668pjb.41.2020.09.08.14.23.08 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 08 Sep 2020 14:23:09 -0700 (PDT) Date: Tue, 8 Sep 2020 14:23:02 -0700 From: Sami Tolvanen To: Kees Cook Cc: Masahiro Yamada , Will Deacon , Peter Zijlstra , Steven Rostedt , Greg Kroah-Hartman , "Paul E. McKenney" , Nick Desaulniers , clang-built-linux@googlegroups.com, kernel-hardening@lists.openwall.com, linux-arch@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-kbuild@vger.kernel.org, linux-kernel@vger.kernel.org, linux-pci@vger.kernel.org, x86@kernel.org Subject: Re: [PATCH v2 22/28] arm64: export CC_USING_PATCHABLE_FUNCTION_ENTRY Message-ID: <20200908212302.GD1060586@google.com> References: <20200624203200.78870-1-samitolvanen@google.com> <20200903203053.3411268-1-samitolvanen@google.com> <20200903203053.3411268-23-samitolvanen@google.com> <202009031544.D66F02D407@keescook> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <202009031544.D66F02D407@keescook> Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu, Sep 03, 2020 at 03:44:18PM -0700, Kees Cook wrote: > On Thu, Sep 03, 2020 at 01:30:47PM -0700, Sami Tolvanen wrote: > > Since arm64 does not use -pg in CC_FLAGS_FTRACE with > > DYNAMIC_FTRACE_WITH_REGS, skip running recordmcount by > > exporting CC_USING_PATCHABLE_FUNCTION_ENTRY. > > > > Signed-off-by: Sami Tolvanen > > How stand-alone is this? Does it depend on the earlier mcount fixes? It does, because exporting CC_USING_PATCHABLE_FUNCTION_ENTRY doesn't change anything without the earlier mcount changes. Sami From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-4.1 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_ADSP_CUSTOM_MED,DKIM_SIGNED,DKIM_VALID,FSL_HELO_FAKE, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE, SPF_PASS,URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 55BCBC43461 for ; Tue, 8 Sep 2020 21:24:33 +0000 (UTC) Received: from merlin.infradead.org (merlin.infradead.org [205.233.59.134]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id E67522145D for ; Tue, 8 Sep 2020 21:24:32 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="z1h5QSSr"; dkim=fail reason="signature verification failed" (2048-bit key) header.d=google.com header.i=@google.com header.b="W3Pr3Jck" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org E67522145D Authentication-Results: mail.kernel.org; dmarc=fail (p=reject dis=none) header.from=google.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=merlin.20170209; h=Sender:Content-Transfer-Encoding: Content-Type:Cc:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References:Message-ID: Subject:To:From:Date:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=ov0GjtudAlWUq6E2xAz2lhfUNFR/1CM6lnqUUAXqVU8=; b=z1h5QSSrtKzk4CAhLoBR/EGlK Du1XX3S2J4wXV7OOrhQVZ6fpNw19+5kVk30icZ5yaYtTQADk2CrMpNN/Vxoyxx1L0Acho6H7HvzHV krcf0g3XLgHnmNabzcPHR3rtYzu7YZmXVAFOT3192wuCE0WuXE+POJEaSM+EiUQm39WvyDyaQKdOJ Go71p73BTvhMNJos2JZyrIR2kZlakmnzcEaQ/cfxKBXRpDxkvsfP3U6hntuQWbHcyclqT/VzPj99p feS7ZysT76/9T4xONzzFUrP2FOOQv2HYGbbuqR7AoN3tcH6K+97MOwQ31rjUL7n30DK4BXw+DmnC5 MSvuwhMrg==; Received: from localhost ([::1] helo=merlin.infradead.org) by merlin.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1kFl58-00004u-9x; Tue, 08 Sep 2020 21:23:14 +0000 Received: from mail-pf1-x444.google.com ([2607:f8b0:4864:20::444]) by merlin.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1kFl56-0008VO-4E for linux-arm-kernel@lists.infradead.org; Tue, 08 Sep 2020 21:23:12 +0000 Received: by mail-pf1-x444.google.com with SMTP id w7so240248pfi.4 for ; Tue, 08 Sep 2020 14:23:11 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20161025; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to; bh=ih6QbdC2BlMXbYNA/XrG1Rz+rSEU4l2iSukj1ZYcfcE=; b=W3Pr3JckrBkhsvVBPRqyalyPCHmDdjwsO8lMz82fl3992mSkJBCa/ynKYFlOpa29KS YrQvjiSk8Gsj+2F0XyIFg6bT/TX3bdtqIzg+X9zApTyghMxBvgeVK7VjGnj0Xvez1x1T vtDDvMHWVF2Q9VElpy4Et4CUBV2fAGlDpuHSIHxSfO2vTMGl2CEODJDA3aVOsYuSr2rb 54oZUVIzZ6F0vJ0E2vHEj9aGY9uEozAJoPE35B9/ZkY30GF+FwBSaPHMJZxUW1Gwmrih hraJxCrNOD15xVsyVUJ11S0Z4yNK+aS0/3uKyQbwkUQtxQoq+M+Ub2vQlfRLbEhbUoo0 TnTQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=ih6QbdC2BlMXbYNA/XrG1Rz+rSEU4l2iSukj1ZYcfcE=; b=NWCvhzAguVPdZEaFiHsyJof6g5gEFanP3qqJgY/YjSM4CK5PaQzCiKdtvQJbuxfW88 GUuPQ2A6jILOq9+6ifeZvGkT2+qoDZ4NM3/YjZlsiEVpCCwbE4roPbvxI8sQvtZDo8V1 3M0zwf/U+dRXE0wjRjJ42AOstIUF3obHUFvGrR/sZojqt0dSFwTc6Eu436B4UrgogX+G IpEscoIc/+AbdzlnVsHs0FyZjl+6R6z4EMmkkPlgB/ab8aLDjJwDsjZl2Prw64XKk5Jw YnIC0q6H60QZ/ImmNRMcvE/eaFq+mk5h/xRG/Z92H3UWoYk9324J+60Ffv0mPLyfkrjY 7AiQ== X-Gm-Message-State: AOAM5311nAgtoc68fWnWikiCI6Bhty9/nrHLmzpMN6gPFYMo/GyQ90Ro Ch1CJ0c9Xy6XWt5oz2GG71+rIA== X-Google-Smtp-Source: ABdhPJxZtQ6suAAYIvComwJnL/d5p58yR7wkXLgcU+gM/W/qIhxDDa8Jsi9la7BgYDO45OUXHd5G6Q== X-Received: by 2002:a05:6a00:1356:b029:13e:d13d:a084 with SMTP id k22-20020a056a001356b029013ed13da084mr947839pfu.27.1599600189879; Tue, 08 Sep 2020 14:23:09 -0700 (PDT) Received: from google.com ([2620:15c:201:2:f693:9fff:fef4:1b6d]) by smtp.gmail.com with ESMTPSA id gk14sm161668pjb.41.2020.09.08.14.23.08 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 08 Sep 2020 14:23:09 -0700 (PDT) Date: Tue, 8 Sep 2020 14:23:02 -0700 From: Sami Tolvanen To: Kees Cook Subject: Re: [PATCH v2 22/28] arm64: export CC_USING_PATCHABLE_FUNCTION_ENTRY Message-ID: <20200908212302.GD1060586@google.com> References: <20200624203200.78870-1-samitolvanen@google.com> <20200903203053.3411268-1-samitolvanen@google.com> <20200903203053.3411268-23-samitolvanen@google.com> <202009031544.D66F02D407@keescook> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <202009031544.D66F02D407@keescook> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20200908_172312_209893_11AEDC79 X-CRM114-Status: GOOD ( 14.53 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: linux-arch@vger.kernel.org, x86@kernel.org, "Paul E. McKenney" , kernel-hardening@lists.openwall.com, Peter Zijlstra , Greg Kroah-Hartman , Masahiro Yamada , linux-kbuild@vger.kernel.org, Nick Desaulniers , linux-kernel@vger.kernel.org, Steven Rostedt , clang-built-linux@googlegroups.com, linux-pci@vger.kernel.org, Will Deacon , linux-arm-kernel@lists.infradead.org Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Thu, Sep 03, 2020 at 03:44:18PM -0700, Kees Cook wrote: > On Thu, Sep 03, 2020 at 01:30:47PM -0700, Sami Tolvanen wrote: > > Since arm64 does not use -pg in CC_FLAGS_FTRACE with > > DYNAMIC_FTRACE_WITH_REGS, skip running recordmcount by > > exporting CC_USING_PATCHABLE_FUNCTION_ENTRY. > > > > Signed-off-by: Sami Tolvanen > > How stand-alone is this? Does it depend on the earlier mcount fixes? It does, because exporting CC_USING_PATCHABLE_FUNCTION_ENTRY doesn't change anything without the earlier mcount changes. Sami _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel