From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-12.1 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,MAILING_LIST_MULTI,MENTIONS_GIT_HOSTING, SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 4B367C43461 for ; Tue, 8 Sep 2020 22:39:33 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 1576520757 for ; Tue, 8 Sep 2020 22:39:33 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1599604773; bh=p3SCNQSZriSpfsmnFhDYpZyKCKZix6tZbg5PzqvY3yc=; h=Date:From:To:Cc:Subject:In-Reply-To:List-ID:From; b=Ul9r/9Lf+eTwxkvD6KH4QUXezTSkFETBLHFD5ysey21/oGmUUV7SekFCHbM1MhDTl 9v1BVKQwoiQbx2rS0ROnGROgkJ9Lb4Jl+vPB6yqul3OB1GRjyPw/fKDOhXxKLBSqrL s9rvUASFJYlJbf1nAovOQ5rDvWpB1Rt/Xsk4aMRA= Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1729413AbgIHWjc (ORCPT ); Tue, 8 Sep 2020 18:39:32 -0400 Received: from mail.kernel.org ([198.145.29.99]:51824 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1725997AbgIHWj3 (ORCPT ); Tue, 8 Sep 2020 18:39:29 -0400 Received: from localhost (35.sub-72-107-115.myvzw.com [72.107.115.35]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id B6D9120757; Tue, 8 Sep 2020 22:39:28 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1599604769; bh=p3SCNQSZriSpfsmnFhDYpZyKCKZix6tZbg5PzqvY3yc=; h=Date:From:To:Cc:Subject:In-Reply-To:From; b=ABOcrC3EhkUg45HI4mWN4wDVv6kiMsASU52p1/lQoSqTnausqYnFGQZPfXOyqzJTx rkr/Q4fP/yZAtT3nyMb9bOOkECya3pel1+lS65Zkdt6fPo93rKLuSr1f/uUPhQ3jgi gcP7YWCgkoxQSlL+o8nsP42/f4sKyqjve2OkLljM= Date: Tue, 8 Sep 2020 17:39:27 -0500 From: Bjorn Helgaas To: Hongtao Wu Cc: Lorenzo Pieralisi , Rob Herring , Orson Zhai , Baolin Wang , Chunyan Zhang , linux-pci@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, Billows Wu Subject: Re: [PATCH v2 2/2] PCI: sprd: Add support for Unisoc SoCs' PCIe controller Message-ID: <20200908223927.GA647146@bjorn-Precision-5520> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1599572841-2652-3-git-send-email-wuht06@gmail.com> Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, Sep 08, 2020 at 09:47:21PM +0800, Hongtao Wu wrote: > From: Billows Wu > > This series adds PCIe controller driver for Unisoc SoCs. > This controller is based on DesignWare PCIe IP. > > Signed-off-by: Billows Wu Last signed-off must be from developer submitting the patch, i.e., Hongtao Wu; see https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/tree/Documentation/process/submitting-patches.rst#n560 > +config PCIE_SPRD > + tristate "Unisoc PCIe controller - RC mode" s/RC mode/Host mode/ to follow convention of other drivers. > + depends on ARCH_SPRD || COMPILE_TEST > + depends on PCI_MSI_IRQ_DOMAIN > + select PCIE_DW_HOST > + help > + Unisoc PCIe controller uses the Designware core. It can be configured s/Designware/DesignWare/ > + as an Endpoint (EP) or a Root complex (RC). In order to enable RC > + mode, PCIE_SPRD must be selected. > + Say Y or M here if you want to PCIe RC controller support on Unisoc > + SoCs. > + dev_dbg(&pdev->dev, dev_dbg(dev, ... > + "%2d:reg[0x%8x] mask[0x%8x] val[0x%8x] result[0x%8x]\n", > + i, reg, mask, val, tmp_val);