From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.3 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI, SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 2589AC433E2 for ; Wed, 9 Sep 2020 11:08:50 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id C63DC21582 for ; Wed, 9 Sep 2020 11:08:49 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="R365BsX7" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727010AbgIILIi (ORCPT ); Wed, 9 Sep 2020 07:08:38 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:34834 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1729622AbgIILH1 (ORCPT ); Wed, 9 Sep 2020 07:07:27 -0400 Received: from mail-pj1-x1043.google.com (mail-pj1-x1043.google.com [IPv6:2607:f8b0:4864:20::1043]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id D01EBC061756 for ; Wed, 9 Sep 2020 04:07:13 -0700 (PDT) Received: by mail-pj1-x1043.google.com with SMTP id gf14so1166453pjb.5 for ; Wed, 09 Sep 2020 04:07:13 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to:user-agent; bh=vov2dA/KW/bn72Ejzr9klJyhX5C88qedShxokRR3aNg=; b=R365BsX7Ty4AzzqOSLwELZjOZev1K7gL80aq+v4OVAV6+F4TcWo9C+0dMIYzsLxkVx +i8yCdt9e569HVDNWo1DDHrtItgxrB9kATz3/PqjbR3nbgUDebwF3G81O7b3dWiaTKlK g+lOVocaZ8uCYuiExZFnnyj+X9iT3nXMfAdEj+yNQaaQcoRBKK6qR1KbGsKRr10Jep/j h0cUBCGDCrWIydOWCVVWvoay4gX2I2PZDWgd/MZyXWFWKNpTN3t/Nm3tV46jQIpc3Nu7 hYmUfP2voxzFM4xbvV3h16QnYOELlaYWGHnkkz+YBlYP10XikBbMa93P8JkODTS0UwCn uPzw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to:user-agent; bh=vov2dA/KW/bn72Ejzr9klJyhX5C88qedShxokRR3aNg=; b=g7rZSeulCqVaV0DLv2s9G9g6LnF4PvvgsT9JiQStWaJWCAZKBqkK6CsDdwlUB3TncA 5GkECzY7vB0jOyDSq9p3LEco3mHT9ijiP5SZ0Ez6iYjKs9yTKbYxCQiciarb13hIEKC3 oqonPhqxFP0uYfa1hZYYvxRueGRDwIpfJZ2UY2CGFG7Qn3U/rZ1VjwdP4FBSoZI5DMff kJF70Tev2KUaA6jtwWOsvuewEgfvpyuOW4vlstVAFxP7jrIu4aJbYYqa1B7eGILGI4Dy W1gOsrD82CFZuZLAS4aU0U9gQE3v7Vq4Wy18RhJGm+m4a8Fq4krtP4Fv0tEfQAre5SCJ JjnA== X-Gm-Message-State: AOAM532HFS2OLJ0/9HbazKh19wNmOKDZwdptTBT+22zXQcS4k1P+uyw8 AAZCedkGqoBeHAYJoxmeKDoesQav5f6eWA== X-Google-Smtp-Source: ABdhPJyCZVgnQXi30pqYsiZcXXeTmANMigiEsaDsJ6dg0Pg/CZzHHwSMlI2D1oXOAeWt1zTAKG+xhg== X-Received: by 2002:a17:90a:13c7:: with SMTP id s7mr393903pjf.124.1599649633150; Wed, 09 Sep 2020 04:07:13 -0700 (PDT) Received: from localhost ([122.181.54.133]) by smtp.gmail.com with ESMTPSA id j35sm1804786pgi.91.2020.09.09.04.07.11 (version=TLS1_2 cipher=ECDHE-ECDSA-AES128-GCM-SHA256 bits=128/128); Wed, 09 Sep 2020 04:07:12 -0700 (PDT) Date: Wed, 9 Sep 2020 16:37:07 +0530 From: Viresh Kumar To: Ulf Hansson Cc: Rajendra Nayak , Adrian Hunter , Andy Gross , Bjorn Andersson , Linux PM , Vincent Guittot , Rafael Wysocki , Stephen Boyd , Nishanth Menon , Douglas Anderson , Naresh Kamboju , linux-arm-msm , "linux-mmc@vger.kernel.org" , Linux Kernel Mailing List Subject: Re: [PATCH V2 4/8] mmc: sdhci-msm: Unconditionally call dev_pm_opp_of_remove_table() Message-ID: <20200909110707.jv2beta5rdr3wux3@vireshk-i7> References: <1d7c97524b9e1fbc60271d9c246c5461ca8a106c.1598594714.git.viresh.kumar@linaro.org> <20200831104453.ux5fb5bpt57tj5am@vireshk-i7> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: NeoMutt/20180716-391-311a52 Sender: linux-arm-msm-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-arm-msm@vger.kernel.org On 31-08-20, 12:57, Ulf Hansson wrote: > On Mon, 31 Aug 2020 at 12:45, Viresh Kumar wrote: > > > > On 28-08-20, 10:43, Ulf Hansson wrote: > > > On Fri, 28 Aug 2020 at 08:08, Viresh Kumar wrote: > > > > > > > > dev_pm_opp_of_remove_table() doesn't report any errors when it fails to > > > > find the OPP table with error -ENODEV (i.e. OPP table not present for > > > > the device). And we can call dev_pm_opp_of_remove_table() > > > > unconditionally here. > > > > > > > > Signed-off-by: Viresh Kumar > > > > > > Replaced v1 with v2 on my next branch, thanks! > > > > > > Just to be sure, this patch doesn't depend on any changes for the opp > > > core that are queued for v5.10? > > > > The recent crashes reported by Anders and Naresh were related to a OPP > > core bug, for which I have just sent the fix here: > > > > https://lore.kernel.org/lkml/922ff0759a16299e24cacfc981ac07914d8f1826.1598865786.git.viresh.kumar@linaro.org/ > > > > This is already tested by Naresh now and finally everything works as > > expected. > > > > I am going to get this fix merged in 5.9-rc4, but we do have a > > dependency now with that fix. > > > > What's the best way to handle this stuff now ? The easiest IMO would > > be for me to send these patches through the OPP tree, otherwise people > > need to carry this and the OPP fix (for which I can provide the > > branch/tag). > > No need for a tag/branch to be shared. Instead I am simply going to > defer to pick up any related changes for mmc, until I can rebase my > tree on an rc[n] that contains your fix. > > When that is possible, please re-post the mmc patches. The dependency patch got merged in 5.9-rc4. Do you still want me to resend this patch or you can apply it directly from here ? -- viresh