From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from list by lists.gnu.org with archive (Exim 4.90_1) id 1kFyGu-00011u-1D for mharc-grub-devel@gnu.org; Wed, 09 Sep 2020 07:28:16 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:60532) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1kFyGs-0000yj-Ut for grub-devel@gnu.org; Wed, 09 Sep 2020 07:28:14 -0400 Received: from userp2120.oracle.com ([156.151.31.85]:37822) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1kFyGq-0006aI-R7 for grub-devel@gnu.org; Wed, 09 Sep 2020 07:28:14 -0400 Received: from pps.filterd (userp2120.oracle.com [127.0.0.1]) by userp2120.oracle.com (8.16.0.42/8.16.0.42) with SMTP id 089BO04q104996; Wed, 9 Sep 2020 11:28:08 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oracle.com; h=date : from : to : cc : subject : message-id : references : mime-version : content-type : in-reply-to; s=corp-2020-01-29; bh=RJRlfXytEQ8L/vB/ksMR8IldJXwqtn0kIymlgxl9c5M=; b=StWpZcGco1dJyAvVyebpKWnWiFE2Djc2QLDqBrSs8LRMjwpLWiF/5f3u2aQVPVhDEozK AZtEYMxdLB6ShNAHaz1CjRJPT7Vqz/yUTwrXqzITxAnHzLnZFAYeDbapEfff1E6O769E oBaPQq0dVD+b9TBatNeidYOyu1MwVnwNM84h1Q06n0RqwYHG7wYFjGEDeF5pVq5jOk/S lAFBPd+IvxkeCHLPATrt4jhKQE3JFQcZ3+7sgsj+nurLBGvOqxKUmxfRq+sYh1qbPVxs ed8CB0zTcNSRZwTXv76+ecC6WombB7ZcvlEHyfKKJb622r9QmyFleTDyRB8cOAsXzz6s NQ== Received: from userp3020.oracle.com (userp3020.oracle.com [156.151.31.79]) by userp2120.oracle.com with ESMTP id 33c3an102r-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=FAIL); Wed, 09 Sep 2020 11:28:08 +0000 Received: from pps.filterd (userp3020.oracle.com [127.0.0.1]) by userp3020.oracle.com (8.16.0.42/8.16.0.42) with SMTP id 089BQPEr109272; Wed, 9 Sep 2020 11:28:07 GMT Received: from aserv0122.oracle.com (aserv0122.oracle.com [141.146.126.236]) by userp3020.oracle.com with ESMTP id 33cmespvv4-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Wed, 09 Sep 2020 11:28:07 +0000 Received: from abhmp0020.oracle.com (abhmp0020.oracle.com [141.146.116.26]) by aserv0122.oracle.com (8.14.4/8.14.4) with ESMTP id 089BS5U7024205; Wed, 9 Sep 2020 11:28:06 GMT Received: from tomti.i.net-space.pl (/10.175.189.45) by default (Oracle Beehive Gateway v4.0) with ESMTP ; Wed, 09 Sep 2020 04:28:05 -0700 Date: Wed, 9 Sep 2020 13:28:01 +0200 From: Daniel Kiper To: Patrick Steinhardt Cc: grub-devel@gnu.org, Denis GNUtoo Carikli , Glenn Washburn Subject: Re: [PATCH v3 0/9] Cryptodisk fixes for v2.06 Message-ID: <20200909112801.kdveit7qjmbuqfql@tomti.i.net-space.pl> References: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: NeoMutt/20170113 (1.7.2) X-Proofpoint-Virus-Version: vendor=nai engine=6000 definitions=9738 signatures=668679 X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 spamscore=0 suspectscore=0 adultscore=0 bulkscore=0 phishscore=0 malwarescore=0 mlxlogscore=999 mlxscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2006250000 definitions=main-2009090102 X-Proofpoint-Virus-Version: vendor=nai engine=6000 definitions=9738 signatures=668679 X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 phishscore=0 priorityscore=1501 clxscore=1015 bulkscore=0 malwarescore=0 lowpriorityscore=0 mlxlogscore=999 suspectscore=0 adultscore=0 mlxscore=0 impostorscore=0 spamscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2006250000 definitions=main-2009090102 Received-SPF: pass client-ip=156.151.31.85; envelope-from=daniel.kiper@oracle.com; helo=userp2120.oracle.com X-detected-operating-system: by eggs.gnu.org: First seen = 2020/09/09 07:22:14 X-ACL-Warn: Detected OS = Linux 3.1-3.10 [fuzzy] X-Spam_score_int: -43 X-Spam_score: -4.4 X-Spam_bar: ---- X-Spam_report: (-4.4 / 5.0 requ) BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.001, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_MED=-2.3, RCVD_IN_MSPIKE_H2=-0.001, SPF_HELO_PASS=-0.001, SPF_PASS=-0.001, UNPARSEABLE_RELAY=0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: grub-devel@gnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: The development of GNU GRUB List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 09 Sep 2020 11:28:15 -0000 Hey Patrick, On Mon, Sep 07, 2020 at 05:27:27PM +0200, Patrick Steinhardt wrote: > Hi, > > this is the third version of this patchset, collecting various fixes for > LUKS2/cryptodisk for the upcoming release of GRUB v2.06. > > Besides my Reviewed-by tag, the only thing that changed is the final > patch by Glenn. Quoting him: > > > The main difference with this patch is that sector_size is renamed to > > log_sector_size, grub has enough inaccurate or misleading names. > > Additionally, rename LOG_SECTOR_SIZE to LUKS_LOG_SECTOR_SIZE and > > CRYPT_LOG_SECTOR_SIZE to GRUB_CRYPTODISK_IV_LOG_SIZE and moved to > > cryptodisk.h. Also a comment was reworded for clarity. A few patches require some polishing. However, feel free to add Reviewed-by: Daniel Kiper to the patches 1, 2, 5, 6 and 7. Daniel