All of lore.kernel.org
 help / color / mirror / Atom feed
From: kernel test robot <lkp@intel.com>
To: kbuild-all@lists.01.org
Subject: Re: [PATCH v3 3/7] wcn36xx: Add wcn36xx_smd_set_sta_default_ht_ldpc_params()
Date: Wed, 09 Sep 2020 16:49:36 +0800	[thread overview]
Message-ID: <202009091604.tAKqFtHt%lkp@intel.com> (raw)
In-Reply-To: <20200908182437.2870281-4-bryan.odonoghue@linaro.org>

[-- Attachment #1: Type: text/plain, Size: 6752 bytes --]

Hi Bryan,

I love your patch! Perhaps something to improve:

[auto build test WARNING on wireless-drivers-next/master]
[also build test WARNING on wireless-drivers/master ath6kl/ath-next v5.9-rc4 next-20200908]
[If your patch is applied to the wrong git tree, kindly drop us a note.
And when submitting patch, we suggest to use '--base' as documented in
https://git-scm.com/docs/git-format-patch]

url:    https://github.com/0day-ci/linux/commits/Bryan-O-Donoghue/wcn36xx-Add-a-set-of-helpers-to-enable-VHT-parameter-passing/20200909-115630
base:   https://git.kernel.org/pub/scm/linux/kernel/git/kvalo/wireless-drivers-next.git master
config: i386-allyesconfig (attached as .config)
compiler: gcc-9 (Debian 9.3.0-15) 9.3.0
reproduce (this is a W=1 build):
        # save the attached .config to linux build tree
        make W=1 ARCH=i386 

If you fix the issue, kindly add following tag as appropriate
Reported-by: kernel test robot <lkp@intel.com>

All warnings (new ones prefixed by >>):

   In file included from drivers/net/wireless/ath/wcn36xx/smd.h:20,
                    from drivers/net/wireless/ath/wcn36xx/smd.c:23:
   drivers/net/wireless/ath/wcn36xx/wcn36xx.h:272:42: warning: 'struct wcn36xx_hal_supported_rates_v1' declared inside parameter list will not be visible outside of this definition or declaration
     272 | void wcn36xx_set_default_rates_v1(struct wcn36xx_hal_supported_rates_v1 *rates);
         |                                          ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
   drivers/net/wireless/ath/wcn36xx/smd.c:192:6: warning: no previous prototype for 'wcn36xx_smd_set_sta_default_vht_params' [-Wmissing-prototypes]
     192 | void wcn36xx_smd_set_sta_default_vht_params(struct wcn36xx *wcn,
         |      ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
   drivers/net/wireless/ath/wcn36xx/smd.c: In function 'wcn36xx_smd_set_sta_default_vht_params':
   drivers/net/wireless/ath/wcn36xx/smd.c:195:20: error: 'RF_IRIS_WCN3680' undeclared (first use in this function); did you mean 'RF_IRIS_WCN3620'?
     195 |  if (wcn->rf_id == RF_IRIS_WCN3680) {
         |                    ^~~~~~~~~~~~~~~
         |                    RF_IRIS_WCN3620
   drivers/net/wireless/ath/wcn36xx/smd.c:195:20: note: each undeclared identifier is reported only once for each function it appears in
   drivers/net/wireless/ath/wcn36xx/smd.c:196:15: error: 'struct wcn36xx_hal_config_sta_params_v1' has no member named 'vht_capable'; did you mean 'ht_capable'?
     196 |   sta_params->vht_capable = 1;
         |               ^~~~~~~~~~~
         |               ht_capable
   drivers/net/wireless/ath/wcn36xx/smd.c:197:13: error: 'struct wcn36xx_hal_config_sta_params_v1' has no member named 'vht_tx_mu_beamformee_capable'
     197 |   sta_params->vht_tx_mu_beamformee_capable = 1;
         |             ^~
   drivers/net/wireless/ath/wcn36xx/smd.c:199:15: error: 'struct wcn36xx_hal_config_sta_params_v1' has no member named 'vht_capable'; did you mean 'ht_capable'?
     199 |   sta_params->vht_capable = 0;
         |               ^~~~~~~~~~~
         |               ht_capable
   drivers/net/wireless/ath/wcn36xx/smd.c:200:13: error: 'struct wcn36xx_hal_config_sta_params_v1' has no member named 'vht_tx_mu_beamformee_capable'
     200 |   sta_params->vht_tx_mu_beamformee_capable = 0;
         |             ^~
   drivers/net/wireless/ath/wcn36xx/smd.c:203:12: error: 'struct wcn36xx_hal_config_sta_params_v1' has no member named 'vht_ldpc_enabled'
     203 |  sta_params->vht_ldpc_enabled = 0;
         |            ^~
   drivers/net/wireless/ath/wcn36xx/smd.c:204:14: error: 'struct wcn36xx_hal_config_sta_params_v1' has no member named 'vht_tx_channel_width_set'; did you mean 'tx_channel_width_set'?
     204 |  sta_params->vht_tx_channel_width_set = 0;
         |              ^~~~~~~~~~~~~~~~~~~~~~~~
         |              tx_channel_width_set
   drivers/net/wireless/ath/wcn36xx/smd.c:205:12: error: 'struct wcn36xx_hal_config_sta_params_v1' has no member named 'vht_tx_bf_enabled'
     205 |  sta_params->vht_tx_bf_enabled = 0;
         |            ^~
   drivers/net/wireless/ath/wcn36xx/smd.c: At top level:
>> drivers/net/wireless/ath/wcn36xx/smd.c:208:6: warning: no previous prototype for 'wcn36xx_smd_set_sta_default_ht_ldpc_params' [-Wmissing-prototypes]
     208 | void wcn36xx_smd_set_sta_default_ht_ldpc_params(struct wcn36xx *wcn,
         |      ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
   drivers/net/wireless/ath/wcn36xx/smd.c: In function 'wcn36xx_smd_set_sta_default_ht_ldpc_params':
   drivers/net/wireless/ath/wcn36xx/smd.c:211:20: error: 'RF_IRIS_WCN3680' undeclared (first use in this function); did you mean 'RF_IRIS_WCN3620'?
     211 |  if (wcn->rf_id == RF_IRIS_WCN3680)
         |                    ^~~~~~~~~~~~~~~
         |                    RF_IRIS_WCN3620
   drivers/net/wireless/ath/wcn36xx/smd.c:212:13: error: 'struct wcn36xx_hal_config_sta_params_v1' has no member named 'ht_ldpc_enabled'
     212 |   sta_params->ht_ldpc_enabled = 1;
         |             ^~
   drivers/net/wireless/ath/wcn36xx/smd.c:214:13: error: 'struct wcn36xx_hal_config_sta_params_v1' has no member named 'ht_ldpc_enabled'
     214 |   sta_params->ht_ldpc_enabled = 0;
         |             ^~

# https://github.com/0day-ci/linux/commit/be351ca1dba76b7614d19b590f28f9977666e42f
git remote add linux-review https://github.com/0day-ci/linux
git fetch --no-tags linux-review Bryan-O-Donoghue/wcn36xx-Add-a-set-of-helpers-to-enable-VHT-parameter-passing/20200909-115630
git checkout be351ca1dba76b7614d19b590f28f9977666e42f
vim +/wcn36xx_smd_set_sta_default_ht_ldpc_params +208 drivers/net/wireless/ath/wcn36xx/smd.c

   191	
   192	void wcn36xx_smd_set_sta_default_vht_params(struct wcn36xx *wcn,
   193			struct wcn36xx_hal_config_sta_params_v1 *sta_params)
   194	{
   195		if (wcn->rf_id == RF_IRIS_WCN3680) {
   196			sta_params->vht_capable = 1;
   197			sta_params->vht_tx_mu_beamformee_capable = 1;
   198		} else {
   199			sta_params->vht_capable = 0;
   200			sta_params->vht_tx_mu_beamformee_capable = 0;
   201		}
   202	
   203		sta_params->vht_ldpc_enabled = 0;
 > 204		sta_params->vht_tx_channel_width_set = 0;
   205		sta_params->vht_tx_bf_enabled = 0;
   206	}
   207	
 > 208	void wcn36xx_smd_set_sta_default_ht_ldpc_params(struct wcn36xx *wcn,
   209			struct wcn36xx_hal_config_sta_params_v1 *sta_params)
   210	{
   211		if (wcn->rf_id == RF_IRIS_WCN3680)
   212			sta_params->ht_ldpc_enabled = 1;
   213		else
   214			sta_params->ht_ldpc_enabled = 0;
   215	}
   216	

---
0-DAY CI Kernel Test Service, Intel Corporation
https://lists.01.org/hyperkitty/list/kbuild-all(a)lists.01.org

[-- Attachment #2: config.gz --]
[-- Type: application/gzip, Size: 74730 bytes --]

  reply	other threads:[~2020-09-09  8:49 UTC|newest]

Thread overview: 15+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-09-08 18:24 [PATCH v3 0/7] wcn36xx: Add a set of helpers to enable VHT parameter passing Bryan O'Donoghue
2020-09-08 18:24 ` [PATCH v3 1/7] wcn36xx: Add wcn36xx_set_default_rates_v1 Bryan O'Donoghue
2020-09-08 18:24 ` [PATCH v3 2/7] wcn36xx: Add wcn36xx_smd_set_sta_default_vht_params() Bryan O'Donoghue
2020-09-09  7:23   ` kernel test robot
2020-09-09  7:23     ` kernel test robot
2020-09-09 11:58     ` Bryan O'Donoghue
2020-09-09 11:58       ` Bryan O'Donoghue
2020-09-08 18:24 ` [PATCH v3 3/7] wcn36xx: Add wcn36xx_smd_set_sta_default_ht_ldpc_params() Bryan O'Donoghue
2020-09-09  8:49   ` kernel test robot [this message]
2020-09-08 18:24 ` [PATCH v3 4/7] wcn36xx: Add wcn36xx_smd_set_sta_vht_params() Bryan O'Donoghue
2020-09-09 10:49   ` kernel test robot
2020-09-08 18:24 ` [PATCH v3 5/7] wcn36xx: Add wcn36xx_smd_set_sta_ht_ldpc_params() Bryan O'Donoghue
2020-09-09 12:32   ` kernel test robot
2020-09-08 18:24 ` [PATCH v3 6/7] wcn36xx: Add wcn36xx_smd_set_bss_vht_params() Bryan O'Donoghue
2020-09-08 18:24 ` [PATCH v3 7/7] wcn36xx: Add wrapper function wcn36xx_smd_set_sta_params_v1() Bryan O'Donoghue

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=202009091604.tAKqFtHt%lkp@intel.com \
    --to=lkp@intel.com \
    --cc=kbuild-all@lists.01.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.