All of lore.kernel.org
 help / color / mirror / Atom feed
From: Jakub Kicinski <kuba@kernel.org>
To: davem@davemloft.net
Cc: netdev@vger.kernel.org, eric.dumazet@gmail.com,
	kernel-team@fb.com, Jakub Kicinski <kuba@kernel.org>
Subject: [PATCH net-next 3/3] net: make sure napi_list is safe for RCU traversal
Date: Wed,  9 Sep 2020 10:37:53 -0700	[thread overview]
Message-ID: <20200909173753.229124-4-kuba@kernel.org> (raw)
In-Reply-To: <20200909173753.229124-1-kuba@kernel.org>

netpoll needs to traverse dev->napi_list under RCU, make
sure it uses the right iterator and that removal from this
list is handled safely.

Signed-off-by: Jakub Kicinski <kuba@kernel.org>
---
 net/core/dev.c     | 2 +-
 net/core/netpoll.c | 2 +-
 2 files changed, 2 insertions(+), 2 deletions(-)

diff --git a/net/core/dev.c b/net/core/dev.c
index e0a1be986824..03624192862a 100644
--- a/net/core/dev.c
+++ b/net/core/dev.c
@@ -6656,7 +6656,7 @@ void __netif_napi_del(struct napi_struct *napi)
 		return;
 
 	napi_hash_del(napi);
-	list_del_init(&napi->dev_list);
+	list_del_rcu(&napi->dev_list);
 	napi_free_frags(napi);
 
 	flush_gro_hash(napi);
diff --git a/net/core/netpoll.c b/net/core/netpoll.c
index 2338753e936b..c310c7c1cef7 100644
--- a/net/core/netpoll.c
+++ b/net/core/netpoll.c
@@ -297,7 +297,7 @@ static int netpoll_owner_active(struct net_device *dev)
 {
 	struct napi_struct *napi;
 
-	list_for_each_entry(napi, &dev->napi_list, dev_list) {
+	list_for_each_entry_rcu(napi, &dev->napi_list, dev_list) {
 		if (napi->poll_owner == smp_processor_id())
 			return 1;
 	}
-- 
2.26.2


  parent reply	other threads:[~2020-09-09 17:38 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-09-09 17:37 [PATCH net-next 0/3] netpoll: make sure napi_list is safe for RCU traversal Jakub Kicinski
2020-09-09 17:37 ` [PATCH net-next 1/3] net: remove napi_hash_del() from driver-facing API Jakub Kicinski
2020-11-24 18:00   ` Eric Dumazet
2020-11-24 18:54     ` Jakub Kicinski
2020-11-24 19:11       ` Eric Dumazet
2020-11-24 19:36         ` Jakub Kicinski
2020-09-09 17:37 ` [PATCH net-next 2/3] net: manage napi add/del idempotence explicitly Jakub Kicinski
2020-09-09 17:37 ` Jakub Kicinski [this message]
2020-09-10 20:09 ` [PATCH net-next 0/3] netpoll: make sure napi_list is safe for RCU traversal David Miller

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20200909173753.229124-4-kuba@kernel.org \
    --to=kuba@kernel.org \
    --cc=davem@davemloft.net \
    --cc=eric.dumazet@gmail.com \
    --cc=kernel-team@fb.com \
    --cc=netdev@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.