From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-9.8 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH, MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 5DAB0C43461 for ; Wed, 9 Sep 2020 22:42:21 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 125BD20C09 for ; Wed, 9 Sep 2020 22:42:21 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="HwIgtgQR" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726642AbgIIWmT (ORCPT ); Wed, 9 Sep 2020 18:42:19 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:58002 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726440AbgIIWmR (ORCPT ); Wed, 9 Sep 2020 18:42:17 -0400 Received: from mail-pj1-x1043.google.com (mail-pj1-x1043.google.com [IPv6:2607:f8b0:4864:20::1043]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 231F7C061573 for ; Wed, 9 Sep 2020 15:42:17 -0700 (PDT) Received: by mail-pj1-x1043.google.com with SMTP id s2so2057629pjr.4 for ; Wed, 09 Sep 2020 15:42:17 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to; bh=+3Smoa+f+3uCqZK7RJ/D0oJ3+DMFy9C08WYAgHXWYaI=; b=HwIgtgQRJVYk3UsZVB8+LAlLldw0BKolYTPBL2Gyf0b0YpeakszW1bnCww6LMdxQ/8 4UJFrBM//5btWbmHhxneRFOTwkI8khmwzmmcHbQYf0brTRE0EEL3yVL4Sfriwrs47TSm gSA6IUxE9u+rmUKcgwk5xg3m22l5YGSVeWovRXJYR9ai3O0nUyS66EeaqnIeA13hUkie EA3QrmS1owLGXIGColDstK6lb5+JzsZeIxY+DDdNaS0Yxrvkk0bSuy5XlG32Td1+X4gN Hsunao4vb+d1eKz215rP7/jxHzj3FLxgx7DHqVAK+FTsOuzBiZuxz9LJphsf1+ofjUaP jn3Q== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=+3Smoa+f+3uCqZK7RJ/D0oJ3+DMFy9C08WYAgHXWYaI=; b=uDzH9YkRN2/F3btYm2JAnL7zMNdgsTO8YdGcxHJgpFT7m9gv/ZuSp1r7MfvCl+jWhs hQ7dPwwQD5IgMR8xbezXf8CgVCgun55dOzudQVwzdaBt8qlu7F0SXX/paqy1MUme7nCX +2/NVV/fBg7uyk4A4lPPZgufrGSSPpaKSPc+a2DhdEwbdrjRd85j9EzL1frEB1FVlvgs 3f3YR6+HDrZc6zUkdybyVjjS5cVIGLFI63N/RegD9RROnBg0i9g1T5zefQS18KVVneDn zPPTku1YfAaAcrNlf1QvORMxid7ZJhvEZVUh15U5pr9zZvGSNrcetleNcQaigP15gRDB yJFA== X-Gm-Message-State: AOAM530SGtUT+Szhcvd2lbVpYjxVzm4U9YJ2JXRIPagzvs9SFsAeRLKl 8f/WTXhqwg+6l+kQ5JH6wSUhJPcg+FIjxQ== X-Google-Smtp-Source: ABdhPJz/2Qf6QNZwgwk/961aGz0uD5WP/jMVye/WwOGhRg0CjMOHv8HXh4RhClPh40DjwMrbC6a7yQ== X-Received: by 2002:a17:90b:797:: with SMTP id l23mr2578793pjz.176.1599691336688; Wed, 09 Sep 2020 15:42:16 -0700 (PDT) Received: from xps15 (S0106002369de4dac.cg.shawcable.net. [68.147.8.254]) by smtp.gmail.com with ESMTPSA id j6sm3520746pfi.129.2020.09.09.15.42.15 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 09 Sep 2020 15:42:16 -0700 (PDT) Date: Wed, 9 Sep 2020 16:42:14 -0600 From: Mathieu Poirier To: Guennadi Liakhovetski Cc: kvm@vger.kernel.org, linux-remoteproc@vger.kernel.org, virtualization@lists.linux-foundation.org, sound-open-firmware@alsa-project.org, Pierre-Louis Bossart , Liam Girdwood , "Michael S. Tsirkin" , Jason Wang , Ohad Ben-Cohen , Bjorn Andersson , Vincent Whitchurch Subject: Re: [PATCH v5 1/4] vhost: convert VHOST_VSOCK_SET_RUNNING to a generic ioctl Message-ID: <20200909224214.GB562265@xps15> References: <20200826174636.23873-1-guennadi.liakhovetski@linux.intel.com> <20200826174636.23873-2-guennadi.liakhovetski@linux.intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20200826174636.23873-2-guennadi.liakhovetski@linux.intel.com> Sender: linux-remoteproc-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-remoteproc@vger.kernel.org On Wed, Aug 26, 2020 at 07:46:33PM +0200, Guennadi Liakhovetski wrote: > VHOST_VSOCK_SET_RUNNING is used by the vhost vsock driver to perform > crucial VirtQueue initialisation, like assigning .private fields and > calling vhost_vq_init_access(), and clean up. However, this ioctl is > actually extremely useful for any vhost driver, that doesn't have a > side channel to inform it of a status change, e.g. upon a guest > reboot. This patch makes that ioctl generic, while preserving its > numeric value and also keeping the original alias. > > Signed-off-by: Guennadi Liakhovetski > --- > include/uapi/linux/vhost.h | 4 +++- > 1 file changed, 3 insertions(+), 1 deletion(-) > > diff --git a/include/uapi/linux/vhost.h b/include/uapi/linux/vhost.h > index 75232185324a..11a4948b6216 100644 > --- a/include/uapi/linux/vhost.h > +++ b/include/uapi/linux/vhost.h > @@ -97,6 +97,8 @@ > #define VHOST_SET_BACKEND_FEATURES _IOW(VHOST_VIRTIO, 0x25, __u64) > #define VHOST_GET_BACKEND_FEATURES _IOR(VHOST_VIRTIO, 0x26, __u64) > > +#define VHOST_SET_RUNNING _IOW(VHOST_VIRTIO, 0x61, int) > + I don't see it used in the next patches and as such should be part of another series. > /* VHOST_NET specific defines */ > > /* Attach virtio net ring to a raw socket, or tap device. > @@ -118,7 +120,7 @@ > /* VHOST_VSOCK specific defines */ > > #define VHOST_VSOCK_SET_GUEST_CID _IOW(VHOST_VIRTIO, 0x60, __u64) > -#define VHOST_VSOCK_SET_RUNNING _IOW(VHOST_VIRTIO, 0x61, int) > +#define VHOST_VSOCK_SET_RUNNING VHOST_SET_RUNNING > > /* VHOST_VDPA specific defines */ > > -- > 2.28.0 >