All of lore.kernel.org
 help / color / mirror / Atom feed
From: David Miller <davem@davemloft.net>
To: alex.dewar90@gmail.com
Cc: kuba@kernel.org, rmk+kernel@armlinux.org.uk,
	mcroce@microsoft.com, sven.auhagen@voleatech.de, andrew@lunn.ch,
	netdev@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] net: mvpp2: ptp: Fix unused variables
Date: Thu, 10 Sep 2020 15:16:07 -0700 (PDT)	[thread overview]
Message-ID: <20200910.151607.1755041538732050239.davem@davemloft.net> (raw)
In-Reply-To: <20200910134915.46660-1-alex.dewar90@gmail.com>

From: Alex Dewar <alex.dewar90@gmail.com>
Date: Thu, 10 Sep 2020 14:49:10 +0100

> In the functions mvpp2_isr_handle_xlg() and
> mvpp2_isr_handle_gmac_internal(), the bool variable link is assigned a
> true value in the case that a given bit of val is set. However, if the
> bit is unset, no value is assigned to link and it is then passed to
> mvpp2_isr_handle_link() without being initialised. Fix by assigning to
> link the value of the bit test.
> 
> Build-tested on x86.
> 
> Fixes: 36cfd3a6e52b ("net: mvpp2: restructure "link status" interrupt handling")
> Signed-off-by: Alex Dewar <alex.dewar90@gmail.com>

Applied to net-next.

      reply	other threads:[~2020-09-10 22:16 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-09-10 13:49 [PATCH] net: mvpp2: ptp: Fix unused variables Alex Dewar
2020-09-10 22:16 ` David Miller [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20200910.151607.1755041538732050239.davem@davemloft.net \
    --to=davem@davemloft.net \
    --cc=alex.dewar90@gmail.com \
    --cc=andrew@lunn.ch \
    --cc=kuba@kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mcroce@microsoft.com \
    --cc=netdev@vger.kernel.org \
    --cc=rmk+kernel@armlinux.org.uk \
    --cc=sven.auhagen@voleatech.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.