From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-11.2 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY, SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 5467FC433E2 for ; Thu, 10 Sep 2020 07:15:46 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 21E912076D for ; Thu, 10 Sep 2020 07:15:46 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1730176AbgIJHPl (ORCPT ); Thu, 10 Sep 2020 03:15:41 -0400 Received: from mga04.intel.com ([192.55.52.120]:43531 "EHLO mga04.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1730378AbgIJHPU (ORCPT ); Thu, 10 Sep 2020 03:15:20 -0400 IronPort-SDR: ts3/RM3BbAaSZErg9pI8cI18afivj805sKU6FLrJDP5p+xqJf6pT/qdvex0CmqLVXx8uVYjOI6 AXdSIl4u5Img== X-IronPort-AV: E=McAfee;i="6000,8403,9739"; a="155881189" X-IronPort-AV: E=Sophos;i="5.76,412,1592895600"; d="scan'208";a="155881189" X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from fmsmga008.fm.intel.com ([10.253.24.58]) by fmsmga104.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 10 Sep 2020 00:15:19 -0700 IronPort-SDR: e6Qaiy2n8PctJP2/CF688WXqm7EvXe1yUUpcy7kkqSeXCMRKgSqQXPf9dioKsgfziB4kkep8yk fbFAIxWN4HPw== X-IronPort-AV: E=Sophos;i="5.76,412,1592895600"; d="scan'208";a="286478970" Received: from gliakhov-mobl2.ger.corp.intel.com (HELO ubuntu) ([10.252.39.14]) by fmsmga008-auth.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 10 Sep 2020 00:15:16 -0700 Date: Thu, 10 Sep 2020 09:15:13 +0200 From: Guennadi Liakhovetski To: Mathieu Poirier Cc: kvm@vger.kernel.org, linux-remoteproc@vger.kernel.org, virtualization@lists.linux-foundation.org, sound-open-firmware@alsa-project.org, Pierre-Louis Bossart , Liam Girdwood , "Michael S. Tsirkin" , Jason Wang , Ohad Ben-Cohen , Bjorn Andersson , Vincent Whitchurch Subject: Re: [PATCH v5 1/4] vhost: convert VHOST_VSOCK_SET_RUNNING to a generic ioctl Message-ID: <20200910062144.GA16802@ubuntu> References: <20200826174636.23873-1-guennadi.liakhovetski@linux.intel.com> <20200826174636.23873-2-guennadi.liakhovetski@linux.intel.com> <20200909224214.GB562265@xps15> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20200909224214.GB562265@xps15> User-Agent: Mutt/1.10.1 (2018-07-13) Sender: linux-remoteproc-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-remoteproc@vger.kernel.org Hi Mathieu, On Wed, Sep 09, 2020 at 04:42:14PM -0600, Mathieu Poirier wrote: > On Wed, Aug 26, 2020 at 07:46:33PM +0200, Guennadi Liakhovetski wrote: > > VHOST_VSOCK_SET_RUNNING is used by the vhost vsock driver to perform > > crucial VirtQueue initialisation, like assigning .private fields and > > calling vhost_vq_init_access(), and clean up. However, this ioctl is > > actually extremely useful for any vhost driver, that doesn't have a > > side channel to inform it of a status change, e.g. upon a guest > > reboot. This patch makes that ioctl generic, while preserving its > > numeric value and also keeping the original alias. > > > > Signed-off-by: Guennadi Liakhovetski > > --- > > include/uapi/linux/vhost.h | 4 +++- > > 1 file changed, 3 insertions(+), 1 deletion(-) > > > > diff --git a/include/uapi/linux/vhost.h b/include/uapi/linux/vhost.h > > index 75232185324a..11a4948b6216 100644 > > --- a/include/uapi/linux/vhost.h > > +++ b/include/uapi/linux/vhost.h > > @@ -97,6 +97,8 @@ > > #define VHOST_SET_BACKEND_FEATURES _IOW(VHOST_VIRTIO, 0x25, __u64) > > #define VHOST_GET_BACKEND_FEATURES _IOR(VHOST_VIRTIO, 0x26, __u64) > > > > +#define VHOST_SET_RUNNING _IOW(VHOST_VIRTIO, 0x61, int) > > + > > I don't see it used in the next patches and as such should be part of another > series. It isn't used in the next patches, it is used in this patch - see below. Thanks Guennadi > > /* VHOST_NET specific defines */ > > > > /* Attach virtio net ring to a raw socket, or tap device. > > @@ -118,7 +120,7 @@ > > /* VHOST_VSOCK specific defines */ > > > > #define VHOST_VSOCK_SET_GUEST_CID _IOW(VHOST_VIRTIO, 0x60, __u64) > > -#define VHOST_VSOCK_SET_RUNNING _IOW(VHOST_VIRTIO, 0x61, int) > > +#define VHOST_VSOCK_SET_RUNNING VHOST_SET_RUNNING > > > > /* VHOST_VDPA specific defines */ > > > > -- > > 2.28.0 > > From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-11.2 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY, SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 2A434C43461 for ; Thu, 10 Sep 2020 07:15:25 +0000 (UTC) Received: from hemlock.osuosl.org (smtp2.osuosl.org [140.211.166.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 958B62075B for ; Thu, 10 Sep 2020 07:15:23 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 958B62075B Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=linux.intel.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=virtualization-bounces@lists.linux-foundation.org Received: from localhost (localhost [127.0.0.1]) by hemlock.osuosl.org (Postfix) with ESMTP id 151E08765C; Thu, 10 Sep 2020 07:15:23 +0000 (UTC) X-Virus-Scanned: amavisd-new at osuosl.org Received: from hemlock.osuosl.org ([127.0.0.1]) by localhost (.osuosl.org [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id nazQ0b1ymlrF; Thu, 10 Sep 2020 07:15:22 +0000 (UTC) Received: from lists.linuxfoundation.org (lf-lists.osuosl.org [140.211.9.56]) by hemlock.osuosl.org (Postfix) with ESMTP id 5627887661; Thu, 10 Sep 2020 07:15:22 +0000 (UTC) Received: from lf-lists.osuosl.org (localhost [127.0.0.1]) by lists.linuxfoundation.org (Postfix) with ESMTP id 3C815C0859; Thu, 10 Sep 2020 07:15:22 +0000 (UTC) Received: from hemlock.osuosl.org (smtp2.osuosl.org [140.211.166.133]) by lists.linuxfoundation.org (Postfix) with ESMTP id 4D65FC0051 for ; Thu, 10 Sep 2020 07:15:21 +0000 (UTC) Received: from localhost (localhost [127.0.0.1]) by hemlock.osuosl.org (Postfix) with ESMTP id 3817487661 for ; Thu, 10 Sep 2020 07:15:21 +0000 (UTC) X-Virus-Scanned: amavisd-new at osuosl.org Received: from hemlock.osuosl.org ([127.0.0.1]) by localhost (.osuosl.org [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id wAUCcsv-RVKy for ; Thu, 10 Sep 2020 07:15:20 +0000 (UTC) X-Greylist: domain auto-whitelisted by SQLgrey-1.7.6 Received: from mga11.intel.com (mga11.intel.com [192.55.52.93]) by hemlock.osuosl.org (Postfix) with ESMTPS id ECEA28765C for ; Thu, 10 Sep 2020 07:15:19 +0000 (UTC) IronPort-SDR: wHBzkEHLEtesdTStYz7kZxiuksV1zXlFaFqPmQ0GQZz0mvrrb0ohW9W7WIiLnmuo5CQjRmsZAA qdo90IGzx1wA== X-IronPort-AV: E=McAfee;i="6000,8403,9739"; a="155942994" X-IronPort-AV: E=Sophos;i="5.76,412,1592895600"; d="scan'208";a="155942994" X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from fmsmga008.fm.intel.com ([10.253.24.58]) by fmsmga102.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 10 Sep 2020 00:15:19 -0700 IronPort-SDR: e6Qaiy2n8PctJP2/CF688WXqm7EvXe1yUUpcy7kkqSeXCMRKgSqQXPf9dioKsgfziB4kkep8yk fbFAIxWN4HPw== X-IronPort-AV: E=Sophos;i="5.76,412,1592895600"; d="scan'208";a="286478970" Received: from gliakhov-mobl2.ger.corp.intel.com (HELO ubuntu) ([10.252.39.14]) by fmsmga008-auth.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 10 Sep 2020 00:15:16 -0700 Date: Thu, 10 Sep 2020 09:15:13 +0200 From: Guennadi Liakhovetski To: Mathieu Poirier Subject: Re: [PATCH v5 1/4] vhost: convert VHOST_VSOCK_SET_RUNNING to a generic ioctl Message-ID: <20200910062144.GA16802@ubuntu> References: <20200826174636.23873-1-guennadi.liakhovetski@linux.intel.com> <20200826174636.23873-2-guennadi.liakhovetski@linux.intel.com> <20200909224214.GB562265@xps15> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20200909224214.GB562265@xps15> User-Agent: Mutt/1.10.1 (2018-07-13) Cc: Ohad Ben-Cohen , kvm@vger.kernel.org, "Michael S. Tsirkin" , Vincent Whitchurch , linux-remoteproc@vger.kernel.org, Pierre-Louis Bossart , virtualization@lists.linux-foundation.org, Liam Girdwood , Bjorn Andersson , sound-open-firmware@alsa-project.org X-BeenThere: virtualization@lists.linux-foundation.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: Linux virtualization List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: virtualization-bounces@lists.linux-foundation.org Sender: "Virtualization" Hi Mathieu, On Wed, Sep 09, 2020 at 04:42:14PM -0600, Mathieu Poirier wrote: > On Wed, Aug 26, 2020 at 07:46:33PM +0200, Guennadi Liakhovetski wrote: > > VHOST_VSOCK_SET_RUNNING is used by the vhost vsock driver to perform > > crucial VirtQueue initialisation, like assigning .private fields and > > calling vhost_vq_init_access(), and clean up. However, this ioctl is > > actually extremely useful for any vhost driver, that doesn't have a > > side channel to inform it of a status change, e.g. upon a guest > > reboot. This patch makes that ioctl generic, while preserving its > > numeric value and also keeping the original alias. > > > > Signed-off-by: Guennadi Liakhovetski > > --- > > include/uapi/linux/vhost.h | 4 +++- > > 1 file changed, 3 insertions(+), 1 deletion(-) > > > > diff --git a/include/uapi/linux/vhost.h b/include/uapi/linux/vhost.h > > index 75232185324a..11a4948b6216 100644 > > --- a/include/uapi/linux/vhost.h > > +++ b/include/uapi/linux/vhost.h > > @@ -97,6 +97,8 @@ > > #define VHOST_SET_BACKEND_FEATURES _IOW(VHOST_VIRTIO, 0x25, __u64) > > #define VHOST_GET_BACKEND_FEATURES _IOR(VHOST_VIRTIO, 0x26, __u64) > > > > +#define VHOST_SET_RUNNING _IOW(VHOST_VIRTIO, 0x61, int) > > + > > I don't see it used in the next patches and as such should be part of another > series. It isn't used in the next patches, it is used in this patch - see below. Thanks Guennadi > > /* VHOST_NET specific defines */ > > > > /* Attach virtio net ring to a raw socket, or tap device. > > @@ -118,7 +120,7 @@ > > /* VHOST_VSOCK specific defines */ > > > > #define VHOST_VSOCK_SET_GUEST_CID _IOW(VHOST_VIRTIO, 0x60, __u64) > > -#define VHOST_VSOCK_SET_RUNNING _IOW(VHOST_VIRTIO, 0x61, int) > > +#define VHOST_VSOCK_SET_RUNNING VHOST_SET_RUNNING > > > > /* VHOST_VDPA specific defines */ > > > > -- > > 2.28.0 > > _______________________________________________ Virtualization mailing list Virtualization@lists.linux-foundation.org https://lists.linuxfoundation.org/mailman/listinfo/virtualization