* [PATCH] lpfc: drop nodelist reference on error in lpfc_gen_req()
@ 2020-09-10 8:40 Hannes Reinecke
2020-10-03 1:39 ` Martin K. Petersen
2020-10-07 3:47 ` Martin K. Petersen
0 siblings, 2 replies; 3+ messages in thread
From: Hannes Reinecke @ 2020-09-10 8:40 UTC (permalink / raw)
To: James Smart
Cc: Martin K. Petersen, James Bottomley, Christoph Hellwig,
linux-scsi, Hannes Reinecke
If we fail to issue the iocb in lpfc_gen_req() we need to drop
the nodelist reference.
Signed-off-by: Hannes Reinecke <hare@suse.de>
---
drivers/scsi/lpfc/lpfc_ct.c | 2 ++
1 file changed, 2 insertions(+)
diff --git a/drivers/scsi/lpfc/lpfc_ct.c b/drivers/scsi/lpfc/lpfc_ct.c
index ef2015fad2d5..c201686d3815 100644
--- a/drivers/scsi/lpfc/lpfc_ct.c
+++ b/drivers/scsi/lpfc/lpfc_ct.c
@@ -387,6 +387,8 @@ lpfc_gen_req(struct lpfc_vport *vport, struct lpfc_dmabuf *bmp,
rc = lpfc_sli_issue_iocb(phba, LPFC_ELS_RING, geniocb, 0);
if (rc == IOCB_ERROR) {
+ geniocb->context_un.ndlp = NULL;
+ lpfc_nlp_put(ndlp);
lpfc_sli_release_iocbq(phba, geniocb);
return 1;
}
--
2.16.4
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH] lpfc: drop nodelist reference on error in lpfc_gen_req()
2020-09-10 8:40 [PATCH] lpfc: drop nodelist reference on error in lpfc_gen_req() Hannes Reinecke
@ 2020-10-03 1:39 ` Martin K. Petersen
2020-10-07 3:47 ` Martin K. Petersen
1 sibling, 0 replies; 3+ messages in thread
From: Martin K. Petersen @ 2020-10-03 1:39 UTC (permalink / raw)
To: Hannes Reinecke
Cc: James Smart, Martin K. Petersen, James Bottomley,
Christoph Hellwig, linux-scsi
Hannes,
> If we fail to issue the iocb in lpfc_gen_req() we need to drop the
> nodelist reference.
Applied to 5.10/scsi-staging, thanks!
--
Martin K. Petersen Oracle Linux Engineering
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] lpfc: drop nodelist reference on error in lpfc_gen_req()
2020-09-10 8:40 [PATCH] lpfc: drop nodelist reference on error in lpfc_gen_req() Hannes Reinecke
2020-10-03 1:39 ` Martin K. Petersen
@ 2020-10-07 3:47 ` Martin K. Petersen
1 sibling, 0 replies; 3+ messages in thread
From: Martin K. Petersen @ 2020-10-07 3:47 UTC (permalink / raw)
To: Hannes Reinecke, James Smart
Cc: Martin K . Petersen, Christoph Hellwig, James Bottomley, linux-scsi
On Thu, 10 Sep 2020 10:40:59 +0200, Hannes Reinecke wrote:
> If we fail to issue the iocb in lpfc_gen_req() we need to drop
> the nodelist reference.
Applied to 5.10/scsi-queue, thanks!
[1/1] scsi: lpfc: Drop nodelist reference on error in lpfc_gen_req()
https://git.kernel.org/mkp/scsi/c/962d359c4d3b
--
Martin K. Petersen Oracle Linux Engineering
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2020-10-07 3:48 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2020-09-10 8:40 [PATCH] lpfc: drop nodelist reference on error in lpfc_gen_req() Hannes Reinecke
2020-10-03 1:39 ` Martin K. Petersen
2020-10-07 3:47 ` Martin K. Petersen
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.