CC: kbuild-all(a)lists.01.org CC: linux-kernel(a)vger.kernel.org TO: Denis Efremov CC: Julia Lawall CC: "Rafael J. Wysocki" CC: Len Brown CC: linux-acpi(a)vger.kernel.org CC: linux-kernel(a)vger.kernel.org From: kernel test robot drivers/acpi/dock.c:563:8-16: WARNING: use scnprintf or sprintf drivers/acpi/dock.c:544:8-16: WARNING: use scnprintf or sprintf drivers/acpi/dock.c:495:8-16: WARNING: use scnprintf or sprintf drivers/acpi/dock.c:506:8-16: WARNING: use scnprintf or sprintf From Documentation/filesystems/sysfs.txt: show() must not use snprintf() when formatting the value to be returned to user space. If you can guarantee that an overflow will never happen you can use sprintf() otherwise you must use scnprintf(). Generated by: scripts/coccinelle/api/device_attr_show.cocci Fixes: abfc19ff202d ("coccinelle: api: add device_attr_show script") CC: Denis Efremov Signed-off-by: kernel test robot --- tree: https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git master head: 7fe10096c1508c7f033d34d0741809f8eecc1ed4 commit: abfc19ff202d287742483e15fd478ddd6ada2187 coccinelle: api: add device_attr_show script :::::: branch date: 6 hours ago :::::: commit date: 5 weeks ago Please take the patch only if it's a positive warning. Thanks! dock.c | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-) --- a/drivers/acpi/dock.c +++ b/drivers/acpi/dock.c @@ -492,7 +492,7 @@ static ssize_t show_docked(struct device struct acpi_device *adev = NULL; acpi_bus_get_device(dock_station->handle, &adev); - return snprintf(buf, PAGE_SIZE, "%u\n", acpi_device_enumerated(adev)); + return scnprintf(buf, PAGE_SIZE, "%u\n", acpi_device_enumerated(adev)); } static DEVICE_ATTR(docked, S_IRUGO, show_docked, NULL); @@ -503,7 +503,7 @@ static ssize_t show_flags(struct device struct device_attribute *attr, char *buf) { struct dock_station *dock_station = dev->platform_data; - return snprintf(buf, PAGE_SIZE, "%d\n", dock_station->flags); + return scnprintf(buf, PAGE_SIZE, "%d\n", dock_station->flags); } static DEVICE_ATTR(flags, S_IRUGO, show_flags, NULL); @@ -541,7 +541,7 @@ static ssize_t show_dock_uid(struct devi if (ACPI_FAILURE(status)) return 0; - return snprintf(buf, PAGE_SIZE, "%llx\n", lbuf); + return scnprintf(buf, PAGE_SIZE, "%llx\n", lbuf); } static DEVICE_ATTR(uid, S_IRUGO, show_dock_uid, NULL); @@ -560,7 +560,7 @@ static ssize_t show_dock_type(struct dev else type = "unknown"; - return snprintf(buf, PAGE_SIZE, "%s\n", type); + return scnprintf(buf, PAGE_SIZE, "%s\n", type); } static DEVICE_ATTR(type, S_IRUGO, show_dock_type, NULL);