From: David Sterba <dsterba@suse.cz>
To: Nikolay Borisov <nborisov@suse.com>
Cc: linux-btrfs@vger.kernel.org
Subject: Re: [PATCH 0/5] Improve setup_items_for_insert
Date: Thu, 10 Sep 2020 18:16:39 +0200 [thread overview]
Message-ID: <20200910161639.GM18399@twin.jikos.cz> (raw)
In-Reply-To: <20200901144001.4265-1-nborisov@suse.com>
On Tue, Sep 01, 2020 at 05:39:56PM +0300, Nikolay Borisov wrote:
> here is a series to improve setup_items_for_insert. First patch is a simple
> re-arranegement of statements to eliminate a duplication of calculation.
> Patches 2 and 3 improve leaky interface of setup_items_for_insert as they
> convey information about the function's implementation. Patch 4 adds a proper
> kernel doc. Finally, patch 5 improves the error message in an exceptional
> condition. As an added bonus after applying the whole series bloat-o-meter
> output looks like:
>
> add/remove: 0/0 grow/shrink: 1/7 up/down: 33/-99 (-66)
> Function old new delta
> setup_items_for_insert 1200 1233 +33
> insert_extent 448 445 -3
> btrfs_duplicate_item 260 254 -6
> test_btrfs_split_item 1784 1776 -8
> insert_inode_item_key 156 148 -8
> __btrfs_drop_extents 3637 3621 -16
> btrfs_insert_delayed_items 1153 1125 -28
> btrfs_insert_empty_items 177 147 -30
> Total: Before=1113157, After=1113091, chg -0.01%
>
> This has survived -g quick of xfstests
>
> Nikolay Borisov (5):
> btrfs: Re-arrange statements in setup_items_for_insert
> btrfs: Eliminate total_size parameter from setup_items_for_insert
> btrfs: Sink total_data parameter in setup_items_for_insert
> btrfs: Add kerneldoc for setup_items_for_insert
> btrfs: improve error message in setup_items_for_insert
Thanks, all seem straightforward, I'll add it to for-next and move to
misc-next once the tests finish.
prev parent reply other threads:[~2020-09-10 17:20 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-09-01 14:39 [PATCH 0/5] Improve setup_items_for_insert Nikolay Borisov
2020-09-01 14:39 ` [PATCH 1/5] btrfs: Re-arrange statements in setup_items_for_insert Nikolay Borisov
2020-09-01 19:13 ` Josef Bacik
2020-09-01 14:39 ` [PATCH 2/5] btrfs: Eliminate total_size parameter from setup_items_for_insert Nikolay Borisov
2020-09-01 19:18 ` Josef Bacik
2020-09-01 14:39 ` [PATCH 3/5] btrfs: Sink total_data parameter in setup_items_for_insert Nikolay Borisov
2020-09-01 19:21 ` Josef Bacik
2020-09-01 14:40 ` [PATCH 4/5] btrfs: Add kerneldoc for setup_items_for_insert Nikolay Borisov
2020-09-01 19:22 ` Josef Bacik
2020-09-01 14:40 ` [PATCH 5/5] btrfs: improve error message in setup_items_for_insert Nikolay Borisov
2020-09-01 19:23 ` Josef Bacik
2020-09-10 16:14 ` David Sterba
2020-09-11 14:50 ` David Sterba
2020-09-02 10:39 ` [PATCH 0/5] Improve setup_items_for_insert Johannes Thumshirn
2020-09-10 16:16 ` David Sterba [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200910161639.GM18399@twin.jikos.cz \
--to=dsterba@suse.cz \
--cc=linux-btrfs@vger.kernel.org \
--cc=nborisov@suse.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.