From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-3.8 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 73AD3C43461 for ; Thu, 10 Sep 2020 18:11:46 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 237542078B for ; Thu, 10 Sep 2020 18:11:46 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726728AbgIJSLn (ORCPT ); Thu, 10 Sep 2020 14:11:43 -0400 Received: from vps0.lunn.ch ([185.16.172.187]:55804 "EHLO vps0.lunn.ch" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726287AbgIJSJm (ORCPT ); Thu, 10 Sep 2020 14:09:42 -0400 Received: from andrew by vps0.lunn.ch with local (Exim 4.94) (envelope-from ) id 1kGR0G-00E6lI-Q6; Thu, 10 Sep 2020 20:09:00 +0200 Date: Thu, 10 Sep 2020 20:09:00 +0200 From: Andrew Lunn To: Dan Murphy Cc: Jakub Kicinski , davem@davemloft.net, f.fainelli@gmail.com, hkallweit1@gmail.com, netdev@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH net-next v3 1/3] net: dp83869: Add ability to advertise Fiber connection Message-ID: <20200910180900.GE3354160@lunn.ch> References: <20200903114259.14013-1-dmurphy@ti.com> <20200903114259.14013-2-dmurphy@ti.com> <20200905111755.4bd874b2@kicinski-fedora-pc1c0hjn.dhcp.thefacebook.com> <20200907142911.GT3112546@lunn.ch> MIME-Version: 1.0 Content-Type: text/plain; charset=iso-8859-1 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org > The note in the ethtool.h says > >     /* Last allowed bit for __ETHTOOL_LINK_MODE_LEGACY_MASK is bit >      * 31. Please do NOT define any SUPPORTED_* or ADVERTISED_* >      * macro for bits > 31. The only way to use indices > 31 is to >      * use the new ETHTOOL_GLINKSETTINGS/ETHTOOL_SLINKSETTINGS API. >      */ > > Which was added by Heiner > > I guess I would prefer to add this in a separate patchset once I figure out > how the ETHTOOL_GLINKSETTINGS/ETHTOOL_SLINKSETTINGS API works The phydev supported value is no longer a u32, it is now a bitmap. So you can do something like linkmode_set_bit(ETHTOOL_LINK_MODE_100BaseFX_Full_BIT, &supported); Andrew