* [PATCH net-next] net/socket.c: Remove an unused header file <linux/if_frad.h>
@ 2020-09-11 6:07 Xie He
2020-09-11 14:57 ` Jakub Kicinski
2020-09-11 21:41 ` David Miller
0 siblings, 2 replies; 4+ messages in thread
From: Xie He @ 2020-09-11 6:07 UTC (permalink / raw)
To: David S. Miller, Jakub Kicinski, netdev, linux-kernel, Lee Jones,
Gustavo A. R. Silva, Krzysztof Kozlowski
Cc: Xie He
This header file is not actually used in this file. Let's remove it.
Information about this header file:
This header file comes from the "Frame Relay" module at
drivers/net/wan/dlci.c
The "Frame Relay" module is used by only one hardware driver, at:
drivers/net/wan/sdla.c
Note that the "Frame Relay" module is different from and unrelated to the
"HDLC Frame Relay" module at:
drivers/net/wan/hdlc_fr.c
I think maybe we can deprecate the "Frame Relay" module because we already
have the (newer) "HDLC Frame Relay" module.
Signed-off-by: Xie He <xie.he.0141@gmail.com>
---
net/socket.c | 1 -
1 file changed, 1 deletion(-)
diff --git a/net/socket.c b/net/socket.c
index 82262e1922f9..161dd2775e13 100644
--- a/net/socket.c
+++ b/net/socket.c
@@ -64,7 +64,6 @@
#include <linux/seq_file.h>
#include <linux/mutex.h>
#include <linux/if_bridge.h>
-#include <linux/if_frad.h>
#include <linux/if_vlan.h>
#include <linux/ptp_classify.h>
#include <linux/init.h>
--
2.25.1
^ permalink raw reply related [flat|nested] 4+ messages in thread
* Re: [PATCH net-next] net/socket.c: Remove an unused header file <linux/if_frad.h>
2020-09-11 6:07 [PATCH net-next] net/socket.c: Remove an unused header file <linux/if_frad.h> Xie He
@ 2020-09-11 14:57 ` Jakub Kicinski
2020-09-11 21:41 ` David Miller
1 sibling, 0 replies; 4+ messages in thread
From: Jakub Kicinski @ 2020-09-11 14:57 UTC (permalink / raw)
To: Xie He
Cc: David S. Miller, netdev, linux-kernel, Lee Jones,
Gustavo A. R. Silva, Krzysztof Kozlowski
On Thu, 10 Sep 2020 23:07:20 -0700 Xie He wrote:
> This header file is not actually used in this file. Let's remove it.
>
> Information about this header file:
>
> This header file comes from the "Frame Relay" module at
> drivers/net/wan/dlci.c
>
> The "Frame Relay" module is used by only one hardware driver, at:
> drivers/net/wan/sdla.c
>
> Note that the "Frame Relay" module is different from and unrelated to the
> "HDLC Frame Relay" module at:
> drivers/net/wan/hdlc_fr.c
>
> I think maybe we can deprecate the "Frame Relay" module because we already
> have the (newer) "HDLC Frame Relay" module.
>
> Signed-off-by: Xie He <xie.he.0141@gmail.com>
net/socket.c:1032:6: warning: no previous prototype for ‘dlci_ioctl_set’ [-Wmissing-prototypes]
1032 | void dlci_ioctl_set(int (*hook) (unsigned int, void __user *))
| ^~~~~~~~~~~~~~
net/socket.c:1032:6: warning: symbol 'dlci_ioctl_set' was not declared. Should it be static?
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH net-next] net/socket.c: Remove an unused header file <linux/if_frad.h>
2020-09-11 6:07 [PATCH net-next] net/socket.c: Remove an unused header file <linux/if_frad.h> Xie He
2020-09-11 14:57 ` Jakub Kicinski
@ 2020-09-11 21:41 ` David Miller
2020-09-11 23:30 ` Xie He
1 sibling, 1 reply; 4+ messages in thread
From: David Miller @ 2020-09-11 21:41 UTC (permalink / raw)
To: xie.he.0141; +Cc: kuba, netdev, linux-kernel, lee.jones, gustavoars, krzk
From: Xie He <xie.he.0141@gmail.com>
Date: Thu, 10 Sep 2020 23:07:20 -0700
> This header file is not actually used in this file. Let's remove it.
How did you test this assertion? As Jakub showed, the
dlci_ioctl_set() function needs to be declared because socket.c
references it.
All of your visual scanning of the code is wasted if you don't
do something simple like an "allmodconfig" or "allyesconfig"
build to test whether your change is correct or not.
Don't leave that step for us, that's your responsibility.
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH net-next] net/socket.c: Remove an unused header file <linux/if_frad.h>
2020-09-11 21:41 ` David Miller
@ 2020-09-11 23:30 ` Xie He
0 siblings, 0 replies; 4+ messages in thread
From: Xie He @ 2020-09-11 23:30 UTC (permalink / raw)
To: David Miller
Cc: Jakub Kicinski, Linux Kernel Network Developers, LKML, Lee Jones,
Gustavo A. R. Silva, Krzysztof Kozlowski
On Fri, Sep 11, 2020 at 2:41 PM David Miller <davem@davemloft.net> wrote:
>
> From: Xie He <xie.he.0141@gmail.com>
> Date: Thu, 10 Sep 2020 23:07:20 -0700
>
> > This header file is not actually used in this file. Let's remove it.
>
> How did you test this assertion? As Jakub showed, the
> dlci_ioctl_set() function needs to be declared because socket.c
> references it.
>
> All of your visual scanning of the code is wasted if you don't
> do something simple like an "allmodconfig" or "allyesconfig"
> build to test whether your change is correct or not.
>
> Don't leave that step for us, that's your responsibility.
>
OK. I'm sorry for this.
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2020-09-11 23:30 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2020-09-11 6:07 [PATCH net-next] net/socket.c: Remove an unused header file <linux/if_frad.h> Xie He
2020-09-11 14:57 ` Jakub Kicinski
2020-09-11 21:41 ` David Miller
2020-09-11 23:30 ` Xie He
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.