From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.0 required=3.0 tests=BAYES_00,DKIM_INVALID, DKIM_SIGNED,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE, SPF_PASS,URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id CB98EC43461 for ; Fri, 11 Sep 2020 08:33:03 +0000 (UTC) Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 2198D206F4 for ; Fri, 11 Sep 2020 08:33:02 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=fail reason="signature verification failed" (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b="jRJQA4qh" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 2198D206F4 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=redhat.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Received: from localhost ([::1]:44354 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1kGeUQ-0001SL-1X for qemu-devel@archiver.kernel.org; Fri, 11 Sep 2020 04:33:02 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:60596) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1kGeTr-0000xf-Ud for qemu-devel@nongnu.org; Fri, 11 Sep 2020 04:32:27 -0400 Received: from us-smtp-2.mimecast.com ([207.211.31.81]:49152 helo=us-smtp-delivery-1.mimecast.com) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA1:256) (Exim 4.90_1) (envelope-from ) id 1kGeTq-0001Gf-41 for qemu-devel@nongnu.org; Fri, 11 Sep 2020 04:32:27 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1599813145; h=from:from:reply-to:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=HUkjyhSH9Qnyzcwq/QT8k8RDpUudKeT0g+T6+xfMQag=; b=jRJQA4qhVeSRFDPUy3StzF5xMbdwkRamV1sINOn78wwKxW+HIss6gj/nag1Kwm7MVDxdhu RnJOPE6miL1whdf2KKdM7u3Yxe6W4OQLbpIhNb8x3sVaapFfW+rp8rIMTnA8Is3mtWnwRL XuhTsJemsOJEA0zg/V6cUujUf+hg6Lw= Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-463-GE6hNmsoMxunt2sfhWeQFQ-1; Fri, 11 Sep 2020 04:32:20 -0400 X-MC-Unique: GE6hNmsoMxunt2sfhWeQFQ-1 Received: from smtp.corp.redhat.com (int-mx03.intmail.prod.int.phx2.redhat.com [10.5.11.13]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id 8874E1882FC5; Fri, 11 Sep 2020 08:32:19 +0000 (UTC) Received: from redhat.com (ovpn-113-229.ams2.redhat.com [10.36.113.229]) by smtp.corp.redhat.com (Postfix) with ESMTPS id A25757838A; Fri, 11 Sep 2020 08:32:13 +0000 (UTC) Date: Fri, 11 Sep 2020 09:32:10 +0100 From: Daniel =?utf-8?B?UC4gQmVycmFuZ8Op?= To: =?utf-8?Q?Marc-Andr=C3=A9?= Lureau Subject: Re: [PATCH 00/18] chardev: QOM cleanups Message-ID: <20200911083210.GB1203593@redhat.com> References: <20200910194903.4104696-1-ehabkost@redhat.com> <20200911081018.GA1203593@redhat.com> MIME-Version: 1.0 In-Reply-To: User-Agent: Mutt/1.14.6 (2020-07-11) X-Scanned-By: MIMEDefang 2.79 on 10.5.11.13 Authentication-Results: relay.mimecast.com; auth=pass smtp.auth=CUSA124A263 smtp.mailfrom=berrange@redhat.com X-Mimecast-Spam-Score: 0.001 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit Content-Disposition: inline Received-SPF: pass client-ip=207.211.31.81; envelope-from=berrange@redhat.com; helo=us-smtp-delivery-1.mimecast.com X-detected-operating-system: by eggs.gnu.org: First seen = 2020/09/11 00:33:53 X-ACL-Warn: Detected OS = Linux 2.2.x-3.x [generic] [fuzzy] X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.001, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, RCVD_IN_MSPIKE_H2=-0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: Daniel =?utf-8?B?UC4gQmVycmFuZ8Op?= Cc: Eduardo Habkost , QEMU , Gerd Hoffmann , Paolo Bonzini , Samuel Thibault , Philippe =?utf-8?Q?Mathieu-Daud=C3=A9?= Errors-To: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Sender: "Qemu-devel" On Fri, Sep 11, 2020 at 12:19:08PM +0400, Marc-André Lureau wrote: > Hi > > On Fri, Sep 11, 2020 at 12:10 PM Daniel P. Berrangé > wrote: > > > On Fri, Sep 11, 2020 at 12:07:27PM +0400, Marc-André Lureau wrote: > > > Hi > > > > > > On Thu, Sep 10, 2020 at 11:50 PM Eduardo Habkost > > > wrote: > > > > > > > Some chardev QOM cleanup patches had to be dropped from my queue > > > > due to build erros introduced by code movements across ifdef > > > > boundaries at char-parallel.c. This series redo the changes from > > > > those patches, but the macro renames are now a little different: > > > > > > > > In this version I have decided to rename the type checking macros > > > > from *_CHARDEV to CHARDEV_* instead of renaming tye > > > > TYPE_CHARDEV_* constants to TYPE_*_CHARDEV, to make the > > > > identifiers actually match the QOM type name strings > > > > ("chardev-*"). > > > > > > > > > > Sounds reasonable to me, but it loses the matching with the > > > structure/object type name though. > > > > > > - MuxChardev *d = MUX_CHARDEV(s); > > > + MuxChardev *d = CHARDEV_MUX(s); > > > > > > I have a preference for the first. Unless we rename all the chardev types > > > too... > > > > I tend to think the structs should be renamed too - I've always considerd > > them to be backwards. > > > > > Imho, the QOM type name is mostly an internal detail, the C type name is > > > dominant in the code. > > > > Err it is the reverse. The QOM type name is exposed public API via QOM > > commands, while the C struct names are a internal private detail. > > > > Yes, but without the chardev- prefix (unless you try object-add which I > don't think will work with chardev) Sure, that's just the way it had to be wired into the -chardev arg syntax, but from the POV of exposed QOM type information the canonical type name has the full chardev- prefix. Regards, Daniel -- |: https://berrange.com -o- https://www.flickr.com/photos/dberrange :| |: https://libvirt.org -o- https://fstop138.berrange.com :| |: https://entangle-photo.org -o- https://www.instagram.com/dberrange :|