From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.2 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS, USER_AGENT_SANE_2 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id C217DC433E2 for ; Fri, 11 Sep 2020 21:42:10 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 8BDAA221E5 for ; Fri, 11 Sep 2020 21:42:10 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1725887AbgIKVmJ convert rfc822-to-8bit (ORCPT ); Fri, 11 Sep 2020 17:42:09 -0400 Received: from mga11.intel.com ([192.55.52.93]:22593 "EHLO mga11.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1725816AbgIKVmI (ORCPT ); Fri, 11 Sep 2020 17:42:08 -0400 IronPort-SDR: BKb1Lj5ykTBfqod5hlQIe2ZZ8bYTb9ImBBV80nFcjvPA6VdOOhji84pr4Dk4g6NG+TsZEIWYpQ ZtZhH+RNoeew== X-IronPort-AV: E=McAfee;i="6000,8403,9741"; a="156306752" X-IronPort-AV: E=Sophos;i="5.76,417,1592895600"; d="scan'208";a="156306752" X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from orsmga004.jf.intel.com ([10.7.209.38]) by fmsmga102.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 11 Sep 2020 14:42:08 -0700 IronPort-SDR: OPpjnZl/JVIgjJnhqJFeNR9d9vTtL1AKKqS5LvUH18SRMYMEGQPcV+bbjjb6ZINzDN/iZMv1cb szpNIvYExbWA== X-IronPort-AV: E=Sophos;i="5.76,417,1592895600"; d="scan'208";a="450120794" Received: from jbrandeb-mobl3.amr.corp.intel.com (HELO localhost) ([10.209.99.126]) by orsmga004-auth.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 11 Sep 2020 14:42:07 -0700 Date: Fri, 11 Sep 2020 14:42:07 -0700 From: Jesse Brandeburg To: Edward Cree Cc: , Subject: Re: [RFC PATCH net-next v1 11/11] drivers/net/ethernet: clean up mis-targeted comments Message-ID: <20200911144207.00005619@intel.com> In-Reply-To: <227d2fe4-ddf8-89c9-b80b-142674c2cca0@solarflare.com> References: <20200911012337.14015-1-jesse.brandeburg@intel.com> <20200911012337.14015-12-jesse.brandeburg@intel.com> <227d2fe4-ddf8-89c9-b80b-142674c2cca0@solarflare.com> X-Mailer: Claws Mail 3.12.0 (GTK+ 2.24.28; i686-w64-mingw32) MIME-Version: 1.0 Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 8BIT Sender: netdev-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org Edward Cree wrote: > On 11/09/2020 02:23, Jesse Brandeburg wrote: > > + * @MC_CMD_PTP_IN_TRANSMIT_LENMAX: hack to get W=1 to compile > I think I'd rather have a bogus warning than bogus kerneldocto suppress it; >  please drop this line (and encourage toolchain folks to figure out how to >  get kerneldoc to ignore macros it can't understand). > Apart from that, the sfc and sfc/falcon parts LGTM. > > -ed Thanks Ed, I think I might just remove the /** on that function then (removing it from kdoc processing), would that be acceptable in the meantime? Of course I'd remove the line I added as well. - Jesse From mboxrd@z Thu Jan 1 00:00:00 1970 From: Jesse Brandeburg Date: Fri, 11 Sep 2020 14:42:07 -0700 Subject: [Intel-wired-lan] [RFC PATCH net-next v1 11/11] drivers/net/ethernet: clean up mis-targeted comments In-Reply-To: <227d2fe4-ddf8-89c9-b80b-142674c2cca0@solarflare.com> References: <20200911012337.14015-1-jesse.brandeburg@intel.com> <20200911012337.14015-12-jesse.brandeburg@intel.com> <227d2fe4-ddf8-89c9-b80b-142674c2cca0@solarflare.com> Message-ID: <20200911144207.00005619@intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: intel-wired-lan@osuosl.org List-ID: Edward Cree wrote: > On 11/09/2020 02:23, Jesse Brandeburg wrote: > > + * @MC_CMD_PTP_IN_TRANSMIT_LENMAX: hack to get W=1 to compile > I think I'd rather have a bogus warning than bogus kerneldocto suppress it; > ?please drop this line (and encourage toolchain folks to figure out how to > ?get kerneldoc to ignore macros it can't understand). > Apart from that, the sfc and sfc/falcon parts LGTM. > > -ed Thanks Ed, I think I might just remove the /** on that function then (removing it from kdoc processing), would that be acceptable in the meantime? Of course I'd remove the line I added as well. - Jesse