From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-3.9 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id A8710C433E2 for ; Fri, 11 Sep 2020 20:05:21 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 3AFD421D91 for ; Fri, 11 Sep 2020 20:05:21 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=ziepe.ca header.i=@ziepe.ca header.b="I9voHxb8" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1725855AbgIKUFT (ORCPT ); Fri, 11 Sep 2020 16:05:19 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:49188 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1725815AbgIKUFO (ORCPT ); Fri, 11 Sep 2020 16:05:14 -0400 Received: from mail-il1-x141.google.com (mail-il1-x141.google.com [IPv6:2607:f8b0:4864:20::141]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 3CF6EC0613ED for ; Fri, 11 Sep 2020 13:05:14 -0700 (PDT) Received: by mail-il1-x141.google.com with SMTP id q6so10057546ild.12 for ; Fri, 11 Sep 2020 13:05:14 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ziepe.ca; s=google; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to; bh=lkQcTqH4VEZ3iEgT/GD9JP5N85keOg351zxTDmOcIaI=; b=I9voHxb8dJ7Hpr77FARBSPzOQ+MPVMwPkwF0luH+LKCeQ2lgpDwGcralZQ0FGAYrwc BVvqLhsKXRb6YcR4pkKP2c34FkKNgqX6pj64qFDH7oE4338e+VgL2+G3FMKW2FPuHDYW MOKS2lLDde3qke8PUPdIqAr1Lc/lVhX7oeWxLzC+beM8ycXu9dGfsOKsCsNwUr3jtzLk 5mkQWm2rxczvKT5Nvh/ZTiFFTOW6UPc+/aWP2W0F+b+rADWmR1dpfaY8WBd7QI32TkZL 3etlwSquQXvam+E6vRIK7GF1RHnaGGDJvV4v5yGgCZRyA8h08sygo6M84bfQ7xFbLqxr cOXQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=lkQcTqH4VEZ3iEgT/GD9JP5N85keOg351zxTDmOcIaI=; b=MOswy5wKH/TMPghq1xofsZXISbDCnZBGpx+Y4TQUCEVCDwV0VsgUQaz8ruR2YGfLzv d5K9mP27KLSrZAp0FovUfJaEc+AZ+MpiPW4+mfoIkToSEFJyzSdOs7jpHw/GioJMn5n7 plzPLDe5+4rnMEUGU/y05kHwVxbokb/LWEZ7C/e+xBU4dChJHSvZWalh8qvZmoH6X12i ipm1GMhgWtSY2fjOLxgXeHX3zW7fIm/AbCptPuREpGx7uwkhdjVwc6MIlhPmhK1f+riu qaSsYE3tBzlp/rhXCZkwKZ3j3/c8fZGRu9QStmqQQWCdwMsQ5xcEPdM54CB0c7goYkxQ Ocsg== X-Gm-Message-State: AOAM531jS4qDqQQCc7KMXKSgyC0XurN4PMQJW0VxYfmk5hKIu/KwXa+2 t31eq17a/EpF9w1na2kCAm5Omg== X-Google-Smtp-Source: ABdhPJwYA/rzSMaXI+K0i70ikIv3tpbBn8J3glPlyteqvWFcMv0jpWCYFK3IcfJC1YHXSV5pVRNS1g== X-Received: by 2002:a92:c791:: with SMTP id c17mr3247679ilk.107.1599854713521; Fri, 11 Sep 2020 13:05:13 -0700 (PDT) Received: from ziepe.ca ([206.223.160.26]) by smtp.gmail.com with ESMTPSA id j62sm1648212iof.53.2020.09.11.13.05.12 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 11 Sep 2020 13:05:12 -0700 (PDT) Received: from jgg by mlx with local (Exim 4.94) (envelope-from ) id 1kGpIF-005AGU-JV; Fri, 11 Sep 2020 17:05:11 -0300 Date: Fri, 11 Sep 2020 17:05:11 -0300 From: Jason Gunthorpe To: Vasily Gorbik Cc: John Hubbard , Linus Torvalds , Gerald Schaefer , Alexander Gordeev , Peter Zijlstra , Dave Hansen , LKML , linux-mm , linux-arch , Andrew Morton , Russell King , Mike Rapoport , Catalin Marinas , Will Deacon , Michael Ellerman , Benjamin Herrenschmidt , Paul Mackerras , Jeff Dike , Richard Weinberger , Dave Hansen , Andy Lutomirski , Thomas Gleixner , Ingo Molnar , Borislav Petkov , Arnd Bergmann , Andrey Ryabinin , linux-x86 , linux-arm , linux-power , linux-sparc , linux-um , linux-s390 , Heiko Carstens , Christian Borntraeger , Claudio Imbrenda Subject: Re: [PATCH] mm/gup: fix gup_fast with dynamic page table folding Message-ID: <20200911200511.GC1221970@ziepe.ca> References: <20200911070939.GB1362448@hirez.programming.kicks-ass.net> <20200911194000.GB1221970@ziepe.ca> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20200911194000.GB1221970@ziepe.ca> Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Fri, Sep 11, 2020 at 04:40:00PM -0300, Jason Gunthorpe wrote: > These would probably be better as static inlines though, as only s390 > compiles will type check pudp like this. Never mind, it must be a macro - still need brackets though Jason From mboxrd@z Thu Jan 1 00:00:00 1970 From: Jason Gunthorpe Date: Fri, 11 Sep 2020 20:05:11 +0000 Subject: Re: [PATCH] mm/gup: fix gup_fast with dynamic page table folding Message-Id: <20200911200511.GC1221970@ziepe.ca> List-Id: References: <20200911070939.GB1362448@hirez.programming.kicks-ass.net> <20200911194000.GB1221970@ziepe.ca> In-Reply-To: <20200911194000.GB1221970@ziepe.ca> MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: Vasily Gorbik Cc: John Hubbard , Linus Torvalds , Gerald Schaefer , Alexander Gordeev , Peter Zijlstra , Dave Hansen , LKML , linux-mm , linux-arch , Andrew Morton , Russell King , Mike Rapoport , Catalin Marinas , Will Deacon , Michael Ellerman , Benjamin Herrenschmidt , Paul Mackerras , Jeff Dike , Richard Weinberger , Dave Hansen , Andy Lutomirski , Thomas Gleixner , Ingo Molnar , Borislav Petkov , Arnd Bergmann , Andrey Ryabinin , linux-x86 , linux-arm , linux-power , linux-sparc , linux-um , linux-s390 , Heiko Carstens , Christian Borntraeger , Claudio Imbrenda On Fri, Sep 11, 2020 at 04:40:00PM -0300, Jason Gunthorpe wrote: > These would probably be better as static inlines though, as only s390 > compiles will type check pudp like this. Never mind, it must be a macro - still need brackets though Jason From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-3.5 required=3.0 tests=BAYES_00,DKIM_INVALID, DKIM_SIGNED,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE, SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 28D17C433E2 for ; Fri, 11 Sep 2020 20:07:22 +0000 (UTC) Received: from lists.ozlabs.org (lists.ozlabs.org [203.11.71.2]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 8D968221E3 for ; Fri, 11 Sep 2020 20:07:21 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=fail reason="signature verification failed" (2048-bit key) header.d=ziepe.ca header.i=@ziepe.ca header.b="I9voHxb8" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 8D968221E3 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=ziepe.ca Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=linuxppc-dev-bounces+linuxppc-dev=archiver.kernel.org@lists.ozlabs.org Received: from bilbo.ozlabs.org (lists.ozlabs.org [IPv6:2401:3900:2:1::3]) by lists.ozlabs.org (Postfix) with ESMTP id 4Bp6HC1CkwzDqwV for ; Sat, 12 Sep 2020 06:07:19 +1000 (AEST) Authentication-Results: lists.ozlabs.org; spf=pass (sender SPF authorized) smtp.mailfrom=ziepe.ca (client-ip=2607:f8b0:4864:20::143; helo=mail-il1-x143.google.com; envelope-from=jgg@ziepe.ca; receiver=) Authentication-Results: lists.ozlabs.org; dmarc=none (p=none dis=none) header.from=ziepe.ca Authentication-Results: lists.ozlabs.org; dkim=pass (2048-bit key; secure) header.d=ziepe.ca header.i=@ziepe.ca header.a=rsa-sha256 header.s=google header.b=I9voHxb8; dkim-atps=neutral Received: from mail-il1-x143.google.com (mail-il1-x143.google.com [IPv6:2607:f8b0:4864:20::143]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by lists.ozlabs.org (Postfix) with ESMTPS id 4Bp6Dt1XSjzDqqJ for ; Sat, 12 Sep 2020 06:05:15 +1000 (AEST) Received: by mail-il1-x143.google.com with SMTP id a8so10152678ilk.1 for ; Fri, 11 Sep 2020 13:05:15 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ziepe.ca; s=google; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to; bh=lkQcTqH4VEZ3iEgT/GD9JP5N85keOg351zxTDmOcIaI=; b=I9voHxb8dJ7Hpr77FARBSPzOQ+MPVMwPkwF0luH+LKCeQ2lgpDwGcralZQ0FGAYrwc BVvqLhsKXRb6YcR4pkKP2c34FkKNgqX6pj64qFDH7oE4338e+VgL2+G3FMKW2FPuHDYW MOKS2lLDde3qke8PUPdIqAr1Lc/lVhX7oeWxLzC+beM8ycXu9dGfsOKsCsNwUr3jtzLk 5mkQWm2rxczvKT5Nvh/ZTiFFTOW6UPc+/aWP2W0F+b+rADWmR1dpfaY8WBd7QI32TkZL 3etlwSquQXvam+E6vRIK7GF1RHnaGGDJvV4v5yGgCZRyA8h08sygo6M84bfQ7xFbLqxr cOXQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=lkQcTqH4VEZ3iEgT/GD9JP5N85keOg351zxTDmOcIaI=; b=nslgmIzqSAJDOvUULRZRlkNZhALtqMC0X+VLADBWQAMWXJ2U6qRkeEWKOIR3GpH+Hc kvxF17mL5L9cUyfHKf+M8aPeQLmI+7cX1ootSla9+AOMk/eU9SPfMqtnmFv+dBuuovi2 o7NbCTYliUb0o2iJM2Xkk0lWl/wpclBL+EREKYBnr06z2ayDZvlyWfVPUJVo2t/4ozCz lXStLYpIPVmC5Weqq+iBnA0CLXw+pAAS95qFAGTt0vfPqgwI3la5gnlFoMMJCg6lta+4 znuqWzFD6VweJm/PFxlSDyoJeyqrFueHgOk5w8DBm9mUS576LIHybbVYcGikyySxaTQd vNOA== X-Gm-Message-State: AOAM531TsAjiekFu7NtrmUJRQqoqiOdrxTusi434UL4fttFrjR3mEdih sQzH/PuwTllHFEbkNVKz6ItlBw== X-Google-Smtp-Source: ABdhPJwYA/rzSMaXI+K0i70ikIv3tpbBn8J3glPlyteqvWFcMv0jpWCYFK3IcfJC1YHXSV5pVRNS1g== X-Received: by 2002:a92:c791:: with SMTP id c17mr3247679ilk.107.1599854713521; Fri, 11 Sep 2020 13:05:13 -0700 (PDT) Received: from ziepe.ca ([206.223.160.26]) by smtp.gmail.com with ESMTPSA id j62sm1648212iof.53.2020.09.11.13.05.12 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 11 Sep 2020 13:05:12 -0700 (PDT) Received: from jgg by mlx with local (Exim 4.94) (envelope-from ) id 1kGpIF-005AGU-JV; Fri, 11 Sep 2020 17:05:11 -0300 Date: Fri, 11 Sep 2020 17:05:11 -0300 From: Jason Gunthorpe To: Vasily Gorbik Subject: Re: [PATCH] mm/gup: fix gup_fast with dynamic page table folding Message-ID: <20200911200511.GC1221970@ziepe.ca> References: <20200911070939.GB1362448@hirez.programming.kicks-ass.net> <20200911194000.GB1221970@ziepe.ca> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20200911194000.GB1221970@ziepe.ca> X-BeenThere: linuxppc-dev@lists.ozlabs.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Linux on PowerPC Developers Mail List List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Peter Zijlstra , Dave Hansen , linux-mm , Paul Mackerras , linux-sparc , Alexander Gordeev , Claudio Imbrenda , Will Deacon , linux-arch , linux-s390 , Richard Weinberger , linux-x86 , Russell King , Christian Borntraeger , Ingo Molnar , Catalin Marinas , Andrey Ryabinin , Gerald Schaefer , Heiko Carstens , Arnd Bergmann , John Hubbard , Jeff Dike , linux-um , Borislav Petkov , Andy Lutomirski , Thomas Gleixner , linux-arm , Dave Hansen , linux-power , LKML , Andrew Morton , Linus Torvalds , Mike Rapoport Errors-To: linuxppc-dev-bounces+linuxppc-dev=archiver.kernel.org@lists.ozlabs.org Sender: "Linuxppc-dev" On Fri, Sep 11, 2020 at 04:40:00PM -0300, Jason Gunthorpe wrote: > These would probably be better as static inlines though, as only s390 > compiles will type check pudp like this. Never mind, it must be a macro - still need brackets though Jason From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-3.8 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 1E9F1C433E2 for ; Fri, 11 Sep 2020 20:06:45 +0000 (UTC) Received: from merlin.infradead.org (merlin.infradead.org [205.233.59.134]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id A173C221E3 for ; Fri, 11 Sep 2020 20:06:44 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="O/L+ZMKo"; dkim=fail reason="signature verification failed" (2048-bit key) header.d=ziepe.ca header.i=@ziepe.ca header.b="I9voHxb8" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org A173C221E3 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=ziepe.ca Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=merlin.20170209; h=Sender:Content-Transfer-Encoding: Content-Type:Cc:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References:Message-ID: Subject:To:From:Date:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=LAroIbyOQwjdaFK8R2wcQwWPeXBuy5ueLDK+x0I9Gnk=; b=O/L+ZMKo/EmHeTxw7EM3JCscK u93gQC4SNli5wnpbW9H3QaoGL8VTlhYdfvguCiYbV4H3nIk4Ze2WeizeiQehcd4hqH8F7cLy4BK/s t+HN9octAlh+PqUj0OP/aU+urOcdlCEYWOopgwVbMle8/1NKUd4I46bfhQ6ay6cXCHbBR8q257w82 edUg5G51AN6i4bEtxltFpDdXLSZTUBASNLmj0+dC8MzDfNd1y1pj/9LgZ5Q9kj7k7j3Fy9PwRkhpV eUWPajC8G2KFoKfKjlB8H86weXik8t/aUGSnNAk3sKtBb8x+r7+MUPuPRgr+4EUAB2QvGOaQxDNX4 ew1P1VcLw==; Received: from localhost ([::1] helo=merlin.infradead.org) by merlin.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1kGpIN-0005bb-PA; Fri, 11 Sep 2020 20:05:19 +0000 Received: from mail-il1-x142.google.com ([2607:f8b0:4864:20::142]) by merlin.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1kGpIK-0005Zc-14 for linux-arm-kernel@lists.infradead.org; Fri, 11 Sep 2020 20:05:17 +0000 Received: by mail-il1-x142.google.com with SMTP id q6so10057545ild.12 for ; Fri, 11 Sep 2020 13:05:14 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ziepe.ca; s=google; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to; bh=lkQcTqH4VEZ3iEgT/GD9JP5N85keOg351zxTDmOcIaI=; b=I9voHxb8dJ7Hpr77FARBSPzOQ+MPVMwPkwF0luH+LKCeQ2lgpDwGcralZQ0FGAYrwc BVvqLhsKXRb6YcR4pkKP2c34FkKNgqX6pj64qFDH7oE4338e+VgL2+G3FMKW2FPuHDYW MOKS2lLDde3qke8PUPdIqAr1Lc/lVhX7oeWxLzC+beM8ycXu9dGfsOKsCsNwUr3jtzLk 5mkQWm2rxczvKT5Nvh/ZTiFFTOW6UPc+/aWP2W0F+b+rADWmR1dpfaY8WBd7QI32TkZL 3etlwSquQXvam+E6vRIK7GF1RHnaGGDJvV4v5yGgCZRyA8h08sygo6M84bfQ7xFbLqxr cOXQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=lkQcTqH4VEZ3iEgT/GD9JP5N85keOg351zxTDmOcIaI=; b=uYkjaI2gUISL0vrsYBW2vVOn8yNfQw0Ly3JPRJjHisWg69aKYDt7EpnUpOeiNecgrG r1eGQayS+fSwI93OfFLhRAa0LRszLVxsZzYWzGSFi3fU6xlwrQKBwegQvz/S3Zv8Qb2v lrNAFRlMxn9k9RxDa0sHR2UWZOeX6ZODBVrkCyHSHsSkcRQ1mhSDl3x5fkAWLRi9oWKf aFr5XhFS35QCCl7l3FLNT4DxHdhMfQHInCQGTct46iIvWbGohR0Rfgkxpb27WvLlv1DX 8x3rKq06BDbOOe5sCSTaam0zwvW4lk5CK3tkKVpP2NOOqGNe0wMn6BFnrNPnNgduxpi4 bYtg== X-Gm-Message-State: AOAM533dYXdlpKLuGDEUbNmiKlmAW7jDhWNiQ51gg/CQxlIC0NI2b5xw GD7RAKtEVFtP7oeXOplK3EyB2Q== X-Google-Smtp-Source: ABdhPJwYA/rzSMaXI+K0i70ikIv3tpbBn8J3glPlyteqvWFcMv0jpWCYFK3IcfJC1YHXSV5pVRNS1g== X-Received: by 2002:a92:c791:: with SMTP id c17mr3247679ilk.107.1599854713521; Fri, 11 Sep 2020 13:05:13 -0700 (PDT) Received: from ziepe.ca ([206.223.160.26]) by smtp.gmail.com with ESMTPSA id j62sm1648212iof.53.2020.09.11.13.05.12 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 11 Sep 2020 13:05:12 -0700 (PDT) Received: from jgg by mlx with local (Exim 4.94) (envelope-from ) id 1kGpIF-005AGU-JV; Fri, 11 Sep 2020 17:05:11 -0300 Date: Fri, 11 Sep 2020 17:05:11 -0300 From: Jason Gunthorpe To: Vasily Gorbik Subject: Re: [PATCH] mm/gup: fix gup_fast with dynamic page table folding Message-ID: <20200911200511.GC1221970@ziepe.ca> References: <20200911070939.GB1362448@hirez.programming.kicks-ass.net> <20200911194000.GB1221970@ziepe.ca> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20200911194000.GB1221970@ziepe.ca> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20200911_160516_135981_34AE010B X-CRM114-Status: GOOD ( 11.72 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Peter Zijlstra , Benjamin Herrenschmidt , Dave Hansen , linux-mm , Paul Mackerras , linux-sparc , Alexander Gordeev , Claudio Imbrenda , Will Deacon , linux-arch , linux-s390 , Richard Weinberger , linux-x86 , Russell King , Christian Borntraeger , Ingo Molnar , Catalin Marinas , Andrey Ryabinin , Gerald Schaefer , Heiko Carstens , Arnd Bergmann , John Hubbard , Jeff Dike , linux-um , Borislav Petkov , Andy Lutomirski , Thomas Gleixner , linux-arm , Dave Hansen , linux-power , LKML , Michael Ellerman , Andrew Morton , Linus Torvalds , Mike Rapoport Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Fri, Sep 11, 2020 at 04:40:00PM -0300, Jason Gunthorpe wrote: > These would probably be better as static inlines though, as only s390 > compiles will type check pudp like this. Never mind, it must be a macro - still need brackets though Jason _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-il1-x144.google.com ([2607:f8b0:4864:20::144]) by merlin.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1kGpIK-0005Zd-17 for linux-um@lists.infradead.org; Fri, 11 Sep 2020 20:05:17 +0000 Received: by mail-il1-x144.google.com with SMTP id t13so10091487ile.9 for ; Fri, 11 Sep 2020 13:05:14 -0700 (PDT) Date: Fri, 11 Sep 2020 17:05:11 -0300 From: Jason Gunthorpe Subject: Re: [PATCH] mm/gup: fix gup_fast with dynamic page table folding Message-ID: <20200911200511.GC1221970@ziepe.ca> References: <20200911070939.GB1362448@hirez.programming.kicks-ass.net> <20200911194000.GB1221970@ziepe.ca> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20200911194000.GB1221970@ziepe.ca> List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-um" Errors-To: linux-um-bounces+geert=linux-m68k.org@lists.infradead.org To: Vasily Gorbik Cc: Peter Zijlstra , Benjamin Herrenschmidt , Dave Hansen , linux-mm , Paul Mackerras , linux-sparc , Alexander Gordeev , Claudio Imbrenda , Will Deacon , linux-arch , linux-s390 , Richard Weinberger , linux-x86 , Russell King , Christian Borntraeger , Ingo Molnar , Catalin Marinas , Andrey Ryabinin , Gerald Schaefer , Heiko Carstens , Arnd Bergmann , John Hubbard , Jeff Dike , linux-um , Borislav Petkov , Andy Lutomirski , Thomas Gleixner , linux-arm , Dave Hansen , linux-power , LKML , Michael Ellerman , Andrew Morton , Linus Torvalds , Mike Rapoport On Fri, Sep 11, 2020 at 04:40:00PM -0300, Jason Gunthorpe wrote: > These would probably be better as static inlines though, as only s390 > compiles will type check pudp like this. Never mind, it must be a macro - still need brackets though Jason _______________________________________________ linux-um mailing list linux-um@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-um