* [PATCH 0/3] drivers/virtio: Constify static struct virtio_device_id
@ 2020-09-11 20:35 Rikard Falkeborn
2020-09-11 20:35 ` [PATCH 1/3] virtio-balloon: Constify id_table Rikard Falkeborn
` (2 more replies)
0 siblings, 3 replies; 10+ messages in thread
From: Rikard Falkeborn @ 2020-09-11 20:35 UTC (permalink / raw)
To: virtualization
Cc: linux-kernel, Michael S. Tsirkin, David Hildenbrand, Jason Wang,
Gerd Hoffmann, Rikard Falkeborn
Constify a couple of instances of static struct virtio_device_id which
are never modified. This allows the compiler to put them in read-only
memory.
Rikard Falkeborn (3):
virtio-balloon: Constify id_table
virtio_input: Constify id_table
virtio-mem: Constify mem_id_table
drivers/virtio/virtio_balloon.c | 2 +-
drivers/virtio/virtio_input.c | 2 +-
drivers/virtio/virtio_mem.c | 2 +-
3 files changed, 3 insertions(+), 3 deletions(-)
--
2.28.0
^ permalink raw reply [flat|nested] 10+ messages in thread
* [PATCH 1/3] virtio-balloon: Constify id_table
2020-09-11 20:35 [PATCH 0/3] drivers/virtio: Constify static struct virtio_device_id Rikard Falkeborn
@ 2020-09-11 20:35 ` Rikard Falkeborn
2020-09-14 7:46 ` David Hildenbrand
2020-09-11 20:35 ` [PATCH 2/3] virtio_input: " Rikard Falkeborn
2020-09-11 20:35 ` [PATCH 3/3] virtio-mem: Constify mem_id_table Rikard Falkeborn
2 siblings, 1 reply; 10+ messages in thread
From: Rikard Falkeborn @ 2020-09-11 20:35 UTC (permalink / raw)
To: virtualization
Cc: linux-kernel, Michael S. Tsirkin, David Hildenbrand, Jason Wang,
Gerd Hoffmann, Rikard Falkeborn
id_table is not modified, so make it const to allow the compiler to put
it in read-only memory.
Signed-off-by: Rikard Falkeborn <rikard.falkeborn@gmail.com>
---
drivers/virtio/virtio_balloon.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/virtio/virtio_balloon.c b/drivers/virtio/virtio_balloon.c
index 31cc97f2f515..481611c09dae 100644
--- a/drivers/virtio/virtio_balloon.c
+++ b/drivers/virtio/virtio_balloon.c
@@ -128,7 +128,7 @@ struct virtio_balloon {
struct page_reporting_dev_info pr_dev_info;
};
-static struct virtio_device_id id_table[] = {
+static const struct virtio_device_id id_table[] = {
{ VIRTIO_ID_BALLOON, VIRTIO_DEV_ANY_ID },
{ 0 },
};
--
2.28.0
^ permalink raw reply related [flat|nested] 10+ messages in thread
* [PATCH 2/3] virtio_input: Constify id_table
2020-09-11 20:35 [PATCH 0/3] drivers/virtio: Constify static struct virtio_device_id Rikard Falkeborn
2020-09-11 20:35 ` [PATCH 1/3] virtio-balloon: Constify id_table Rikard Falkeborn
@ 2020-09-11 20:35 ` Rikard Falkeborn
2020-09-14 7:46 ` David Hildenbrand
2020-09-11 20:35 ` [PATCH 3/3] virtio-mem: Constify mem_id_table Rikard Falkeborn
2 siblings, 1 reply; 10+ messages in thread
From: Rikard Falkeborn @ 2020-09-11 20:35 UTC (permalink / raw)
To: virtualization
Cc: linux-kernel, Michael S. Tsirkin, David Hildenbrand, Jason Wang,
Gerd Hoffmann, Rikard Falkeborn
id_table is not modified, so make it const to allow the compiler to put
it in read-only memory.
Signed-off-by: Rikard Falkeborn <rikard.falkeborn@gmail.com>
---
drivers/virtio/virtio_input.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/virtio/virtio_input.c b/drivers/virtio/virtio_input.c
index 877b2ea3ed05..f1f6208edcf5 100644
--- a/drivers/virtio/virtio_input.c
+++ b/drivers/virtio/virtio_input.c
@@ -363,7 +363,7 @@ static int virtinput_restore(struct virtio_device *vdev)
static unsigned int features[] = {
/* none */
};
-static struct virtio_device_id id_table[] = {
+static const struct virtio_device_id id_table[] = {
{ VIRTIO_ID_INPUT, VIRTIO_DEV_ANY_ID },
{ 0 },
};
--
2.28.0
^ permalink raw reply related [flat|nested] 10+ messages in thread
* [PATCH 3/3] virtio-mem: Constify mem_id_table
2020-09-11 20:35 [PATCH 0/3] drivers/virtio: Constify static struct virtio_device_id Rikard Falkeborn
2020-09-11 20:35 ` [PATCH 1/3] virtio-balloon: Constify id_table Rikard Falkeborn
2020-09-11 20:35 ` [PATCH 2/3] virtio_input: " Rikard Falkeborn
@ 2020-09-11 20:35 ` Rikard Falkeborn
2020-09-14 7:46 ` David Hildenbrand
2 siblings, 1 reply; 10+ messages in thread
From: Rikard Falkeborn @ 2020-09-11 20:35 UTC (permalink / raw)
To: virtualization
Cc: linux-kernel, Michael S. Tsirkin, David Hildenbrand, Jason Wang,
Gerd Hoffmann, Rikard Falkeborn
mem_id_table is not modified, so make it const to allow the compiler to
put it in read-only memory.
Signed-off-by: Rikard Falkeborn <rikard.falkeborn@gmail.com>
---
drivers/virtio/virtio_mem.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/virtio/virtio_mem.c b/drivers/virtio/virtio_mem.c
index 834b7c13ef3d..1d0f3ab2b509 100644
--- a/drivers/virtio/virtio_mem.c
+++ b/drivers/virtio/virtio_mem.c
@@ -1926,7 +1926,7 @@ static unsigned int virtio_mem_features[] = {
#endif
};
-static struct virtio_device_id virtio_mem_id_table[] = {
+static const struct virtio_device_id virtio_mem_id_table[] = {
{ VIRTIO_ID_MEM, VIRTIO_DEV_ANY_ID },
{ 0 },
};
--
2.28.0
^ permalink raw reply related [flat|nested] 10+ messages in thread
* Re: [PATCH 3/3] virtio-mem: Constify mem_id_table
2020-09-11 20:35 ` [PATCH 3/3] virtio-mem: Constify mem_id_table Rikard Falkeborn
@ 2020-09-14 7:46 ` David Hildenbrand
0 siblings, 0 replies; 10+ messages in thread
From: David Hildenbrand @ 2020-09-14 7:46 UTC (permalink / raw)
To: Rikard Falkeborn, virtualization
Cc: linux-kernel, Michael S. Tsirkin, Jason Wang, Gerd Hoffmann
On 11.09.20 22:35, Rikard Falkeborn wrote:
> mem_id_table is not modified, so make it const to allow the compiler to
> put it in read-only memory.
>
> Signed-off-by: Rikard Falkeborn <rikard.falkeborn@gmail.com>
> ---
> drivers/virtio/virtio_mem.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/virtio/virtio_mem.c b/drivers/virtio/virtio_mem.c
> index 834b7c13ef3d..1d0f3ab2b509 100644
> --- a/drivers/virtio/virtio_mem.c
> +++ b/drivers/virtio/virtio_mem.c
> @@ -1926,7 +1926,7 @@ static unsigned int virtio_mem_features[] = {
> #endif
> };
>
> -static struct virtio_device_id virtio_mem_id_table[] = {
> +static const struct virtio_device_id virtio_mem_id_table[] = {
> { VIRTIO_ID_MEM, VIRTIO_DEV_ANY_ID },
> { 0 },
> };
>
Acked-by: David Hildenbrand <david@redhat.com>
--
Thanks,
David / dhildenb
^ permalink raw reply [flat|nested] 10+ messages in thread
* Re: [PATCH 3/3] virtio-mem: Constify mem_id_table
@ 2020-09-14 7:46 ` David Hildenbrand
0 siblings, 0 replies; 10+ messages in thread
From: David Hildenbrand @ 2020-09-14 7:46 UTC (permalink / raw)
To: Rikard Falkeborn, virtualization; +Cc: linux-kernel, Michael S. Tsirkin
On 11.09.20 22:35, Rikard Falkeborn wrote:
> mem_id_table is not modified, so make it const to allow the compiler to
> put it in read-only memory.
>
> Signed-off-by: Rikard Falkeborn <rikard.falkeborn@gmail.com>
> ---
> drivers/virtio/virtio_mem.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/virtio/virtio_mem.c b/drivers/virtio/virtio_mem.c
> index 834b7c13ef3d..1d0f3ab2b509 100644
> --- a/drivers/virtio/virtio_mem.c
> +++ b/drivers/virtio/virtio_mem.c
> @@ -1926,7 +1926,7 @@ static unsigned int virtio_mem_features[] = {
> #endif
> };
>
> -static struct virtio_device_id virtio_mem_id_table[] = {
> +static const struct virtio_device_id virtio_mem_id_table[] = {
> { VIRTIO_ID_MEM, VIRTIO_DEV_ANY_ID },
> { 0 },
> };
>
Acked-by: David Hildenbrand <david@redhat.com>
--
Thanks,
David / dhildenb
_______________________________________________
Virtualization mailing list
Virtualization@lists.linux-foundation.org
https://lists.linuxfoundation.org/mailman/listinfo/virtualization
^ permalink raw reply [flat|nested] 10+ messages in thread
* Re: [PATCH 1/3] virtio-balloon: Constify id_table
2020-09-11 20:35 ` [PATCH 1/3] virtio-balloon: Constify id_table Rikard Falkeborn
@ 2020-09-14 7:46 ` David Hildenbrand
0 siblings, 0 replies; 10+ messages in thread
From: David Hildenbrand @ 2020-09-14 7:46 UTC (permalink / raw)
To: Rikard Falkeborn, virtualization
Cc: linux-kernel, Michael S. Tsirkin, Jason Wang, Gerd Hoffmann
On 11.09.20 22:35, Rikard Falkeborn wrote:
> id_table is not modified, so make it const to allow the compiler to put
> it in read-only memory.
>
> Signed-off-by: Rikard Falkeborn <rikard.falkeborn@gmail.com>
> ---
> drivers/virtio/virtio_balloon.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/virtio/virtio_balloon.c b/drivers/virtio/virtio_balloon.c
> index 31cc97f2f515..481611c09dae 100644
> --- a/drivers/virtio/virtio_balloon.c
> +++ b/drivers/virtio/virtio_balloon.c
> @@ -128,7 +128,7 @@ struct virtio_balloon {
> struct page_reporting_dev_info pr_dev_info;
> };
>
> -static struct virtio_device_id id_table[] = {
> +static const struct virtio_device_id id_table[] = {
> { VIRTIO_ID_BALLOON, VIRTIO_DEV_ANY_ID },
> { 0 },
> };
>
Acked-by: David Hildenbrand <david@redhat.com>
--
Thanks,
David / dhildenb
^ permalink raw reply [flat|nested] 10+ messages in thread
* Re: [PATCH 1/3] virtio-balloon: Constify id_table
@ 2020-09-14 7:46 ` David Hildenbrand
0 siblings, 0 replies; 10+ messages in thread
From: David Hildenbrand @ 2020-09-14 7:46 UTC (permalink / raw)
To: Rikard Falkeborn, virtualization; +Cc: linux-kernel, Michael S. Tsirkin
On 11.09.20 22:35, Rikard Falkeborn wrote:
> id_table is not modified, so make it const to allow the compiler to put
> it in read-only memory.
>
> Signed-off-by: Rikard Falkeborn <rikard.falkeborn@gmail.com>
> ---
> drivers/virtio/virtio_balloon.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/virtio/virtio_balloon.c b/drivers/virtio/virtio_balloon.c
> index 31cc97f2f515..481611c09dae 100644
> --- a/drivers/virtio/virtio_balloon.c
> +++ b/drivers/virtio/virtio_balloon.c
> @@ -128,7 +128,7 @@ struct virtio_balloon {
> struct page_reporting_dev_info pr_dev_info;
> };
>
> -static struct virtio_device_id id_table[] = {
> +static const struct virtio_device_id id_table[] = {
> { VIRTIO_ID_BALLOON, VIRTIO_DEV_ANY_ID },
> { 0 },
> };
>
Acked-by: David Hildenbrand <david@redhat.com>
--
Thanks,
David / dhildenb
_______________________________________________
Virtualization mailing list
Virtualization@lists.linux-foundation.org
https://lists.linuxfoundation.org/mailman/listinfo/virtualization
^ permalink raw reply [flat|nested] 10+ messages in thread
* Re: [PATCH 2/3] virtio_input: Constify id_table
2020-09-11 20:35 ` [PATCH 2/3] virtio_input: " Rikard Falkeborn
@ 2020-09-14 7:46 ` David Hildenbrand
0 siblings, 0 replies; 10+ messages in thread
From: David Hildenbrand @ 2020-09-14 7:46 UTC (permalink / raw)
To: Rikard Falkeborn, virtualization
Cc: linux-kernel, Michael S. Tsirkin, Jason Wang, Gerd Hoffmann
On 11.09.20 22:35, Rikard Falkeborn wrote:
> id_table is not modified, so make it const to allow the compiler to put
> it in read-only memory.
>
> Signed-off-by: Rikard Falkeborn <rikard.falkeborn@gmail.com>
> ---
> drivers/virtio/virtio_input.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/virtio/virtio_input.c b/drivers/virtio/virtio_input.c
> index 877b2ea3ed05..f1f6208edcf5 100644
> --- a/drivers/virtio/virtio_input.c
> +++ b/drivers/virtio/virtio_input.c
> @@ -363,7 +363,7 @@ static int virtinput_restore(struct virtio_device *vdev)
> static unsigned int features[] = {
> /* none */
> };
> -static struct virtio_device_id id_table[] = {
> +static const struct virtio_device_id id_table[] = {
> { VIRTIO_ID_INPUT, VIRTIO_DEV_ANY_ID },
> { 0 },
> };
>
Reviewed-by: David Hildenbrand <david@redhat.com>
--
Thanks,
David / dhildenb
^ permalink raw reply [flat|nested] 10+ messages in thread
* Re: [PATCH 2/3] virtio_input: Constify id_table
@ 2020-09-14 7:46 ` David Hildenbrand
0 siblings, 0 replies; 10+ messages in thread
From: David Hildenbrand @ 2020-09-14 7:46 UTC (permalink / raw)
To: Rikard Falkeborn, virtualization; +Cc: linux-kernel, Michael S. Tsirkin
On 11.09.20 22:35, Rikard Falkeborn wrote:
> id_table is not modified, so make it const to allow the compiler to put
> it in read-only memory.
>
> Signed-off-by: Rikard Falkeborn <rikard.falkeborn@gmail.com>
> ---
> drivers/virtio/virtio_input.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/virtio/virtio_input.c b/drivers/virtio/virtio_input.c
> index 877b2ea3ed05..f1f6208edcf5 100644
> --- a/drivers/virtio/virtio_input.c
> +++ b/drivers/virtio/virtio_input.c
> @@ -363,7 +363,7 @@ static int virtinput_restore(struct virtio_device *vdev)
> static unsigned int features[] = {
> /* none */
> };
> -static struct virtio_device_id id_table[] = {
> +static const struct virtio_device_id id_table[] = {
> { VIRTIO_ID_INPUT, VIRTIO_DEV_ANY_ID },
> { 0 },
> };
>
Reviewed-by: David Hildenbrand <david@redhat.com>
--
Thanks,
David / dhildenb
_______________________________________________
Virtualization mailing list
Virtualization@lists.linux-foundation.org
https://lists.linuxfoundation.org/mailman/listinfo/virtualization
^ permalink raw reply [flat|nested] 10+ messages in thread
end of thread, other threads:[~2020-09-14 7:47 UTC | newest]
Thread overview: 10+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2020-09-11 20:35 [PATCH 0/3] drivers/virtio: Constify static struct virtio_device_id Rikard Falkeborn
2020-09-11 20:35 ` [PATCH 1/3] virtio-balloon: Constify id_table Rikard Falkeborn
2020-09-14 7:46 ` David Hildenbrand
2020-09-14 7:46 ` David Hildenbrand
2020-09-11 20:35 ` [PATCH 2/3] virtio_input: " Rikard Falkeborn
2020-09-14 7:46 ` David Hildenbrand
2020-09-14 7:46 ` David Hildenbrand
2020-09-11 20:35 ` [PATCH 3/3] virtio-mem: Constify mem_id_table Rikard Falkeborn
2020-09-14 7:46 ` David Hildenbrand
2020-09-14 7:46 ` David Hildenbrand
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.