From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-9.8 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH, MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 5240DC433E2 for ; Sat, 12 Sep 2020 23:22:15 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 149C921531 for ; Sat, 12 Sep 2020 23:22:15 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="VEf+ZebL" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1725940AbgILXWN (ORCPT ); Sat, 12 Sep 2020 19:22:13 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:45818 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1725904AbgILXWJ (ORCPT ); Sat, 12 Sep 2020 19:22:09 -0400 Received: from mail-oi1-x243.google.com (mail-oi1-x243.google.com [IPv6:2607:f8b0:4864:20::243]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id B84D3C061574 for ; Sat, 12 Sep 2020 16:22:08 -0700 (PDT) Received: by mail-oi1-x243.google.com with SMTP id y6so13532601oie.5 for ; Sat, 12 Sep 2020 16:22:08 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to; bh=FWI5tB8plsBtYMxeyZ+TN8d4BsTGYJ/TwddRKid43yU=; b=VEf+ZebL44Ho9ZrJhtXp3LhstkMqCw8BHM4SlyBq+VluvQSKFqwEWQW4w4LqKTaT2P A8NoYt7r0DvQ+OGu0GEej2Li9JhVt8jbw0HbfmgOSGfEGehqzZA3oua/z4/u3E1iLUCl NvZarVFvT4V9ry/qaKWYro5Nvo4JIzGyw9ZXPcgXBaTPlOf+U6lhsi3Cv5hYoM+00Twz TtGauCwDHLUrstr6jZesZeaBMb3nIYPP6CSus75lT+/iiwp6CXsSRZacUqPgpmFpLnOE KT+nLw07stNdDKxCGEr1HYBwCuOtHzY2a/DCwA6UrNO2xTDr/5fT8vUbJWTsovkUXqYN inEg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=FWI5tB8plsBtYMxeyZ+TN8d4BsTGYJ/TwddRKid43yU=; b=h4rs6RtqKBOLafaRC61EPf4ECuuB/ZCB1nsUXi61m6c8uYBTYhaweRmT4XjqTm/HnY TL/UWwD5w4uEUFa/FYde194HmjKBbRc04S9R5peNLGh2Omg8yQcYNYWlSDCkVezMmllY QlMXulniU6U5JkM3b15guj0rG+mjVmkW4CsR32ukdc6Sgw9Nffh+nhA+eQlG7v55rkcd hnefR4i7Uwl6kIQtZcqxAUaxniNUk+J9K3m8sSVJnFDs5DxytAgXsQ9QErjf3fRYpDHd yxyws+R5X1gHPWV7CApWj3nbBT7SefQX42TJWo5oDN6rOFREa1EiN7CKgB8o1ctXzvif N8rw== X-Gm-Message-State: AOAM533Lh+QZPrwhO6ohs5npNGNJtMZE6lKT+162THj1XsunNMAz4270 vntSGbtrzSIj+57nchJH2WEQMQ== X-Google-Smtp-Source: ABdhPJzBse3lngfpKYoCwhh9XI0Wx7OT1j7h5tzu1nDLnfrcVGs59wzoieuTGm3LktdBYVXrdEgM4g== X-Received: by 2002:a05:6808:14f:: with SMTP id h15mr4678051oie.119.1599952928168; Sat, 12 Sep 2020 16:22:08 -0700 (PDT) Received: from yoga ([2605:6000:e5cb:c100:8898:14ff:fe6d:34e]) by smtp.gmail.com with ESMTPSA id w14sm1000028oie.41.2020.09.12.16.22.05 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sat, 12 Sep 2020 16:22:07 -0700 (PDT) Date: Sat, 12 Sep 2020 18:22:03 -0500 From: Bjorn Andersson To: Marc Zyngier Cc: devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, Enric Balletbo i Serra , Frank Wunderlich , John Stultz , Saravana Kannan , Hanks Chen , Andy Gross , Matthias Brugger , Thomas Gleixner , Jason Cooper , Rob Herring , Frank Rowand , kernel-team@android.com Subject: Re: [PATCH 4/6] irqchip/mtk-cirq: Allow modular build Message-ID: <20200912232203.GH3715@yoga> References: <20200912125148.1271481-1-maz@kernel.org> <20200912125148.1271481-5-maz@kernel.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20200912125148.1271481-5-maz@kernel.org> Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Sat 12 Sep 07:51 CDT 2020, Marc Zyngier wrote: > Switch the driver to a "hybrid probe" model which preserves the > built-in behaviour while allowing the driver to be optionnally > built as a module for development purposes. > Reviewed-by: Bjorn Andersson > Signed-off-by: Marc Zyngier > --- > drivers/irqchip/irq-mtk-cirq.c | 4 +++- > 1 file changed, 3 insertions(+), 1 deletion(-) > > diff --git a/drivers/irqchip/irq-mtk-cirq.c b/drivers/irqchip/irq-mtk-cirq.c > index 69ba8ce3c178..43e880b63ed2 100644 > --- a/drivers/irqchip/irq-mtk-cirq.c > +++ b/drivers/irqchip/irq-mtk-cirq.c > @@ -295,4 +295,6 @@ static int __init mtk_cirq_of_init(struct device_node *node, > return ret; > } > > -IRQCHIP_DECLARE(mtk_cirq, "mediatek,mtk-cirq", mtk_cirq_of_init); > +IRQCHIP_HYBRID_DRIVER_BEGIN(mtk_cirq) > +IRQCHIP_MATCH("mediatek,mtk-cirq", mtk_cirq_of_init) > +IRQCHIP_HYBRID_DRIVER_END(mtk_cirq) > -- > 2.28.0 > From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-9.8 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH, MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id C2921C43461 for ; Sat, 12 Sep 2020 23:23:23 +0000 (UTC) Received: from merlin.infradead.org (merlin.infradead.org [205.233.59.134]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 64A5A21531 for ; Sat, 12 Sep 2020 23:23:23 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="YkXTsu1S"; dkim=fail reason="signature verification failed" (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="VEf+ZebL" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 64A5A21531 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=linaro.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=merlin.20170209; h=Sender:Content-Transfer-Encoding: Content-Type:Cc:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References:Message-ID: Subject:To:From:Date:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=pxxfHL9ujCJoE09HtEDmb1J0KjfTe0x6L9BtZprGjhg=; b=YkXTsu1SWVkryzKS6jCRWLMk4 NxZXHOcUs+WlMRdidmra0qLOFYRufwBbPAyAX5JDNzjPRa8a6lm5rVo3Rf7JMydwpIIKzBBF3i3up YfisEJOqWdwMmia1CqsgKoEKlefvZq/p8PneTUe5YZNi301ZeWcrRTUB9VKKOp2pyGymqlg0FJWW0 CQKfOm/OmDWn8duhpuwNJmIevyNpKBUY/pNnNBURgZLuTWSA246yxAQt726NGpN4kbfHrC/ODTsL7 Zet5OztHDDGNgvZeCSW1wOvNzm+/RWnjirnPN1k2wvk/ZB4NM0YHBrIkKcnwmZ4BSG+ECfoWHAlRB hZYaefF5w==; Received: from localhost ([::1] helo=merlin.infradead.org) by merlin.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1kHEqT-0004Sc-Vb; Sat, 12 Sep 2020 23:22:14 +0000 Received: from mail-oi1-x242.google.com ([2607:f8b0:4864:20::242]) by merlin.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1kHEqQ-0004Qr-H3 for linux-arm-kernel@lists.infradead.org; Sat, 12 Sep 2020 23:22:11 +0000 Received: by mail-oi1-x242.google.com with SMTP id a3so13546778oib.4 for ; Sat, 12 Sep 2020 16:22:09 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to; bh=FWI5tB8plsBtYMxeyZ+TN8d4BsTGYJ/TwddRKid43yU=; b=VEf+ZebL44Ho9ZrJhtXp3LhstkMqCw8BHM4SlyBq+VluvQSKFqwEWQW4w4LqKTaT2P A8NoYt7r0DvQ+OGu0GEej2Li9JhVt8jbw0HbfmgOSGfEGehqzZA3oua/z4/u3E1iLUCl NvZarVFvT4V9ry/qaKWYro5Nvo4JIzGyw9ZXPcgXBaTPlOf+U6lhsi3Cv5hYoM+00Twz TtGauCwDHLUrstr6jZesZeaBMb3nIYPP6CSus75lT+/iiwp6CXsSRZacUqPgpmFpLnOE KT+nLw07stNdDKxCGEr1HYBwCuOtHzY2a/DCwA6UrNO2xTDr/5fT8vUbJWTsovkUXqYN inEg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=FWI5tB8plsBtYMxeyZ+TN8d4BsTGYJ/TwddRKid43yU=; b=EYuz7l6sdybz1sSP51JF+UzMYowPHwqC/5QeGiDlsgv8eBig3WKfZ9OytHQbN+4u0C 189UdGC28ynKbhZoyBWTjQq0jweU01xPp+SxMq8an6sz4xza5kL+aWxWmfyMA2OCmquu 6Fd/j4pw8bjv74LK6uHjDAFgufcuQNbiMQ24duBlOfa2ldRKgj0O9RVarNhVj3PfSdh9 X0OuvKL8Zyn8LEzX0lDBUI2nbspTOYLcgpQtOP2T/ld4M2AmDKCXXf/GfMsxJa0sKt4Q AnppXhzBjWJzNPaRXXtuNIV5mi4Gy/U+RCdUFmhLw7ECjbBiMoCDdNWuxPnKPqTP51Nl 2W3g== X-Gm-Message-State: AOAM5328ua7af4QGAN6DcwFdyLW88Ewoma9cllHm05rZGZVM6nVi24vZ vWRB/ufj/p7ovpQKYeCV95xajQ== X-Google-Smtp-Source: ABdhPJzBse3lngfpKYoCwhh9XI0Wx7OT1j7h5tzu1nDLnfrcVGs59wzoieuTGm3LktdBYVXrdEgM4g== X-Received: by 2002:a05:6808:14f:: with SMTP id h15mr4678051oie.119.1599952928168; Sat, 12 Sep 2020 16:22:08 -0700 (PDT) Received: from yoga ([2605:6000:e5cb:c100:8898:14ff:fe6d:34e]) by smtp.gmail.com with ESMTPSA id w14sm1000028oie.41.2020.09.12.16.22.05 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sat, 12 Sep 2020 16:22:07 -0700 (PDT) Date: Sat, 12 Sep 2020 18:22:03 -0500 From: Bjorn Andersson To: Marc Zyngier Subject: Re: [PATCH 4/6] irqchip/mtk-cirq: Allow modular build Message-ID: <20200912232203.GH3715@yoga> References: <20200912125148.1271481-1-maz@kernel.org> <20200912125148.1271481-5-maz@kernel.org> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20200912125148.1271481-5-maz@kernel.org> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20200912_192210_601318_F21322E4 X-CRM114-Status: GOOD ( 18.36 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: devicetree@vger.kernel.org, Jason Cooper , Saravana Kannan , kernel-team@android.com, Hanks Chen , linux-kernel@vger.kernel.org, Rob Herring , Matthias Brugger , Andy Gross , John Stultz , Enric Balletbo i Serra , Frank Wunderlich , Frank Rowand , Thomas Gleixner , linux-arm-kernel@lists.infradead.org Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Sat 12 Sep 07:51 CDT 2020, Marc Zyngier wrote: > Switch the driver to a "hybrid probe" model which preserves the > built-in behaviour while allowing the driver to be optionnally > built as a module for development purposes. > Reviewed-by: Bjorn Andersson > Signed-off-by: Marc Zyngier > --- > drivers/irqchip/irq-mtk-cirq.c | 4 +++- > 1 file changed, 3 insertions(+), 1 deletion(-) > > diff --git a/drivers/irqchip/irq-mtk-cirq.c b/drivers/irqchip/irq-mtk-cirq.c > index 69ba8ce3c178..43e880b63ed2 100644 > --- a/drivers/irqchip/irq-mtk-cirq.c > +++ b/drivers/irqchip/irq-mtk-cirq.c > @@ -295,4 +295,6 @@ static int __init mtk_cirq_of_init(struct device_node *node, > return ret; > } > > -IRQCHIP_DECLARE(mtk_cirq, "mediatek,mtk-cirq", mtk_cirq_of_init); > +IRQCHIP_HYBRID_DRIVER_BEGIN(mtk_cirq) > +IRQCHIP_MATCH("mediatek,mtk-cirq", mtk_cirq_of_init) > +IRQCHIP_HYBRID_DRIVER_END(mtk_cirq) > -- > 2.28.0 > _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel