From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-9.8 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH, MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id C139CC433E2 for ; Sat, 12 Sep 2020 23:22:39 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 8DEA6217A0 for ; Sat, 12 Sep 2020 23:22:39 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="JAXzNNoa" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1725950AbgILXWi (ORCPT ); Sat, 12 Sep 2020 19:22:38 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:45880 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1725904AbgILXWd (ORCPT ); Sat, 12 Sep 2020 19:22:33 -0400 Received: from mail-ot1-x342.google.com (mail-ot1-x342.google.com [IPv6:2607:f8b0:4864:20::342]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id C805FC061573 for ; Sat, 12 Sep 2020 16:22:32 -0700 (PDT) Received: by mail-ot1-x342.google.com with SMTP id o8so3876433otl.4 for ; Sat, 12 Sep 2020 16:22:32 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to; bh=aREu7IoGf48piw+KAC6LJw9YBjm0H1wUXbsHOBWfqAI=; b=JAXzNNoa7etdTGwo6+TqUO1Ws/CpDHFVQHf1iiSgH+Brb3fM/o8kM2YDWEDlux/7oK o641aurGR2Dr3YBintlZS5kRjFIzhrNuCIJ57gZP777NV1YrHbB0P2z142Ng3K8jQ0bL Dt0nfg3z7xKlyIiUgyHoDFN8U5PzdNFLugHKkVQtF9hCoOxsG0zPCe95hxtCTMFH7wZa UxZo8lHxHrZecmZDyRjVx64t2kKeBrpkIqMyWdYkt8sMOHt2G/xylStqq8fvW84l/A2S BuGo2sjzWjADtM90uQ89ULjAUKXouGm8z8PrSQHsA9T4Iv8Op/d0uPNBCsESjWcanr1M uoeQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=aREu7IoGf48piw+KAC6LJw9YBjm0H1wUXbsHOBWfqAI=; b=jioWvRrqohc7PHbLCFaUr3ZfxOLAoGYpKL3aD+xVgnH/hOedrww8gWk1dZP0fM1/oC GlqoaCYBJEtOc6KP762oRxDNbxY4YFm1FG5pPWA5XyGQBRyAkWg0LjuiOkca4MJ0Ntmb TBuaVv1OyDlvIDdBhX2CyM7KKL7Zv115gklPIsu6MlzaG35UIWkbODccvmsOF7/v6JlC z3VRjlf9eAJ7ijC8Mn8exCKnfcCplDDidbz81kScoldZcynOpO82GGvRt+HQGcc1lQEi y9s4/jfvHK4GuTDNJJRogzrdExMswyNnCol88QSrQwcQZvwsuqcP86MzzQecG2nskKqI /FDA== X-Gm-Message-State: AOAM532Bgobmrvb+5Ln4GC3H5VEhrTnInOf9Eq0BJ8neU3QTAh8zGJv4 jMOQFo6VHyyghXTREaqQuNJdJg== X-Google-Smtp-Source: ABdhPJwrzTXwGcHEh+V2vk0qTGrm7hOLM9p0O72DoCOhg4kHP0vMbM68pUI73Ww9XO3p7yGyZXf0FQ== X-Received: by 2002:a05:6830:124d:: with SMTP id s13mr5057471otp.12.1599952951969; Sat, 12 Sep 2020 16:22:31 -0700 (PDT) Received: from yoga ([2605:6000:e5cb:c100:8898:14ff:fe6d:34e]) by smtp.gmail.com with ESMTPSA id a6sm1027181otf.51.2020.09.12.16.22.30 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sat, 12 Sep 2020 16:22:31 -0700 (PDT) Date: Sat, 12 Sep 2020 18:22:28 -0500 From: Bjorn Andersson To: Marc Zyngier Cc: devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, Enric Balletbo i Serra , Frank Wunderlich , John Stultz , Saravana Kannan , Hanks Chen , Andy Gross , Matthias Brugger , Thomas Gleixner , Jason Cooper , Rob Herring , Frank Rowand , kernel-team@android.com Subject: Re: [PATCH 5/6] irqchip/mtk-sysirq: Allow modular build Message-ID: <20200912232228.GI3715@yoga> References: <20200912125148.1271481-1-maz@kernel.org> <20200912125148.1271481-6-maz@kernel.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20200912125148.1271481-6-maz@kernel.org> Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Sat 12 Sep 07:51 CDT 2020, Marc Zyngier wrote: > Switch the driver to a "hybrid probe" model which preserves the > built-in behaviour while allowing the driver to be optionnally > built as a module for development purposes. > Reviewed-by: Bjorn Andersson > Signed-off-by: Marc Zyngier > --- > drivers/irqchip/irq-mtk-sysirq.c | 4 +++- > 1 file changed, 3 insertions(+), 1 deletion(-) > > diff --git a/drivers/irqchip/irq-mtk-sysirq.c b/drivers/irqchip/irq-mtk-sysirq.c > index 6ff98b87e5c0..ee45d8f71ec3 100644 > --- a/drivers/irqchip/irq-mtk-sysirq.c > +++ b/drivers/irqchip/irq-mtk-sysirq.c > @@ -231,4 +231,6 @@ static int __init mtk_sysirq_of_init(struct device_node *node, > kfree(chip_data); > return ret; > } > -IRQCHIP_DECLARE(mtk_sysirq, "mediatek,mt6577-sysirq", mtk_sysirq_of_init); > +IRQCHIP_HYBRID_DRIVER_BEGIN(mtk_sysirq) > +IRQCHIP_MATCH("mediatek,mt6577-sysirq", mtk_sysirq_of_init) > +IRQCHIP_HYBRID_DRIVER_END(mtk_sysirq) > -- > 2.28.0 > From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-9.8 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH, MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id DEDE8C43461 for ; Sat, 12 Sep 2020 23:23:42 +0000 (UTC) Received: from merlin.infradead.org (merlin.infradead.org [205.233.59.134]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 91AC121531 for ; Sat, 12 Sep 2020 23:23:42 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="V+3VOo0R"; dkim=fail reason="signature verification failed" (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="JAXzNNoa" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 91AC121531 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=linaro.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=merlin.20170209; h=Sender:Content-Transfer-Encoding: Content-Type:Cc:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References:Message-ID: Subject:To:From:Date:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=0mzYiggwG0U8jtLuE2pE6oRHZ1v7MwaRxT/n+7tpRjQ=; b=V+3VOo0RyBER0MdwV29yYfXra 1drGyrt0pyBUmD5tfYIefiS4AWUs0/a0VYbQc9+IrOv9TvST5orJ3tMxD8I3YfHTWqXwFMcnMaGnE 7DlC+sKeYjs1UDKWGE/6ra9bGBTxVhnDdu8dne7hRf7RPuoespjGQO2pu1runTCyBtJ4550MUrvkv qA2ySjXs+cTH2MrXNYiehbrR22z3hdP6+eJnI+Trewq63WZKM3LsOh88IfMHWgOiMS7JH3ThC+Gbr mwTJzWBf9mhJvLT1WjqPihvCl6R5QZlvv47WJC6GFipJRoKVQ+QP3NHBvlYgVzYLfQisDpNSyvavl oEDjn9Klg==; Received: from localhost ([::1] helo=merlin.infradead.org) by merlin.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1kHEqr-0004Yw-41; Sat, 12 Sep 2020 23:22:37 +0000 Received: from mail-ot1-x341.google.com ([2607:f8b0:4864:20::341]) by merlin.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1kHEqn-0004XR-VA for linux-arm-kernel@lists.infradead.org; Sat, 12 Sep 2020 23:22:34 +0000 Received: by mail-ot1-x341.google.com with SMTP id o6so11593966ota.2 for ; Sat, 12 Sep 2020 16:22:33 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to; bh=aREu7IoGf48piw+KAC6LJw9YBjm0H1wUXbsHOBWfqAI=; b=JAXzNNoa7etdTGwo6+TqUO1Ws/CpDHFVQHf1iiSgH+Brb3fM/o8kM2YDWEDlux/7oK o641aurGR2Dr3YBintlZS5kRjFIzhrNuCIJ57gZP777NV1YrHbB0P2z142Ng3K8jQ0bL Dt0nfg3z7xKlyIiUgyHoDFN8U5PzdNFLugHKkVQtF9hCoOxsG0zPCe95hxtCTMFH7wZa UxZo8lHxHrZecmZDyRjVx64t2kKeBrpkIqMyWdYkt8sMOHt2G/xylStqq8fvW84l/A2S BuGo2sjzWjADtM90uQ89ULjAUKXouGm8z8PrSQHsA9T4Iv8Op/d0uPNBCsESjWcanr1M uoeQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=aREu7IoGf48piw+KAC6LJw9YBjm0H1wUXbsHOBWfqAI=; b=hpyHAI+o9SvGhKJD6/U1uKR0ssvpwCt8WGj3DvXaX4hKp/HBqkyUO4Z5huJCptRx4F kT62tzFF0n3annZRSgHsrK5FqI57awuo25T7LX2w/6gtaNRhLp5j1lSmvKGnTl9UJyrf B1Esk5cOtbOOQc0XK4PCaKUmTrF0jg3grp/RH+zLA3sgjR6DEIW0SSPxyu9c3JwgfDnr if/i1083rMIYkurMq3c3tFmQVvAIaHT6YZ6PzMPozFKo2+uWxjo7lqw9hk9j3XICKJsF i17YCJi5Bntl7TRsf8NfvoNrX0ynfhQNs9sck7bxPd4XlfkiPdljzlL0H/2/QgXsyj4W tS1w== X-Gm-Message-State: AOAM530hF8Jlvy78Rae02qS6WQ6Xm3uYoWzduxNfWMXTbKw5ac+e5Fdj 4fz22ePiqE3hF/GqmzHOV6zswQ== X-Google-Smtp-Source: ABdhPJwrzTXwGcHEh+V2vk0qTGrm7hOLM9p0O72DoCOhg4kHP0vMbM68pUI73Ww9XO3p7yGyZXf0FQ== X-Received: by 2002:a05:6830:124d:: with SMTP id s13mr5057471otp.12.1599952951969; Sat, 12 Sep 2020 16:22:31 -0700 (PDT) Received: from yoga ([2605:6000:e5cb:c100:8898:14ff:fe6d:34e]) by smtp.gmail.com with ESMTPSA id a6sm1027181otf.51.2020.09.12.16.22.30 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sat, 12 Sep 2020 16:22:31 -0700 (PDT) Date: Sat, 12 Sep 2020 18:22:28 -0500 From: Bjorn Andersson To: Marc Zyngier Subject: Re: [PATCH 5/6] irqchip/mtk-sysirq: Allow modular build Message-ID: <20200912232228.GI3715@yoga> References: <20200912125148.1271481-1-maz@kernel.org> <20200912125148.1271481-6-maz@kernel.org> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20200912125148.1271481-6-maz@kernel.org> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20200912_192234_023777_061C0FE8 X-CRM114-Status: GOOD ( 18.38 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: devicetree@vger.kernel.org, Jason Cooper , Saravana Kannan , kernel-team@android.com, Hanks Chen , linux-kernel@vger.kernel.org, Rob Herring , Matthias Brugger , Andy Gross , John Stultz , Enric Balletbo i Serra , Frank Wunderlich , Frank Rowand , Thomas Gleixner , linux-arm-kernel@lists.infradead.org Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Sat 12 Sep 07:51 CDT 2020, Marc Zyngier wrote: > Switch the driver to a "hybrid probe" model which preserves the > built-in behaviour while allowing the driver to be optionnally > built as a module for development purposes. > Reviewed-by: Bjorn Andersson > Signed-off-by: Marc Zyngier > --- > drivers/irqchip/irq-mtk-sysirq.c | 4 +++- > 1 file changed, 3 insertions(+), 1 deletion(-) > > diff --git a/drivers/irqchip/irq-mtk-sysirq.c b/drivers/irqchip/irq-mtk-sysirq.c > index 6ff98b87e5c0..ee45d8f71ec3 100644 > --- a/drivers/irqchip/irq-mtk-sysirq.c > +++ b/drivers/irqchip/irq-mtk-sysirq.c > @@ -231,4 +231,6 @@ static int __init mtk_sysirq_of_init(struct device_node *node, > kfree(chip_data); > return ret; > } > -IRQCHIP_DECLARE(mtk_sysirq, "mediatek,mt6577-sysirq", mtk_sysirq_of_init); > +IRQCHIP_HYBRID_DRIVER_BEGIN(mtk_sysirq) > +IRQCHIP_MATCH("mediatek,mt6577-sysirq", mtk_sysirq_of_init) > +IRQCHIP_HYBRID_DRIVER_END(mtk_sysirq) > -- > 2.28.0 > _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel