From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-3.8 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 5D439C43461 for ; Sun, 13 Sep 2020 21:25:31 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 2DE4C20770 for ; Sun, 13 Sep 2020 21:25:31 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1725974AbgIMVZ1 (ORCPT ); Sun, 13 Sep 2020 17:25:27 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:49864 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1725939AbgIMVZZ (ORCPT ); Sun, 13 Sep 2020 17:25:25 -0400 Received: from shards.monkeyblade.net (shards.monkeyblade.net [IPv6:2620:137:e000::1:9]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 4F082C06174A; Sun, 13 Sep 2020 14:25:25 -0700 (PDT) Received: from localhost (unknown [IPv6:2601:601:9f00:477::3d5]) (using TLSv1 with cipher AES256-SHA (256/256 bits)) (Client did not present a certificate) (Authenticated sender: davem-davemloft) by shards.monkeyblade.net (Postfix) with ESMTPSA id A8B51127FC36C; Sun, 13 Sep 2020 14:08:36 -0700 (PDT) Date: Sun, 13 Sep 2020 14:25:22 -0700 (PDT) Message-Id: <20200913.142522.1753407855743748880.davem@davemloft.net> To: anant.thazhemadam@gmail.com Cc: greg@kroah.com, netdev@vger.kernel.org, linux-kernel@vger.kernel.org, kuba@kernel.org, syzbot+09a5d591c1f98cf5efcb@syzkaller.appspotmail.com, linux-kernel-mentees@lists.linuxfoundation.org Subject: Re: [Linux-kernel-mentees] [PATCH] net: fix uninit value error in __sys_sendmmsg From: David Miller In-Reply-To: <89526337-9657-8f4d-3022-9f2ad830fbe9@gmail.com> References: <20200913055639.15639-1-anant.thazhemadam@gmail.com> <20200913061351.GA585618@kroah.com> <89526337-9657-8f4d-3022-9f2ad830fbe9@gmail.com> X-Mailer: Mew version 6.8 on Emacs 27.1 Mime-Version: 1.0 Content-Type: Text/Plain; charset=us-ascii Content-Transfer-Encoding: 7bit X-Greylist: Sender succeeded SMTP AUTH, not delayed by milter-greylist-4.5.12 (shards.monkeyblade.net [2620:137:e000::1:9]); Sun, 13 Sep 2020 14:08:36 -0700 (PDT) Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Anant Thazhemadam Date: Sun, 13 Sep 2020 11:50:52 +0530 > My apologies. I think I ended up overlooking the build warning. You "think" you overlooked the build warning? You don't actually know? If you aren't willing to even make sure the build is clean after your changes, why should we be willing to review and integrate your changes? This kind of carelessness costs other developers their valuable time, please treat it with more respect than you have. Thank you. From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-3.8 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS, URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id B4DC2C43461 for ; Sun, 13 Sep 2020 21:25:29 +0000 (UTC) Received: from fraxinus.osuosl.org (smtp4.osuosl.org [140.211.166.137]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 1F412221EF for ; Sun, 13 Sep 2020 21:25:28 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 1F412221EF Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=davemloft.net Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=linux-kernel-mentees-bounces@lists.linuxfoundation.org Received: from localhost (localhost [127.0.0.1]) by fraxinus.osuosl.org (Postfix) with ESMTP id CB78085C5C; Sun, 13 Sep 2020 21:25:28 +0000 (UTC) X-Virus-Scanned: amavisd-new at osuosl.org Received: from fraxinus.osuosl.org ([127.0.0.1]) by localhost (.osuosl.org [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id M-6hXCnWhp3w; Sun, 13 Sep 2020 21:25:28 +0000 (UTC) Received: from lists.linuxfoundation.org (lf-lists.osuosl.org [140.211.9.56]) by fraxinus.osuosl.org (Postfix) with ESMTP id 2DCFB857B0; Sun, 13 Sep 2020 21:25:28 +0000 (UTC) Received: from lf-lists.osuosl.org (localhost [127.0.0.1]) by lists.linuxfoundation.org (Postfix) with ESMTP id 13192C0859; Sun, 13 Sep 2020 21:25:28 +0000 (UTC) Received: from whitealder.osuosl.org (smtp1.osuosl.org [140.211.166.138]) by lists.linuxfoundation.org (Postfix) with ESMTP id 510B3C0051 for ; Sun, 13 Sep 2020 21:25:27 +0000 (UTC) Received: from localhost (localhost [127.0.0.1]) by whitealder.osuosl.org (Postfix) with ESMTP id 3F90C8686A for ; Sun, 13 Sep 2020 21:25:27 +0000 (UTC) X-Virus-Scanned: amavisd-new at osuosl.org Received: from whitealder.osuosl.org ([127.0.0.1]) by localhost (.osuosl.org [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id b3z4v1Ip+PyT for ; Sun, 13 Sep 2020 21:25:26 +0000 (UTC) X-Greylist: from auto-whitelisted by SQLgrey-1.7.6 Received: from shards.monkeyblade.net (shards.monkeyblade.net [23.128.96.9]) by whitealder.osuosl.org (Postfix) with ESMTPS id 8ECB486851 for ; Sun, 13 Sep 2020 21:25:26 +0000 (UTC) Received: from localhost (unknown [IPv6:2601:601:9f00:477::3d5]) (using TLSv1 with cipher AES256-SHA (256/256 bits)) (Client did not present a certificate) (Authenticated sender: davem-davemloft) by shards.monkeyblade.net (Postfix) with ESMTPSA id A8B51127FC36C; Sun, 13 Sep 2020 14:08:36 -0700 (PDT) Date: Sun, 13 Sep 2020 14:25:22 -0700 (PDT) Message-Id: <20200913.142522.1753407855743748880.davem@davemloft.net> To: anant.thazhemadam@gmail.com From: David Miller In-Reply-To: <89526337-9657-8f4d-3022-9f2ad830fbe9@gmail.com> References: <20200913055639.15639-1-anant.thazhemadam@gmail.com> <20200913061351.GA585618@kroah.com> <89526337-9657-8f4d-3022-9f2ad830fbe9@gmail.com> X-Mailer: Mew version 6.8 on Emacs 27.1 Mime-Version: 1.0 X-Greylist: Sender succeeded SMTP AUTH, not delayed by milter-greylist-4.5.12 (shards.monkeyblade.net [2620:137:e000::1:9]); Sun, 13 Sep 2020 14:08:36 -0700 (PDT) Cc: greg@kroah.com, linux-kernel@vger.kernel.org, syzbot+09a5d591c1f98cf5efcb@syzkaller.appspotmail.com, netdev@vger.kernel.org, kuba@kernel.org, linux-kernel-mentees@lists.linuxfoundation.org Subject: Re: [Linux-kernel-mentees] [PATCH] net: fix uninit value error in __sys_sendmmsg X-BeenThere: linux-kernel-mentees@lists.linuxfoundation.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: linux-kernel-mentees-bounces@lists.linuxfoundation.org Sender: "Linux-kernel-mentees" From: Anant Thazhemadam Date: Sun, 13 Sep 2020 11:50:52 +0530 > My apologies. I think I ended up overlooking the build warning. You "think" you overlooked the build warning? You don't actually know? If you aren't willing to even make sure the build is clean after your changes, why should we be willing to review and integrate your changes? This kind of carelessness costs other developers their valuable time, please treat it with more respect than you have. Thank you. _______________________________________________ Linux-kernel-mentees mailing list Linux-kernel-mentees@lists.linuxfoundation.org https://lists.linuxfoundation.org/mailman/listinfo/linux-kernel-mentees