From: Damien Le Moal <damien.lemoal@wdc.com>
To: linux-scsi@vger.kernel.org,
"Martin K . Petersen" <martin.petersen@oracle.com>,
Borislav Petkov <bp@alien8.de>
Cc: linux-block@vger.kernel.org, Jens Axboe <axboe@kernel.dk>,
Johannes Thumshirn <johannes.thumshirn@wdc.com>
Subject: [PATCH 0/2] Fix handling of host-aware ZBC disks
Date: Sun, 13 Sep 2020 15:03:02 +0900 [thread overview]
Message-ID: <20200913060304.294898-1-damien.lemoal@wdc.com> (raw)
Martin,
Two patches for this cycle (with a cc stable) to fix handling of
host-aware ZBC disks that have partitions, that is, used as regular
disks.
The first patch fixes host-aware disk initialization and command
completion processing. It also enables the use of host-aware disks as
regular disks when CONFIG_BLK_DEV_ZONED is disabled.
The second patch fixes the CONFIG_BLK_DEV_ZONED enabled configuration
so that zone append emulation is not initialized for host-aware disks
with partitions/used as regular disks. While at it, this patch also
removes a problem with sd_zbc_init_disk() error handling in
sd_revalidate_disk() by moving this function execution inside
sd_zbc_revalidate_zones().
Boris,
I tested all this. I could recreate the hang you are seeing with
CONFIG_BLK_DEV_ZONED disabled. The cause for this hang was that
good_bytes always ended up being 0 for all IOs to the host-aware disk.
The fix for this is in the first patch.
If you could test this (on top of 5.9-rc), it would be great. Thanks !
Damien Le Moal (2):
scsi: Fix handling of host-aware ZBC disks
scsi: Fix ZBC disk initialization
drivers/scsi/sd.c | 26 +++++++++++------
drivers/scsi/sd.h | 8 +-----
drivers/scsi/sd_zbc.c | 66 ++++++++++++++++++++++++++-----------------
3 files changed, 59 insertions(+), 41 deletions(-)
--
2.26.2
next reply other threads:[~2020-09-13 6:03 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-09-13 6:03 Damien Le Moal [this message]
2020-09-13 6:03 ` [PATCH 1/2] scsi: Fix handling of host-aware ZBC disks Damien Le Moal
2020-09-13 7:05 ` Borislav Petkov
2020-09-13 8:03 ` Johannes Thumshirn
2020-09-13 6:03 ` [PATCH 2/2] scsi: Fix ZBC disk initialization Damien Le Moal
2020-09-13 8:05 ` Johannes Thumshirn
2020-09-13 7:05 ` [PATCH 0/2] Fix handling of host-aware ZBC disks Borislav Petkov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200913060304.294898-1-damien.lemoal@wdc.com \
--to=damien.lemoal@wdc.com \
--cc=axboe@kernel.dk \
--cc=bp@alien8.de \
--cc=johannes.thumshirn@wdc.com \
--cc=linux-block@vger.kernel.org \
--cc=linux-scsi@vger.kernel.org \
--cc=martin.petersen@oracle.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.