From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-6.6 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE, SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id D75A2C43461 for ; Sun, 13 Sep 2020 17:00:09 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 995B8207EA for ; Sun, 13 Sep 2020 17:00:09 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="Cq2i5Du9" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1725965AbgIMRAI (ORCPT ); Sun, 13 Sep 2020 13:00:08 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:37572 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1725876AbgIMRAA (ORCPT ); Sun, 13 Sep 2020 13:00:00 -0400 Received: from mail-pg1-x542.google.com (mail-pg1-x542.google.com [IPv6:2607:f8b0:4864:20::542]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id BF83EC06174A; Sun, 13 Sep 2020 09:59:59 -0700 (PDT) Received: by mail-pg1-x542.google.com with SMTP id l191so9599751pgd.5; Sun, 13 Sep 2020 09:59:59 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to; bh=Omc5GUviZXmY9Fz9BCq4ZAvwSSBNWz0aHFjh7JiCaqY=; b=Cq2i5Du97qqZ9zymjDh//gocDk6OuGx4PmVS3Xx72RkkIF08zJzcdSB8CQ46x7/Uqq Ptidw2bGkNuKFvkBDhwuhJQ29+9mwuhGmw65W1jMa022tWLkCqZUtOhd7qB9IipVgIl8 49BSGyKnPgUsu/iSpU5dR3TRfK5kNTkuYDjPGkNw1dcgdSFPGhjEeNHclnvicgz57MUN 2IAlSqknJwKkUc+oh3deU2H4h1QImvn14jwvKz1gyP1C2oc1fudWqHc3FYzVcOB5dd1O Z24zAsZef7oOKuwpLcCN6i0T86OvaYh3r5Xk2WYoA02WxQNimvtltr5lAqM5Fw7WLSC1 CZjw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=Omc5GUviZXmY9Fz9BCq4ZAvwSSBNWz0aHFjh7JiCaqY=; b=pO1QGTokn9fP6nzvZsKiomD3MN3rhihWCXXceBbESWS1w+Vdx8Zr2ECrdDd2Dxg5TA sugMQUdS7XIbLG4NhF6ouPuZFnV7RTbhHJvkbSNUg9qhH72yFtvt4Jv+dVnhgtPHPjVe yz3FMoP3rAxzGY7UArfynxdyNJwX6ljgcbtPiW3wnllg9LmU14bECjpyQqBBJm8SMs6x rUMHP6OfA4Tt9IhE1uYJ4ISjaC5oclKT8aD2j2gqw+d6QpkwoBg3Mxpzam16xdNsjExo 3dk1ncg9XqfjS1II1pkIe+vRMhwHYQ/c8QO+SGFXeoxTuZiyeCeKVKl4cm9P0sEXm0kQ VtzQ== X-Gm-Message-State: AOAM5320kHECuhHHqveq/WaydNMxR8gCwGOX4N48vAdb/V/TKCYPDHY8 xm9DloufAHxi9VthI2vRDDY= X-Google-Smtp-Source: ABdhPJz+4c4MuctOfAwI2G1i7KUosHfkY0WgLJ1iZnpv35csZu+oFytF/ciXTmIJ67rs3/q2wvjzDA== X-Received: by 2002:a63:a05:: with SMTP id 5mr4091629pgk.140.1600016399059; Sun, 13 Sep 2020 09:59:59 -0700 (PDT) Received: from dtor-ws ([2620:15c:202:201:a6ae:11ff:fe11:fcc3]) by smtp.gmail.com with ESMTPSA id s8sm221929pjn.10.2020.09.13.09.59.57 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sun, 13 Sep 2020 09:59:58 -0700 (PDT) Date: Sun, 13 Sep 2020 09:59:56 -0700 From: Dmitry Torokhov To: Michael Kelley Cc: Boqun Feng , "linux-hyperv@vger.kernel.org" , "linux-input@vger.kernel.org" , "linux-kernel@vger.kernel.org" , "netdev@vger.kernel.org" , "linux-scsi@vger.kernel.org" , "linux-arm-kernel@lists.infradead.org" , KY Srinivasan , Haiyang Zhang , Stephen Hemminger , Wei Liu , Jiri Kosina , Benjamin Tissoires , "David S. Miller" , Jakub Kicinski , "James E.J. Bottomley" , "Martin K. Petersen" , "will@kernel.org" , "ardb@kernel.org" , "arnd@arndb.de" , "catalin.marinas@arm.com" , "Mark.Rutland@arm.com" , "maz@kernel.org" Subject: Re: [PATCH v3 08/11] Input: hyperv-keyboard: Make ringbuffer at least take two pages Message-ID: <20200913165956.GG1665100@dtor-ws> References: <20200910143455.109293-1-boqun.feng@gmail.com> <20200910143455.109293-9-boqun.feng@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Sat, Sep 12, 2020 at 07:37:23PM +0000, Michael Kelley wrote: > From: Boqun Feng Sent: Thursday, September 10, 2020 7:35 AM > > > > > When PAGE_SIZE > HV_HYP_PAGE_SIZE, we need the ringbuffer size to be at > > least 2 * PAGE_SIZE: one page for the header and at least one page of > > the data part (because of the alignment requirement for double mapping). > > > > So make sure the ringbuffer sizes to be at least 2 * PAGE_SIZE when > > using vmbus_open() to establish the vmbus connection. > > > > Signed-off-by: Boqun Feng > > --- > > drivers/input/serio/hyperv-keyboard.c | 4 ++-- > > 1 file changed, 2 insertions(+), 2 deletions(-) > > > > Reviewed-by: Michael Kelley Acked-by: Dmitry Torokhov Please feel free to merge with the rest of the patches through whatever tree they will go in. Thanks. -- Dmitry From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-6.5 required=3.0 tests=BAYES_00,DKIM_ADSP_CUSTOM_MED, DKIM_SIGNED,DKIM_VALID,FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE, SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 24534C433E2 for ; Sun, 13 Sep 2020 17:01:57 +0000 (UTC) Received: from merlin.infradead.org (merlin.infradead.org [205.233.59.134]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id A38D9207C3 for ; Sun, 13 Sep 2020 17:01:56 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="QJx6vUCr"; dkim=fail reason="signature verification failed" (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="Cq2i5Du9" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org A38D9207C3 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=gmail.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=merlin.20170209; h=Sender:Content-Transfer-Encoding: Content-Type:Cc:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References:Message-ID: Subject:To:From:Date:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=+4E1SaYF3VHRKQI8nakAoaC86wR0CUhJapQokbFuA/Q=; b=QJx6vUCrZ4Ogjqo1X0LyaJypJ QbeZhxd8R9jIuw8VLaYJn9RDImNj+d1Z6VEWgFyOJD1ZQCpNCbwEcurl7eEcYq7gTehWUFrHXcWzU 4pxccInbjjF2uj2a+OMmFz6uz9/9gBQguIkb0tFwvKmWVVnACRQBmU1sd8rlqQg/t/6+NOJ1qfArS CB8UIeSoxxDPgR5IXRxiBXaOxAzjo+Get6PjgVI26/x1srUr/SZZO4kIStRLDvzTBzFRuJsErXB9q sCwSF9v+u2lGR+SryrwLLE8gAbjtfm5z9zHMPaH6v+2BnXXpcWLXEMcJWJYKKhYAEpE5G2bXk+XBx ZZg+pde0A==; Received: from localhost ([::1] helo=merlin.infradead.org) by merlin.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1kHVMC-0001l9-IT; Sun, 13 Sep 2020 17:00:04 +0000 Received: from mail-pg1-x541.google.com ([2607:f8b0:4864:20::541]) by merlin.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1kHVMA-0001jy-NX for linux-arm-kernel@lists.infradead.org; Sun, 13 Sep 2020 17:00:03 +0000 Received: by mail-pg1-x541.google.com with SMTP id f2so7581303pgd.3 for ; Sun, 13 Sep 2020 10:00:00 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to; bh=Omc5GUviZXmY9Fz9BCq4ZAvwSSBNWz0aHFjh7JiCaqY=; b=Cq2i5Du97qqZ9zymjDh//gocDk6OuGx4PmVS3Xx72RkkIF08zJzcdSB8CQ46x7/Uqq Ptidw2bGkNuKFvkBDhwuhJQ29+9mwuhGmw65W1jMa022tWLkCqZUtOhd7qB9IipVgIl8 49BSGyKnPgUsu/iSpU5dR3TRfK5kNTkuYDjPGkNw1dcgdSFPGhjEeNHclnvicgz57MUN 2IAlSqknJwKkUc+oh3deU2H4h1QImvn14jwvKz1gyP1C2oc1fudWqHc3FYzVcOB5dd1O Z24zAsZef7oOKuwpLcCN6i0T86OvaYh3r5Xk2WYoA02WxQNimvtltr5lAqM5Fw7WLSC1 CZjw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=Omc5GUviZXmY9Fz9BCq4ZAvwSSBNWz0aHFjh7JiCaqY=; b=k5Gx3v/0vXAyMjN5Y80H0OXgPow5PZGoPJD/ZQPUNyrRa4C+aIfkzJk3QCt1m9KYL6 OKxQTjWPIp0JgBRJQS7lMa568jqOWFbVvS54mhVxpSk1fRaRBMcaZpUxg253VExvkTkH XKoMdf4Az1wUJ4ieQW1K3C2bJpomOj0Pd3LpeuW1sSXnOXuB7QjNxOBCuVVvH540pO/K B7DKod1cgCun28myrQqtkwHwPTkO/T/N+qGQZTQrL8w6EjL5ZVwHj95V+w4YaxUObgJ2 F/+sV/iSqKoiPD1IidbrOYkq3b1y7plkP6I08dcQeM+2d0VoNXpBy584axgVpIigPNZy /5GQ== X-Gm-Message-State: AOAM532RzyKYwoYVP99cez43nSc1neEhGi+eWsQEYu9KH1Vmv54HJvu0 Ve8PHoIxxkbYp3XFMgXN18Y= X-Google-Smtp-Source: ABdhPJz+4c4MuctOfAwI2G1i7KUosHfkY0WgLJ1iZnpv35csZu+oFytF/ciXTmIJ67rs3/q2wvjzDA== X-Received: by 2002:a63:a05:: with SMTP id 5mr4091629pgk.140.1600016399059; Sun, 13 Sep 2020 09:59:59 -0700 (PDT) Received: from dtor-ws ([2620:15c:202:201:a6ae:11ff:fe11:fcc3]) by smtp.gmail.com with ESMTPSA id s8sm221929pjn.10.2020.09.13.09.59.57 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sun, 13 Sep 2020 09:59:58 -0700 (PDT) Date: Sun, 13 Sep 2020 09:59:56 -0700 From: Dmitry Torokhov To: Michael Kelley Subject: Re: [PATCH v3 08/11] Input: hyperv-keyboard: Make ringbuffer at least take two pages Message-ID: <20200913165956.GG1665100@dtor-ws> References: <20200910143455.109293-1-boqun.feng@gmail.com> <20200910143455.109293-9-boqun.feng@gmail.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20200913_130002_802638_6A52F38C X-CRM114-Status: GOOD ( 16.43 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: "Mark.Rutland@arm.com" , "linux-hyperv@vger.kernel.org" , "catalin.marinas@arm.com" , Benjamin Tissoires , KY Srinivasan , "will@kernel.org" , "ardb@kernel.org" , Wei Liu , Stephen Hemminger , "linux-scsi@vger.kernel.org" , "maz@kernel.org" , "linux-input@vger.kernel.org" , Jakub Kicinski , "James E.J. Bottomley" , "arnd@arndb.de" , Boqun Feng , Jiri Kosina , "linux-arm-kernel@lists.infradead.org" , "Martin K. Petersen" , "netdev@vger.kernel.org" , Haiyang Zhang , "linux-kernel@vger.kernel.org" , "David S. Miller" Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Sat, Sep 12, 2020 at 07:37:23PM +0000, Michael Kelley wrote: > From: Boqun Feng Sent: Thursday, September 10, 2020 7:35 AM > > > > > When PAGE_SIZE > HV_HYP_PAGE_SIZE, we need the ringbuffer size to be at > > least 2 * PAGE_SIZE: one page for the header and at least one page of > > the data part (because of the alignment requirement for double mapping). > > > > So make sure the ringbuffer sizes to be at least 2 * PAGE_SIZE when > > using vmbus_open() to establish the vmbus connection. > > > > Signed-off-by: Boqun Feng > > --- > > drivers/input/serio/hyperv-keyboard.c | 4 ++-- > > 1 file changed, 2 insertions(+), 2 deletions(-) > > > > Reviewed-by: Michael Kelley Acked-by: Dmitry Torokhov Please feel free to merge with the rest of the patches through whatever tree they will go in. Thanks. -- Dmitry _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel