All of lore.kernel.org
 help / color / mirror / Atom feed
From: Thomas Petazzoni <thomas.petazzoni@bootlin.com>
To: buildroot@busybox.net
Subject: [Buildroot] [PATCH 1/1] package/libcap: needs MMU
Date: Sun, 13 Sep 2020 21:57:59 +0200	[thread overview]
Message-ID: <20200913215759.52b621f5@windsurf.home> (raw)
In-Reply-To: <20200913165048.2685092-1-fontaine.fabrice@gmail.com>

On Sun, 13 Sep 2020 18:50:48 +0200
Fabrice Fontaine <fontaine.fabrice@gmail.com> wrote:

> libcap uses fork() since version 2.33 and
> https://git.kernel.org/pub/scm/linux/kernel/git/morgan/libcap.git/commit/?id=ef485973d5547431782f9e5f4323eabfebb38622
> 
> So add MMU dependency to avoid the following build failure on
> applications using libcap without MMU such as ntp:
> 
> /tmp/instance-0/output-1/host/opt/ext-toolchain/arm-buildroot-uclinux-uclibcgnueabi/bin/ld.real: /tmp/instance-0/output-1/host/bin/../arm-buildroot-uclinux-uclibcgnueabi/sysroot/usr/lib/libcap.a(cap_proc.o): in function `cap_launch':
> /tmp/instance-0/output-1/build/libcap-2.42/libcap/cap_proc.c:912: undefined reference to `fork'
> 
> Fixes:
>  - http://autobuild.buildroot.org/results/89f39dae01c07977062b909079bfcd45a68060d3
> 
> Signed-off-by: Fabrice Fontaine <fontaine.fabrice@gmail.com>

I've applied, but after dropping the BR2_USE_MMU dependency on the
BR2_PACKAGE_LIBCAP_TOOLS option, since it was no longer needed. As
suggested by Baruch, I've added a note in the commit log to say that
all reverse dependencies of libcap already have a BR2_USE_MMU
dependency.

Thanks!

Thomas
-- 
Thomas Petazzoni, CTO, Bootlin
Embedded Linux and Kernel engineering
https://bootlin.com

      parent reply	other threads:[~2020-09-13 19:57 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-09-13 16:50 [Buildroot] [PATCH 1/1] package/libcap: needs MMU Fabrice Fontaine
2020-09-13 17:22 ` Baruch Siach
2020-09-13 19:57 ` Thomas Petazzoni [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20200913215759.52b621f5@windsurf.home \
    --to=thomas.petazzoni@bootlin.com \
    --cc=buildroot@busybox.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.