From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-3.6 required=3.0 tests=BAYES_00,DKIM_INVALID, DKIM_SIGNED,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE, SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id B59FBC433E2 for ; Mon, 14 Sep 2020 09:36:25 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 4824F2192A for ; Mon, 14 Sep 2020 09:36:25 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=fail reason="signature verification failed" (2048-bit key) header.d=infradead.org header.i=@infradead.org header.b="T9KZTDpW" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726385AbgINJgX (ORCPT ); Mon, 14 Sep 2020 05:36:23 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:48790 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726273AbgINJgR (ORCPT ); Mon, 14 Sep 2020 05:36:17 -0400 Received: from casper.infradead.org (casper.infradead.org [IPv6:2001:8b0:10b:1236::1]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 62512C06174A for ; Mon, 14 Sep 2020 02:36:17 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=casper.20170209; h=In-Reply-To:Content-Type:MIME-Version: References:Message-ID:Subject:Cc:To:From:Date:Sender:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description; bh=rFo3P/yVEyT/riHvD1+zwROozsgCZ0ZeAptyOa2H33c=; b=T9KZTDpWfoB57jBow3SI6kuA7g bd2gJINBMhS9DcpnlC24QPiXMjh4ndu42NvJvZCt0qQW4XErhdg9CxyUKOLjy0mz2Xoa7yRvtVocI VWnlXKgPGq7yoFebdCt9aM48eLlepjUVDt1ZJ8qhqPGScMD8ayI8e17U90u5LXXKxYRQjAKJKajt1 wlFk02oHJEOqi2GL4H3Mjh7ADfonFV0OYdXXepN5F4MowWEgvBTCZFKAoSA8NwRgUvnC/Gn/aCTaJ aNTJtyLD/gfv1KsENa8kbns/F1/X0QTupv5hDXi6HdHXdY03KooduRqFrjmUixb3V5hY7WC7UAMim 2+hYyHDA==; Received: from j217100.upc-j.chello.nl ([24.132.217.100] helo=noisy.programming.kicks-ass.net) by casper.infradead.org with esmtpsa (Exim 4.92.3 #3 (Red Hat Linux)) id 1kHku3-0007eb-As; Mon, 14 Sep 2020 09:36:03 +0000 Received: from hirez.programming.kicks-ass.net (hirez.programming.kicks-ass.net [192.168.1.225]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (Client did not present a certificate) by noisy.programming.kicks-ass.net (Postfix) with ESMTPS id 4FEE73012C3; Mon, 14 Sep 2020 11:36:02 +0200 (CEST) Received: by hirez.programming.kicks-ass.net (Postfix, from userid 1000) id 2D6192CA75AAC; Mon, 14 Sep 2020 11:36:02 +0200 (CEST) Date: Mon, 14 Sep 2020 11:36:02 +0200 From: peterz@infradead.org To: Jiri Olsa Cc: Arnaldo Carvalho de Melo , lkml , Ingo Molnar , Mark Rutland , Namhyung Kim , Alexander Shishkin , Michael Petlan , Song Liu , "Frank Ch. Eigler" , Ian Rogers , Stephane Eranian , Alexey Budankov , Andi Kleen , Adrian Hunter Subject: Re: [PATCH 02/26] perf: Introduce mmap3 version of mmap event Message-ID: <20200914093602.GN1362448@hirez.programming.kicks-ass.net> References: <20200913210313.1985612-1-jolsa@kernel.org> <20200913210313.1985612-3-jolsa@kernel.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20200913210313.1985612-3-jolsa@kernel.org> Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Sun, Sep 13, 2020 at 11:02:49PM +0200, Jiri Olsa wrote: > Add new version of mmap event. The MMAP3 record is an > augmented version of MMAP2, it adds build id value to > identify the exact binary object behind memory map: > > struct { > struct perf_event_header header; > > u32 pid, tid; > u64 addr; > u64 len; > u64 pgoff; > u32 maj; > u32 min; > u64 ino; > u64 ino_generation; > u32 prot, flags; > u32 reserved; > u8 buildid[20]; > char filename[]; > struct sample_id sample_id; > }; > So weren't there still open problems with mmap2 that also needed addressing? I seem to have forgotten :/