From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.9 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,MAILING_LIST_MULTI,SPF_HELO_NONE, SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 38911C43461 for ; Mon, 14 Sep 2020 16:43:08 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id DDFEF206A5 for ; Mon, 14 Sep 2020 16:43:07 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1600101787; bh=2n6xn1dNb+jBWIYWoXM59/cL0r2SN9OLGc/w/yYX4lc=; h=Date:From:To:Cc:Subject:References:In-Reply-To:List-ID:From; b=ekOuPTqlEjXHmsudViLYO4BcGtBXhp0CAqxXIqjH3hqzDZtXV25sLu/EaIUJxi8oy DHC1MR2YDD1rbU/zeUXuzlt3W4bRZAK1G3qwiQMKNJpFYH/BuV7+/3QEWjWTmmneI0 xCBXpGPQ8EGdKLRCWyGjWTsxm5iv8hVMoNCb28og= Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1725970AbgINQnE (ORCPT ); Mon, 14 Sep 2020 12:43:04 -0400 Received: from mail.kernel.org ([198.145.29.99]:32778 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726121AbgINPNN (ORCPT ); Mon, 14 Sep 2020 11:13:13 -0400 Received: from quaco.ghostprotocols.net (unknown [179.97.37.151]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 39BDB20829; Mon, 14 Sep 2020 15:13:13 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1600096393; bh=2n6xn1dNb+jBWIYWoXM59/cL0r2SN9OLGc/w/yYX4lc=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=CX21HqYOSTW7DxJJi9tuQNthrvklblenjRZ8AKtZedFGn5cnOcyTnun31WvqoZvUu vt/mlbJvtmTMtGM+Rx2kQUQeVHlUaFraOTtA7nKxTyzGlBe6INrZLXSaayWu4LpVSr Q1/eyCA5lY3hFIeaFqEteERMOwqykEL70biA9hwA= Received: by quaco.ghostprotocols.net (Postfix, from userid 1000) id 1370440D3D; Mon, 14 Sep 2020 12:13:11 -0300 (-03) Date: Mon, 14 Sep 2020 12:13:10 -0300 From: Arnaldo Carvalho de Melo To: Namhyung Kim Cc: Jiri Olsa , Alexei Starovoitov , lkml , Peter Zijlstra , Ingo Molnar , Mark Rutland , Alexander Shishkin , Michael Petlan , Song Liu , "Frank Ch. Eigler" , Ian Rogers , Stephane Eranian , Alexey Budankov , Andi Kleen , Adrian Hunter Subject: Re: [RFC 00/26] perf: Add mmap3 support Message-ID: <20200914151310.GA160517@kernel.org> References: <20200913210313.1985612-1-jolsa@kernel.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: X-Url: http://acmel.wordpress.com Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Em Mon, Sep 14, 2020 at 02:25:25PM +0900, Namhyung Kim escreveu: > On Mon, Sep 14, 2020 at 6:03 AM Jiri Olsa wrote: > > while playing with perf daemon support I realized I need > > the build id data in mmap events, so we don't need to care > > about removed/updated binaries during long perf runs. > > This RFC patchset adds new mmap3 events that copies mmap2 > > event and adds build id in it. It makes mmap3 the default > > mmap event for synthesizing kernel/modules/tasks and adds > > some tooling enhancements to enable the workflow below. > Cool! It's nice that we can skip the final build-id collection stage > with this while data size will be bigger. Yeah, this is something long overdue, comes with extra cost for people not wanting build-ids, but then they can just use MMAP2 or even MMAP if that is enough. More comments on the other patches. - Arnaldo