From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.0 required=3.0 tests=BAYES_00,DKIM_INVALID, DKIM_SIGNED,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE, SPF_PASS,URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 2571FC433E2 for ; Mon, 14 Sep 2020 16:12:28 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 93F5520EDD for ; Mon, 14 Sep 2020 16:12:27 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=fail reason="signature verification failed" (2048-bit key) header.d=armlinux.org.uk header.i=@armlinux.org.uk header.b="BrmSRTAF" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1725967AbgINQMV (ORCPT ); Mon, 14 Sep 2020 12:12:21 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:53954 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726137AbgINQMP (ORCPT ); Mon, 14 Sep 2020 12:12:15 -0400 Received: from pandora.armlinux.org.uk (pandora.armlinux.org.uk [IPv6:2001:4d48:ad52:32c8:5054:ff:fe00:142]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 8E14AC06174A for ; Mon, 14 Sep 2020 09:12:13 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=armlinux.org.uk; s=pandora-2019; h=Sender:In-Reply-To:Content-Type: MIME-Version:References:Message-ID:Subject:Cc:To:From:Date:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Id: List-Help:List-Unsubscribe:List-Subscribe:List-Post:List-Owner:List-Archive; bh=Tx2oyzwJ353auCr9j8+1rUMRZV2tvoeGzr96u2q0vNY=; b=BrmSRTAF6/oIIJ0uFAzjvCe8X agrzFTin+ApJsBXrJMakDbc6FqBJguRulw/v+NsZogKd9BM6OfcrE0zPM7YS2kqAs7w99mCSX9nqE PBgklYFd3JUhrFpoPDEfnRzolsr0x3D3+YWCnIHGOCO55v60zEkcAZTAJayGXZ2RgVSfPOjaecORs Caol/k97AAIreXTzl77OnKk0VJ7/d6p86SKMjb5c6DzHYWCESjtzKVozIZGtK27J7CWMQQzIx9N3G 23hUXBddrLhkhov2xejDrCuj27zGbner+64UTkJIVU5drEVAsQ3F40OpAeZGb+motzpxzx7ls05H2 O1CFuvgHw==; Received: from shell.armlinux.org.uk ([fd8f:7570:feb6:1:5054:ff:fe00:4ec]:33610) by pandora.armlinux.org.uk with esmtpsa (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1kHr59-0001lr-O0; Mon, 14 Sep 2020 17:11:55 +0100 Received: from linux by shell.armlinux.org.uk with local (Exim 4.92) (envelope-from ) id 1kHr57-0002nP-JW; Mon, 14 Sep 2020 17:11:53 +0100 Date: Mon, 14 Sep 2020 17:11:53 +0100 From: Russell King - ARM Linux admin To: Nicolas Pitre Cc: Ard Biesheuvel , linux-efi@vger.kernel.org, linux-arm-kernel@lists.infradead.org, Linus Walleij , Nick Desaulniers , Stefan Agner , Peter Smith , Marc Zyngier , Will Deacon Subject: Re: [PATCH 03/12] ARM: module: add support for place relative relocations Message-ID: <20200914161153.GM1551@shell.armlinux.org.uk> References: <20200914095706.3985-1-ardb@kernel.org> <20200914095706.3985-4-ardb@kernel.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.10.1 (2018-07-13) Sender: linux-efi-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-efi@vger.kernel.org On Mon, Sep 14, 2020 at 09:35:41AM -0400, Nicolas Pitre wrote: > On Mon, 14 Sep 2020, Ard Biesheuvel wrote: > > > When using the new adr_l/ldr_l/str_l macros to refer to external symbols > > from modules, the linker may emit place relative ELF relocations that > > need to be fixed up by the module loader. So add support for these. > > Just wondering if that capability requirement should be added to the > module signature somehow...? > > Maybe not. The MODULE_ARCH_VERMAGIC definition only contains things that > are configurable for a given build. It doesn't need to be. If a module contains a relocation we don't know how to handle, it will fail to load. -- RMK's Patch system: https://www.armlinux.org.uk/developer/patches/ FTTP is here! 40Mbps down 10Mbps up. Decent connectivity at last! From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-7.0 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 067AEC43461 for ; Mon, 14 Sep 2020 16:16:28 +0000 (UTC) Received: from merlin.infradead.org (merlin.infradead.org [205.233.59.134]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 8208621973 for ; Mon, 14 Sep 2020 16:16:27 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="xWe4o/Ul"; dkim=fail reason="signature verification failed" (2048-bit key) header.d=armlinux.org.uk header.i=@armlinux.org.uk header.b="BrmSRTAF" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 8208621973 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=armlinux.org.uk Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=merlin.20170209; h=Sender:Content-Transfer-Encoding: Content-Type:Cc:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References:Message-ID: Subject:To:From:Date:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=rcQQzWaz87VYnEmSjC7HVlFJRauXnAqaBxxlweUGY/I=; b=xWe4o/Ul6tpxuVye5jwTjEO2s xU24CyUaJqfmhOLlNONvR2FszyOVkslcNzSB50jQb72HEam6SoguEYPk/TwF5VA2NARWnaL5TbiJw YrjmIz5+HjW2sr3dFbo0x7S9f+Avc15e3Xy9opaEJHKyoH4f0eb4+p4WKtxCo0IltjgN7SsqldUth m1HEk1dR9eW1epET+Cu9Z0e9nR7NpQzc36tUGrvl/G/edmQxGudeml0nX4/0NlN/LnO6pnjC8/FYx Ql8o4zhr+OVqyxWBzX8irtzLpqHSWLsIuvU0ZstAXt15ZjYjMAq7wYKP7nJHanSh9qHta+w3X954t 6XtJ8PR7A==; Received: from localhost ([::1] helo=merlin.infradead.org) by merlin.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1kHr8I-0001db-2t; Mon, 14 Sep 2020 16:15:10 +0000 Received: from pandora.armlinux.org.uk ([2001:4d48:ad52:32c8:5054:ff:fe00:142]) by merlin.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1kHr8E-00012k-If for linux-arm-kernel@lists.infradead.org; Mon, 14 Sep 2020 16:15:08 +0000 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=armlinux.org.uk; s=pandora-2019; h=Sender:In-Reply-To:Content-Type: MIME-Version:References:Message-ID:Subject:Cc:To:From:Date:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Id: List-Help:List-Unsubscribe:List-Subscribe:List-Post:List-Owner:List-Archive; bh=Tx2oyzwJ353auCr9j8+1rUMRZV2tvoeGzr96u2q0vNY=; b=BrmSRTAF6/oIIJ0uFAzjvCe8X agrzFTin+ApJsBXrJMakDbc6FqBJguRulw/v+NsZogKd9BM6OfcrE0zPM7YS2kqAs7w99mCSX9nqE PBgklYFd3JUhrFpoPDEfnRzolsr0x3D3+YWCnIHGOCO55v60zEkcAZTAJayGXZ2RgVSfPOjaecORs Caol/k97AAIreXTzl77OnKk0VJ7/d6p86SKMjb5c6DzHYWCESjtzKVozIZGtK27J7CWMQQzIx9N3G 23hUXBddrLhkhov2xejDrCuj27zGbner+64UTkJIVU5drEVAsQ3F40OpAeZGb+motzpxzx7ls05H2 O1CFuvgHw==; Received: from shell.armlinux.org.uk ([fd8f:7570:feb6:1:5054:ff:fe00:4ec]:33610) by pandora.armlinux.org.uk with esmtpsa (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1kHr59-0001lr-O0; Mon, 14 Sep 2020 17:11:55 +0100 Received: from linux by shell.armlinux.org.uk with local (Exim 4.92) (envelope-from ) id 1kHr57-0002nP-JW; Mon, 14 Sep 2020 17:11:53 +0100 Date: Mon, 14 Sep 2020 17:11:53 +0100 From: Russell King - ARM Linux admin To: Nicolas Pitre Subject: Re: [PATCH 03/12] ARM: module: add support for place relative relocations Message-ID: <20200914161153.GM1551@shell.armlinux.org.uk> References: <20200914095706.3985-1-ardb@kernel.org> <20200914095706.3985-4-ardb@kernel.org> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.10.1 (2018-07-13) X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20200914_121506_662847_3A005DE9 X-CRM114-Status: GOOD ( 17.03 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: linux-efi@vger.kernel.org, Marc Zyngier , Linus Walleij , Nick Desaulniers , Peter Smith , Stefan Agner , Will Deacon , Ard Biesheuvel , linux-arm-kernel@lists.infradead.org Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Mon, Sep 14, 2020 at 09:35:41AM -0400, Nicolas Pitre wrote: > On Mon, 14 Sep 2020, Ard Biesheuvel wrote: > > > When using the new adr_l/ldr_l/str_l macros to refer to external symbols > > from modules, the linker may emit place relative ELF relocations that > > need to be fixed up by the module loader. So add support for these. > > Just wondering if that capability requirement should be added to the > module signature somehow...? > > Maybe not. The MODULE_ARCH_VERMAGIC definition only contains things that > are configurable for a given build. It doesn't need to be. If a module contains a relocation we don't know how to handle, it will fail to load. -- RMK's Patch system: https://www.armlinux.org.uk/developer/patches/ FTTP is here! 40Mbps down 10Mbps up. Decent connectivity at last! _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel