From: Jakub Kicinski <kuba@kernel.org>
To: "Paul E. McKenney" <paulmck@kernel.org>
Cc: Joel Fernandes <joel@joelfernandes.org>,
nikolay@cumulusnetworks.com, davem@davemloft.net,
netdev@vger.kernel.org, josh@joshtriplett.org,
peterz@infradead.org, christian.brauner@ubuntu.com,
rcu@vger.kernel.org, linux-kernel@vger.kernel.org,
sfr@canb.auug.org.au, roopa@nvidia.com
Subject: Re: [PATCH net-next] rcu: prevent RCU_LOCKDEP_WARN() from swallowing the condition
Date: Mon, 14 Sep 2020 17:30:29 -0700 [thread overview]
Message-ID: <20200914173029.60bdfc02@kicinski-fedora-pc1c0hjn.dhcp.thefacebook.com> (raw)
In-Reply-To: <20200915002011.GJ29330@paulmck-ThinkPad-P72>
On Mon, 14 Sep 2020 17:20:11 -0700 Paul E. McKenney wrote:
> > Seems like quite a few places depend on the macro disappearing its
> > argument. I was concerned that it's going to be had to pick out whether
> > !LOCKDEP builds should return true or false from LOCKDEP helpers, but
> > perhaps relying on the linker errors even more is not such poor taste?
> >
> > Does the patch below look acceptable to you?
>
> The thing to check would be whether all compilers do sufficient
> dead-code elimination (it used to be that they did not). One way to
> get a quick sniff test of this would be to make sure that a dead-code
> lockdep_is_held() is in common code, and then expose this patch to kbuild
> test robot.
I'm pretty sure it's in common code because kbuild bot complaints were
the reason I gave up the first time around ;)
I'll expose this to kbuild bot via my kernel.org tree in case it
doesn't consider scissored patches and report back!
next prev parent reply other threads:[~2020-09-15 0:30 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-09-08 3:00 linux-next: build warning after merge of the net-next tree Stephen Rothwell
2020-09-08 3:49 ` Jakub Kicinski
2020-09-08 7:17 ` [PATCH net-next] net: bridge: mcast: fix unused br var when lockdep isn't defined Nikolay Aleksandrov
2020-09-08 16:00 ` Jakub Kicinski
2020-09-08 16:09 ` nikolay
2020-09-08 17:36 ` [PATCH net-next] rcu: prevent RCU_LOCKDEP_WARN() from swallowing the condition Jakub Kicinski
2020-09-08 18:15 ` nikolay
2020-09-09 0:27 ` Jakub Kicinski
2020-09-14 20:21 ` Joel Fernandes
2020-09-14 22:47 ` Jakub Kicinski
2020-09-15 0:20 ` Paul E. McKenney
2020-09-15 0:30 ` Jakub Kicinski [this message]
2020-09-15 17:02 ` Paul E. McKenney
2020-09-15 1:34 ` Joel Fernandes
2020-09-09 3:12 ` David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200914173029.60bdfc02@kicinski-fedora-pc1c0hjn.dhcp.thefacebook.com \
--to=kuba@kernel.org \
--cc=christian.brauner@ubuntu.com \
--cc=davem@davemloft.net \
--cc=joel@joelfernandes.org \
--cc=josh@joshtriplett.org \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=nikolay@cumulusnetworks.com \
--cc=paulmck@kernel.org \
--cc=peterz@infradead.org \
--cc=rcu@vger.kernel.org \
--cc=roopa@nvidia.com \
--cc=sfr@canb.auug.org.au \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.