From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.0 required=3.0 tests=BAYES_00,DKIM_ADSP_CUSTOM_MED, DKIM_SIGNED,DKIM_VALID,FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS, URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 9B217C43461 for ; Tue, 15 Sep 2020 04:42:54 +0000 (UTC) Received: from merlin.infradead.org (merlin.infradead.org [205.233.59.134]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 23FAE206B5 for ; Tue, 15 Sep 2020 04:42:54 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="kemFxv7r"; dkim=fail reason="signature verification failed" (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="Dss1pWaW" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 23FAE206B5 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=gmail.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=merlin.20170209; h=Sender:Content-Transfer-Encoding: Content-Type:Cc:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References:Message-ID: Subject:To:From:Date:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=ADMsirqf/FuVTEPREq15E9t3XBxh6rSCEzl3IjjGMxQ=; b=kemFxv7r3IX9fe1rt+aae9HSf lKBTQdu3Z9J8TUm+WdYpE6w//NUoQwOsSgnBr7d2H3pn+qujD/dzU33T9fq0pXXX+LCleIpxlkOcX vgWn+SbYrHTGmKIPzI7OAn2yC7RTZWrdDWMwKXV/cZcuAE1iPLw0At205mCB9wtxdxwzGwkYXqe6F 1xEb4is0sy8EZ7QHLzgLv3/LWRUOlbXT2Y0BNDBGMIJ6iBFUH9t5iLTbGlkKzWl5HSDjqonOOxYjA te9V8QEklQVW4WA4bBy55x67E/aEKQbjO1RHzbPvlkpj6LR8ZRkzAEeqqdNQ3hJL8aOHm52ZDa6Yi i8PTyxLnw==; Received: from localhost ([::1] helo=merlin.infradead.org) by merlin.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1kI2m9-0007kt-9o; Tue, 15 Sep 2020 04:41:05 +0000 Received: from mail-pf1-x444.google.com ([2607:f8b0:4864:20::444]) by merlin.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1kI2m6-0007kW-1A for linux-arm-kernel@lists.infradead.org; Tue, 15 Sep 2020 04:41:03 +0000 Received: by mail-pf1-x444.google.com with SMTP id f18so1191774pfa.10 for ; Mon, 14 Sep 2020 21:40:59 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to:user-agent; bh=Pjrcg1WkBU4kVCBKHDKoZZUp19W2cHWUZCFBQFzac+8=; b=Dss1pWaWFYCAqdOp6etZgXP5Ef4GyfEK9wuCCXO0hQKi8a/DLuk0FceJSSXQTWOg0W TZjb7lTaYt7uXE7iXBeOE4Blros83Aqi+N3CSLOY8jr8FPbAlYoACmWhiR+EFVz1lKjf yUnVRZ04dqshzRM2hV7qMEM2cpGV/hfXDIfK85ffH8LRK/NrMSBamO3X/yvh8CcdUYSN 317eQgPKO+cPIv0t7F1jV4cV3eyFrZj4bokuN4NeOCAQ5nOEi/zq5aHhZ+oRUzT3Y9T4 Izdecor5RLnGI63gluMfhwlXVepra5S0rCU83k8XtdNg2wupTYq6S8QBFfQ8a1R4Ptey R11Q== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to:user-agent; bh=Pjrcg1WkBU4kVCBKHDKoZZUp19W2cHWUZCFBQFzac+8=; b=rR5oFOvgniCmF3zjRUmSjWxjVRbmT0E3s/HQkFMU5/gJmxYQzxPPwXYl+ht7ezQbK3 HFxU+BGZ5rrKOPsKwT/wkm4FOxkv9S4xDG/RUnhG4S1HrzO0ntCBJqLplIWNGXyxX76W 8vYmt5kPBrx9Ir+lrC073H3sPGHZLz4fp9WDMj2fG+p9W6/F8dzVmSROY/ALGnRSgVGc gb8CPWKD8/eMJiBqRv78aq6xD41Yed919qq3h36gQAOC/3jYcgwwXfF/guDN1PzUVCVt quqyFSXnjWqIYABmjidz0Ii8wHdO1ZFD4i42+rzhdXRmPjD+6UtMkyKzlOqLgxNzUbny g4LQ== X-Gm-Message-State: AOAM532ecozk8N6LyI0yiYy0dgxwt77UEyRCwLTNi/DtggOa4EFLxMtq p5uWjTJTNPumAwWUf/ZdRuY= X-Google-Smtp-Source: ABdhPJzNMdIgiPNHTkmN048d4L1HplAC7BbkhYKkWtBoQN/2E4Y60YahtURD9aVqyaIIKot/MU/lUQ== X-Received: by 2002:a62:17cd:0:b029:13c:1611:652b with SMTP id 196-20020a6217cd0000b029013c1611652bmr16603704pfx.11.1600144858266; Mon, 14 Sep 2020 21:40:58 -0700 (PDT) Received: from BG-LT6221.marvell.com ([122.172.187.237]) by smtp.gmail.com with ESMTPSA id c9sm5125220pfn.78.2020.09.14.21.40.55 (version=TLS1_2 cipher=ECDHE-ECDSA-AES128-GCM-SHA256 bits=128/128); Mon, 14 Sep 2020 21:40:57 -0700 (PDT) Date: Tue, 15 Sep 2020 10:10:44 +0530 From: Linu Cherian To: Mathieu Poirier Subject: Re: [PATCH v4 2/2] coresight: Make sysFS functional on topologies with per core sink Message-ID: <20200915044044.GA171@BG-LT6221.marvell.com> References: <20200904024106.21478-1-lcherian@marvell.com> <20200904024106.21478-3-lcherian@marvell.com> <20200914193605.GA3243721@xps15> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20200914193605.GA3243721@xps15> User-Agent: Mutt/1.5.24 (2015-08-30) X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20200915_004102_111224_D325D635 X-CRM114-Status: GOOD ( 19.58 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: coresight@lists.linaro.org, mike.leach@linaro.org, linux-arm-kernel@lists.infradead.org, Linu Cherian , suzuki.poulose@arm.com Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org Hi Mathieu, > > > /** > > - * coresight_get_enabled_sink - returns the first enabled sink found on the bus > > - * @deactivate: Whether the 'enable_sink' flag should be reset > > - * > > - * When operated from perf the deactivate parameter should be set to 'true'. > > - * That way the "enabled_sink" flag of the sink that was selected can be reset, > > - * allowing for other concurrent perf sessions to choose a different sink. > > + * coresight_get_enabled_sink - returns the first enabled sink using > > + * connection based search starting from the source reference > > * > > - * When operated from sysFS users have full control and as such the deactivate > > - * parameter should be set to 'false', hence mandating users to explicitly > > - * clear the flag. > > + * @source: Coresight source device reference > > */ > > -struct coresight_device *coresight_get_enabled_sink(bool deactivate) > > +struct coresight_device * > > +coresight_get_enabled_sink(struct coresight_device *source) > > { > > - struct device *dev = NULL; > > - > > - dev = bus_find_device(&coresight_bustype, NULL, &deactivate, > > - coresight_enabled_sink); > > + if (!source) > > + return NULL; > > > > - return dev ? to_coresight_device(dev) : NULL; > > + return coresight_find_enabled_sink(source); > > } > > > > static int coresight_sink_by_id(struct device *dev, const void *data) > > @@ -992,7 +988,7 @@ int coresight_enable(struct coresight_device *csdev) > > * Search for a valid sink for this session but don't reset the > > * "enable_sink" flag in sysFS. Users get to do that explicitly. > > */ > > With this patch the above comment is no longer relevant. Since you were nice > enough to do the extra work I fixed both problem and applied your patches. Thanks. -- Linu cherian _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel