From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.3 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS, USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 278BAC433E2 for ; Tue, 15 Sep 2020 07:45:23 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id EBBC721974 for ; Tue, 15 Sep 2020 07:45:22 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726157AbgIOHpS (ORCPT ); Tue, 15 Sep 2020 03:45:18 -0400 Received: from mx2.suse.de ([195.135.220.15]:60338 "EHLO mx2.suse.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726178AbgIOHpJ (ORCPT ); Tue, 15 Sep 2020 03:45:09 -0400 X-Virus-Scanned: by amavisd-new at test-mx.suse.de Received: from relay2.suse.de (unknown [195.135.221.27]) by mx2.suse.de (Postfix) with ESMTP id 8C56DAD73; Tue, 15 Sep 2020 07:45:14 +0000 (UTC) Received: by ds.suse.cz (Postfix, from userid 10065) id EA709DA7C7; Tue, 15 Sep 2020 09:43:47 +0200 (CEST) Date: Tue, 15 Sep 2020 09:43:47 +0200 From: David Sterba To: Nikolay Borisov Cc: linux-btrfs@vger.kernel.org Subject: Re: [PATCH v2 0/9] Cleanup metadata page reading path Message-ID: <20200915074347.GC1791@twin.jikos.cz> Reply-To: dsterba@suse.cz Mail-Followup-To: dsterba@suse.cz, Nikolay Borisov , linux-btrfs@vger.kernel.org References: <20200914093711.13523-1-nborisov@suse.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20200914093711.13523-1-nborisov@suse.com> User-Agent: Mutt/1.5.23.1-rc1 (2014-03-12) Sender: linux-btrfs-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-btrfs@vger.kernel.org On Mon, Sep 14, 2020 at 12:37:02PM +0300, Nikolay Borisov wrote: > Here is v2 of the metadata readout cleanups [0]. This series incorporates the > feedback I received, namely: > > * Added justification why removing btree_readpage is safe in Patch 1 > * Dropped Patch 2 (pg_offset remove from btrfs_get_extent) as Qu intends on using > it in his subpage blocksize work. > * Add a comment about caller's responsibility for cleanup in Patch 3 > * Added RB for patches which haven't changed since v1 and got RB by Josef. > > [0] https://lore.kernel.org/linux-btrfs/20200909094914.29721-1-nborisov@suse.com/T/#t > > Nikolay Borisov (9): > btrfs: Remove btree_readpage > btrfs: Simplify metadata pages reading > btrfs: Remove btree_get_extent > btrfs: Remove btrfs_get_extent indirection from __do_readpage > btrfs: Remove mirror_num argument from extent_read_full_page > btrfs: Promote extent_read_full_page to btrfs_readpage > btrfs: Sink mirror_num argument in extent_read_full_page > btrfs: Sink read_flags argument into extent_read_full_page > btrfs: Sink mirror_num argument in __do_readpage Added to misc-next, thanks.