Hi Thomas, I love your patch! Yet something to improve: [auto build test ERROR on drm-intel/for-linux-next] [also build test ERROR on linus/master v5.9-rc5 next-20200914] [cannot apply to rcu/dev arm/for-next tip/sched/core linux/master] [If your patch is applied to the wrong git tree, kindly drop us a note. And when submitting patch, we suggest to use '--base' as documented in https://git-scm.com/docs/git-format-patch] url: https://github.com/0day-ci/linux/commits/Thomas-Gleixner/preempt-Make-preempt-count-unconditional/20200915-044640 base: git://anongit.freedesktop.org/drm-intel for-linux-next config: i386-randconfig-r035-20200913 (attached as .config) compiler: gcc-9 (Debian 9.3.0-15) 9.3.0 reproduce (this is a W=1 build): # save the attached .config to linux build tree make W=1 ARCH=i386 If you fix the issue, kindly add following tag as appropriate Reported-by: kernel test robot All errors (new ones prefixed by >>): In file included from include/linux/gfp.h:5, from include/linux/slab.h:15, from include/linux/crypto.h:20, from arch/x86/kernel/asm-offsets.c:9: include/linux/pagemap.h: In function '__page_cache_add_speculative': >> include/linux/mmdebug.h:20:2: error: expected ';' before 'do' 20 | do { \ | ^~ include/linux/pagemap.h:181:2: note: in expansion of macro 'VM_BUG_ON_PAGE' 181 | VM_BUG_ON_PAGE(page_count(page) == 0, page); | ^~~~~~~~~~~~~~ make[2]: *** [scripts/Makefile.build:117: arch/x86/kernel/asm-offsets.s] Error 1 make[2]: Target '__build' not remade because of errors. make[1]: *** [Makefile:1198: prepare0] Error 2 make[1]: Target 'prepare' not remade because of errors. make: *** [Makefile:185: __sub-make] Error 2 make: Target 'prepare' not remade because of errors. # https://github.com/0day-ci/linux/commit/a4a0f54fdd08d95dfe20d684b405db8a47fb61d8 git remote add linux-review https://github.com/0day-ci/linux git fetch --no-tags linux-review Thomas-Gleixner/preempt-Make-preempt-count-unconditional/20200915-044640 git checkout a4a0f54fdd08d95dfe20d684b405db8a47fb61d8 vim +20 include/linux/mmdebug.h 309381feaee564 Sasha Levin 2014-01-23 16 59ea746337c69f Jiri Slaby 2008-06-12 17 #ifdef CONFIG_DEBUG_VM 59ea746337c69f Jiri Slaby 2008-06-12 18 #define VM_BUG_ON(cond) BUG_ON(cond) 309381feaee564 Sasha Levin 2014-01-23 19 #define VM_BUG_ON_PAGE(cond, page) \ e4f674229ce63d Dave Hansen 2014-06-04 @20 do { \ e4f674229ce63d Dave Hansen 2014-06-04 21 if (unlikely(cond)) { \ e4f674229ce63d Dave Hansen 2014-06-04 22 dump_page(page, "VM_BUG_ON_PAGE(" __stringify(cond)")");\ e4f674229ce63d Dave Hansen 2014-06-04 23 BUG(); \ e4f674229ce63d Dave Hansen 2014-06-04 24 } \ e4f674229ce63d Dave Hansen 2014-06-04 25 } while (0) fa3759ccd5651c Sasha Levin 2014-10-09 26 #define VM_BUG_ON_VMA(cond, vma) \ fa3759ccd5651c Sasha Levin 2014-10-09 27 do { \ fa3759ccd5651c Sasha Levin 2014-10-09 28 if (unlikely(cond)) { \ fa3759ccd5651c Sasha Levin 2014-10-09 29 dump_vma(vma); \ fa3759ccd5651c Sasha Levin 2014-10-09 30 BUG(); \ fa3759ccd5651c Sasha Levin 2014-10-09 31 } \ fa3759ccd5651c Sasha Levin 2014-10-09 32 } while (0) 31c9afa6db122a Sasha Levin 2014-10-09 33 #define VM_BUG_ON_MM(cond, mm) \ 31c9afa6db122a Sasha Levin 2014-10-09 34 do { \ 31c9afa6db122a Sasha Levin 2014-10-09 35 if (unlikely(cond)) { \ 31c9afa6db122a Sasha Levin 2014-10-09 36 dump_mm(mm); \ 31c9afa6db122a Sasha Levin 2014-10-09 37 BUG(); \ 31c9afa6db122a Sasha Levin 2014-10-09 38 } \ 31c9afa6db122a Sasha Levin 2014-10-09 39 } while (0) 91241681c62a5a Michal Hocko 2018-04-05 40 #define VM_WARN_ON(cond) (void)WARN_ON(cond) 91241681c62a5a Michal Hocko 2018-04-05 41 #define VM_WARN_ON_ONCE(cond) (void)WARN_ON_ONCE(cond) 91241681c62a5a Michal Hocko 2018-04-05 42 #define VM_WARN_ONCE(cond, format...) (void)WARN_ONCE(cond, format) 91241681c62a5a Michal Hocko 2018-04-05 43 #define VM_WARN(cond, format...) (void)WARN(cond, format) 59ea746337c69f Jiri Slaby 2008-06-12 44 #else 02602a18c32d76 Konstantin Khlebnikov 2012-05-29 45 #define VM_BUG_ON(cond) BUILD_BUG_ON_INVALID(cond) 309381feaee564 Sasha Levin 2014-01-23 46 #define VM_BUG_ON_PAGE(cond, page) VM_BUG_ON(cond) fa3759ccd5651c Sasha Levin 2014-10-09 47 #define VM_BUG_ON_VMA(cond, vma) VM_BUG_ON(cond) 31c9afa6db122a Sasha Levin 2014-10-09 48 #define VM_BUG_ON_MM(cond, mm) VM_BUG_ON(cond) 02a8efeda894d3 Andrew Morton 2014-06-04 49 #define VM_WARN_ON(cond) BUILD_BUG_ON_INVALID(cond) 02a8efeda894d3 Andrew Morton 2014-06-04 50 #define VM_WARN_ON_ONCE(cond) BUILD_BUG_ON_INVALID(cond) ef6b571fb8920d Andrew Morton 2014-08-06 51 #define VM_WARN_ONCE(cond, format...) BUILD_BUG_ON_INVALID(cond) a54f9aebaa9f0e Aneesh Kumar K.V 2016-07-26 52 #define VM_WARN(cond, format...) BUILD_BUG_ON_INVALID(cond) 59ea746337c69f Jiri Slaby 2008-06-12 53 #endif 59ea746337c69f Jiri Slaby 2008-06-12 54 --- 0-DAY CI Kernel Test Service, Intel Corporation https://lists.01.org/hyperkitty/list/kbuild-all(a)lists.01.org