From mboxrd@z Thu Jan 1 00:00:00 1970 From: Tom Rini Date: Tue, 15 Sep 2020 08:49:02 -0400 Subject: [PATCH v2] mx6qsabrelite: increase the environment offset In-Reply-To: <20200915113714.1174226-1-denis.pynkin@collabora.com> References: <20200915113714.1174226-1-denis.pynkin@collabora.com> Message-ID: <20200915124902.GE5110@bill-the-cat> List-Id: MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: u-boot@lists.denx.de On Tue, Sep 15, 2020 at 02:37:14PM +0300, Denis Pynkin wrote: > The size of the binary created with the default U-boot config is much > greater than the default offset for environment `0x60000`. > In case if that binary is used for booting via MMC it is overlapped with > the environment stored on MMC. > This leads to U-Boot corruption while saving environment with `saveenv` > command and non-bootable SabreLite board. > > The offset for environment `CONFIG_ENV_OFFSET=0x60000` was added in > commit a09fea1 but did not count in the change to `0xC0000` if option > `CONFIG_ENV_IS_IN_MMC` is used. > > The offset is also used for variant with environment saving onto SPI NOR > flash (with enabled option `CONFIG_ENV_IS_IN_SPI_FLASH`). In that case the > U-Boot binary flashed on SPI NOR is also corrupted after environment > saving with the original 0x60000 offset. > > Signed-off-by: Denis Pynkin Thanks for rewording. Reviewed-by: Tom Rini -- Tom -------------- next part -------------- A non-text attachment was scrubbed... Name: signature.asc Type: application/pgp-signature Size: 659 bytes Desc: not available URL: