From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-15.7 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH, MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED, USER_AGENT_GIT autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id EE785C433E2 for ; Tue, 15 Sep 2020 23:44:26 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id B828B2078D for ; Tue, 15 Sep 2020 23:44:26 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1600213466; bh=pcK80tmAukYeq+PTtoqjTJcUWV1VVi5YRqN7w5CUDy0=; h=From:To:Cc:Subject:Date:In-Reply-To:References:List-ID:From; b=W9YJ1kWhcs4r+ATEdGC5vFDmjKZxHwfp3MBYLPAK5RWCkdMotOannvbAKWTzHS9ce eUyS2YxGqgqAgDQHXzQ/HFXDweN20VJHroEE7zfS9WJt982cEgu+6s494Qimf3+lBi yJ7zp7Fmw83UaUXvh0l2xNMXppavNjY6JJ4qFwVc= Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727337AbgIOXoQ (ORCPT ); Tue, 15 Sep 2020 19:44:16 -0400 Received: from mail.kernel.org ([198.145.29.99]:47672 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1727004AbgIOOd4 (ORCPT ); Tue, 15 Sep 2020 10:33:56 -0400 Received: from localhost (83-86-74-64.cable.dynamic.v4.ziggo.nl [83.86.74.64]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 88A0D23C18; Tue, 15 Sep 2020 14:25:20 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1600179921; bh=pcK80tmAukYeq+PTtoqjTJcUWV1VVi5YRqN7w5CUDy0=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=Yrv+n3rYWScfG3fzLNuWoRwt2oEW7NR2uLEtbRaYG1GjCzNm6y6/iLlv9+WVQEuVH Bd95rX6I3zj0fZjCYM/b02q97dwTwA6Wrb0J/Q236+jZpQ4Zpks/Vy144Eplh6+9Jc zKwwPxPgqdr3H6gN296ly5MX4Nc9LVgQ79Qx7/yg= From: Greg Kroah-Hartman To: linux-kernel@vger.kernel.org Cc: Greg Kroah-Hartman , stable@vger.kernel.org, Roman Stratiienko , Jernej Skrabec , Maxime Ripard , Sasha Levin Subject: [PATCH 5.8 038/177] drm/sun4i: Fix DE2 YVU handling Date: Tue, 15 Sep 2020 16:11:49 +0200 Message-Id: <20200915140655.464788926@linuxfoundation.org> X-Mailer: git-send-email 2.28.0 In-Reply-To: <20200915140653.610388773@linuxfoundation.org> References: <20200915140653.610388773@linuxfoundation.org> User-Agent: quilt/0.66 MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Jernej Skrabec [ Upstream commit 0ee9f600e69d901d31469359287b90bbe8e54553 ] Function sun8i_vi_layer_get_csc_mode() is supposed to return CSC mode but due to inproper return type (bool instead of u32) it returns just 0 or 1. Colors are wrong for YVU formats because of that. Fixes: daab3d0e8e2b ("drm/sun4i: de2: csc_mode in de2 format struct is mostly redundant") Reported-by: Roman Stratiienko Signed-off-by: Jernej Skrabec Tested-by: Roman Stratiienko Signed-off-by: Maxime Ripard Link: https://patchwork.freedesktop.org/patch/msgid/20200901220305.6809-1-jernej.skrabec@siol.net Signed-off-by: Sasha Levin --- drivers/gpu/drm/sun4i/sun8i_vi_layer.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/gpu/drm/sun4i/sun8i_vi_layer.c b/drivers/gpu/drm/sun4i/sun8i_vi_layer.c index 22c8c5375d0db..c0147af6a8406 100644 --- a/drivers/gpu/drm/sun4i/sun8i_vi_layer.c +++ b/drivers/gpu/drm/sun4i/sun8i_vi_layer.c @@ -211,7 +211,7 @@ static int sun8i_vi_layer_update_coord(struct sun8i_mixer *mixer, int channel, return 0; } -static bool sun8i_vi_layer_get_csc_mode(const struct drm_format_info *format) +static u32 sun8i_vi_layer_get_csc_mode(const struct drm_format_info *format) { if (!format->is_yuv) return SUN8I_CSC_MODE_OFF; -- 2.25.1