From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-15.7 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH, MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED, USER_AGENT_GIT autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 09457C433E2 for ; Tue, 15 Sep 2020 23:26:26 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id CEFCE212CC for ; Tue, 15 Sep 2020 23:26:25 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1600212385; bh=h6xx1KJe4gFV0n9SILeZX8OXG7ko2Pw2BvsYb0znpSQ=; h=From:To:Cc:Subject:Date:In-Reply-To:References:List-ID:From; b=1cMTlZlgY4K3HIl89rk2eREysX7v3yZztG/LmJe9texeELtJcNrvmL4dFeXYMxCMX jatpypYkxJ34s/i57tOgRhwRoayHsqYDSCsCd7SWo5XQU5gWaPVyYC9LFTzVym35EO otjchIXQNnPottVQmw9rNPvkxVUdg3Cy3i3XjVlE= Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726736AbgIOX0X (ORCPT ); Tue, 15 Sep 2020 19:26:23 -0400 Received: from mail.kernel.org ([198.145.29.99]:48792 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1727172AbgIOOh4 (ORCPT ); Tue, 15 Sep 2020 10:37:56 -0400 Received: from localhost (83-86-74-64.cable.dynamic.v4.ziggo.nl [83.86.74.64]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 3E92423C42; Tue, 15 Sep 2020 14:27:22 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1600180042; bh=h6xx1KJe4gFV0n9SILeZX8OXG7ko2Pw2BvsYb0znpSQ=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=WID5UO2pOsUGfNmQiqyCsOjM6IzqDS4AfgKfMQaOy/wPorjcDVl/jL7LcPb/z5Ep1 kgM0975bH8FgXFuF68roH63ZU9EmTGd3VUzDnkIbyXq9DUC4RhX3Vaa0uNg/68C7mo m+zAhgRml4gCxVq2Oe1WeTrFWZ3cmqAfx83XO2Jc= From: Greg Kroah-Hartman To: linux-kernel@vger.kernel.org Cc: Greg Kroah-Hartman , stable@vger.kernel.org, Christoph Hellwig , Sagi Grimberg , Sasha Levin Subject: [PATCH 5.8 084/177] nvme-fabrics: dont check state NVME_CTRL_NEW for request acceptance Date: Tue, 15 Sep 2020 16:12:35 +0200 Message-Id: <20200915140657.667660800@linuxfoundation.org> X-Mailer: git-send-email 2.28.0 In-Reply-To: <20200915140653.610388773@linuxfoundation.org> References: <20200915140653.610388773@linuxfoundation.org> User-Agent: quilt/0.66 MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Sagi Grimberg [ Upstream commit d7144f5c4cf4de95fdc3422943cf51c06aeaf7a7 ] NVME_CTRL_NEW should never see any I/O, because in order to start initialization it has to transition to NVME_CTRL_CONNECTING and from there it will never return to this state. Reviewed-by: Christoph Hellwig Signed-off-by: Sagi Grimberg Signed-off-by: Sasha Levin --- drivers/nvme/host/fabrics.c | 1 - 1 file changed, 1 deletion(-) diff --git a/drivers/nvme/host/fabrics.c b/drivers/nvme/host/fabrics.c index 7799d032bf38b..8575724734e02 100644 --- a/drivers/nvme/host/fabrics.c +++ b/drivers/nvme/host/fabrics.c @@ -580,7 +580,6 @@ bool __nvmf_check_ready(struct nvme_ctrl *ctrl, struct request *rq, * which is require to set the queue live in the appropinquate states. */ switch (ctrl->state) { - case NVME_CTRL_NEW: case NVME_CTRL_CONNECTING: if (blk_rq_is_passthrough(rq) && nvme_is_fabrics(req->cmd) && req->cmd->fabrics.fctype == nvme_fabrics_type_connect) -- 2.25.1