From: Borislav Petkov <bp@alien8.de>
To: Alex Kluver <alex.kluver@hpe.com>
Cc: linux-edac@vger.kernel.org, linux-efi@vger.kernel.org,
linux-kernel@vger.kernel.org, ardb@kernel.org,
mchehab@kernel.org, russ.anderson@hpe.com,
dimitri.sivanich@hpe.com, kluveralex@gmail.com
Subject: Re: [PATCH v2 1/2] edac,ghes,cper: Add Row Extension to Memory Error Record
Date: Tue, 15 Sep 2020 18:33:12 +0200 [thread overview]
Message-ID: <20200915163312.GO14436@zn.tnic> (raw)
In-Reply-To: <20200819143544.155096-2-alex.kluver@hpe.com>
On Wed, Aug 19, 2020 at 09:35:43AM -0500, Alex Kluver wrote:
> Memory errors could be printed with incorrect row values since the DIMM
> size has outgrown the 16 bit row field in the CPER structure. UEFI
> Specification Version 2.8 has increased the size of row by allowing it to
> use the first 2 bits from a previously reserved space within the structure.
>
> When needed, add the extension bits to the row value printed.
>
> Based on UEFI 2.8 Table 299. Memory Error Record
>
> Reviewed-by: Kyle Meyer <kyle.meyer@hpe.com>
> Reviewed-by: Steve Wahl <steve.wahl@hpe.com>
> Tested-by: Russ Anderson <russ.anderson@hpe.com>
> Signed-off-by: Alex Kluver <alex.kluver@hpe.com>
> ---
>
> v1 -> v2:
> * Add static inline cper_get_mem_extension() to make it
> more readable, as suggested by Borislav Petkov.
>
> * Add second patch for bank field, bank group, and chip id.
>
> ---
> drivers/edac/ghes_edac.c | 8 ++++++--
> drivers/firmware/efi/cper.c | 9 +++++++--
> include/linux/cper.h | 16 ++++++++++++++--
> 3 files changed, 27 insertions(+), 6 deletions(-)
For the EDAC bits:
Acked-by: Borislav Petkov <bp@suse.de>
Also, I could take both through the EDAC tree, if people prefer.
--
Regards/Gruss,
Boris.
https://people.kernel.org/tglx/notes-about-netiquette
next prev parent reply other threads:[~2020-09-15 22:18 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-08-19 14:35 [PATCH v2 0/2] UEFI v2.8 Memory Error Record Updates Alex Kluver
2020-08-19 14:35 ` [PATCH v2 1/2] edac,ghes,cper: Add Row Extension to Memory Error Record Alex Kluver
2020-09-15 16:33 ` Borislav Petkov [this message]
2020-09-15 17:07 ` Ard Biesheuvel
2020-09-15 17:12 ` Ard Biesheuvel
2020-09-15 17:19 ` Borislav Petkov
2020-09-16 13:09 ` Ard Biesheuvel
2020-09-16 18:10 ` Borislav Petkov
2020-09-16 18:12 ` Russ Anderson
2020-09-18 8:30 ` [tip: efi/core] " tip-bot2 for Alex Kluver
2020-09-30 5:22 ` tip-bot2 for Alex Kluver
2020-08-19 14:35 ` [PATCH v2 2/2] cper,edac,efi: Memory Error Record: bank group/address and chip id Alex Kluver
2020-09-15 16:36 ` Borislav Petkov
2020-09-18 8:30 ` [tip: efi/core] " tip-bot2 for Alex Kluver
2020-09-30 5:22 ` tip-bot2 for Alex Kluver
2020-09-14 16:44 ` [PATCH v2 0/2] UEFI v2.8 Memory Error Record Updates Russ Anderson
2020-09-15 15:07 ` Ard Biesheuvel
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200915163312.GO14436@zn.tnic \
--to=bp@alien8.de \
--cc=alex.kluver@hpe.com \
--cc=ardb@kernel.org \
--cc=dimitri.sivanich@hpe.com \
--cc=kluveralex@gmail.com \
--cc=linux-edac@vger.kernel.org \
--cc=linux-efi@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mchehab@kernel.org \
--cc=russ.anderson@hpe.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.