From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-3.8 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 178C8C43461 for ; Tue, 15 Sep 2020 22:08:35 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id D772C20809 for ; Tue, 15 Sep 2020 22:08:34 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727707AbgIOWIQ (ORCPT ); Tue, 15 Sep 2020 18:08:16 -0400 Received: from vps0.lunn.ch ([185.16.172.187]:37054 "EHLO vps0.lunn.ch" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1727993AbgIOUVU (ORCPT ); Tue, 15 Sep 2020 16:21:20 -0400 Received: from andrew by vps0.lunn.ch with local (Exim 4.94) (envelope-from ) id 1kIHRx-00EodC-D4; Tue, 15 Sep 2020 22:21:13 +0200 Date: Tue, 15 Sep 2020 22:21:13 +0200 From: Andrew Lunn To: Dan Murphy Cc: davem@davemloft.net, f.fainelli@gmail.com, hkallweit1@gmail.com, mkubecek@suse.cz, netdev@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH net-next 1/3] ethtool: Add 100base-FX link mode entries Message-ID: <20200915202113.GE3526428@lunn.ch> References: <20200915181708.25842-1-dmurphy@ti.com> <20200915181708.25842-2-dmurphy@ti.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20200915181708.25842-2-dmurphy@ti.com> Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, Sep 15, 2020 at 01:17:06PM -0500, Dan Murphy wrote: > Add entries for the 100base-FX full and half duplex supported modes. > > $ ethtool eth0 > Supported ports: [ TP MII FIBRE ] > Supported link modes: 10baseT/Half 10baseT/Full > 100baseT/Half 100baseT/Full > 100baseFX/Half 100baseFX/Full > Supported pause frame use: Symmetric Receive-only > Supports auto-negotiation: No > Supported FEC modes: Not reported > Advertised link modes: 10baseT/Half 10baseT/Full > 100baseT/Half 100baseT/Full > 100baseFX/Half 100baseFX/Full I thought this PHY could not switch between TP and Fibre. It has a strap which decides? So i would expect the supported modes to be either BaseT or BaseFX. Not both. Same for Advertised? Andrew