From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-6.5 required=3.0 tests=BAYES_00,DKIM_INVALID, DKIM_SIGNED,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SIGNED_OFF_BY, SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id DDB28C433E2 for ; Wed, 16 Sep 2020 06:05:45 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id AA45820715 for ; Wed, 16 Sep 2020 06:05:45 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=fail reason="signature verification failed" (1024-bit key) header.d=mg.codeaurora.org header.i=@mg.codeaurora.org header.b="vyDl+eUi" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726308AbgIPGFl (ORCPT ); Wed, 16 Sep 2020 02:05:41 -0400 Received: from mail29.static.mailgun.info ([104.130.122.29]:39844 "EHLO mail29.static.mailgun.info" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726193AbgIPGFk (ORCPT ); Wed, 16 Sep 2020 02:05:40 -0400 DKIM-Signature: a=rsa-sha256; v=1; c=relaxed/relaxed; d=mg.codeaurora.org; q=dns/txt; s=smtp; t=1600236340; h=Date: Message-Id: Cc: To: References: In-Reply-To: From: Subject: Content-Transfer-Encoding: MIME-Version: Content-Type: Sender; bh=LVuT7lpdvlG0eDKLnHgJjP0+JteFTpEEgYwkLVplvew=; b=vyDl+eUiWxc2Fs0x5WOBl0CAb5KX/7BoKCCeRWwmzd/G1K8LKX/sdc4znQNGDeeUsfsd1EGb nOIpg8ubDaNS8Cr30XxOXmsOBH+GOT5cIxkby7dKg7s4i/DgzgRAXAY3/AF9sXJCL+jxeqou qeMyNbWfYaRg9vxcLXXSqubTj9A= X-Mailgun-Sending-Ip: 104.130.122.29 X-Mailgun-Sid: WyI3YTAwOSIsICJsaW51eC13aXJlbGVzc0B2Z2VyLmtlcm5lbC5vcmciLCAiYmU5ZTRhIl0= Received: from smtp.codeaurora.org (ec2-35-166-182-171.us-west-2.compute.amazonaws.com [35.166.182.171]) by smtp-out-n07.prod.us-west-2.postgun.com with SMTP id 5f61ab2424954b1631e52d1e (version=TLS1.2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256); Wed, 16 Sep 2020 06:05:24 GMT Received: by smtp.codeaurora.org (Postfix, from userid 1001) id B37B9C433F0; Wed, 16 Sep 2020 06:05:24 +0000 (UTC) Received: from potku.adurom.net (88-114-240-156.elisa-laajakaista.fi [88.114.240.156]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) (Authenticated sender: kvalo) by smtp.codeaurora.org (Postfix) with ESMTPSA id 00466C433CA; Wed, 16 Sep 2020 06:05:20 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 smtp.codeaurora.org 00466C433CA Authentication-Results: aws-us-west-2-caf-mail-1.web.codeaurora.org; dmarc=none (p=none dis=none) header.from=codeaurora.org Authentication-Results: aws-us-west-2-caf-mail-1.web.codeaurora.org; spf=fail smtp.mailfrom=kvalo@codeaurora.org Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Subject: Re: [PATCH] brcmsmac: main: Eliminate empty brcms_c_down_del_timer() From: Kalle Valo In-Reply-To: <20200910140446.1168049-1-yanaijie@huawei.com> References: <20200910140446.1168049-1-yanaijie@huawei.com> To: Jason Yan Cc: , , , , , , , , , , , , , Jason Yan , Hulk Robot User-Agent: pwcli/0.1.0-git (https://github.com/kvalo/pwcli/) Python/3.5.2 Message-Id: <20200916060524.B37B9C433F0@smtp.codeaurora.org> Date: Wed, 16 Sep 2020 06:05:24 +0000 (UTC) Sender: linux-wireless-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-wireless@vger.kernel.org Jason Yan wrote: > This function does nothing so remove it. This addresses the following > coccicheck warning: > > drivers/net/wireless/broadcom/brcm80211/brcmsmac/main.c:5103:6-15: > Unneeded variable: "callbacks". Return "0" on line 5105 > > Reported-by: Hulk Robot > Signed-off-by: Jason Yan Patch applied to wireless-drivers-next.git, thanks. b86acf155c1c brcmsmac: main: Eliminate empty brcms_c_down_del_timer() -- https://patchwork.kernel.org/patch/11769045/ https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches