[PATCH v2 0/3] Document r8a77990 DRIF support

[PATCH v2 0/3] Document r8a77990 DRIF support

[Fabrizio Castro]

Dear All,

this series documents DRIF support for the r8a77990
(a.k.a. R-Car E3).

Thanks,
Fab

Fabrizio Castro (3):
  MAINTAINERS: Add Fabrizio Castro to Renesas DRIF
  media: dt-bindings: media: renesas,drif: Convert to json-schema
  media: dt-bindings: media: renesas,drif: Add r8a77990 support

 .../bindings/media/renesas,drif.txt           | 177 ------------
 .../bindings/media/renesas,drif.yaml          | 271 ++++++++++++++++++
 MAINTAINERS                                   |   3 +-
 3 files changed, 273 insertions(+), 178 deletions(-)
 delete mode 100644 Documentation/devicetree/bindings/media/renesas,drif.txt
 create mode 100644 Documentation/devicetree/bindings/media/renesas,drif.yaml

-- 
2.25.1

[PATCH v2 1/3] MAINTAINERS: Add Fabrizio Castro to Renesas DRIF

[Fabrizio Castro]

Renesas are expanding their DRIF support and offering,
I'll be the internal maintainer for DRIF.

Signed-off-by: Fabrizio Castro <fabrizio.castro.jz@renesas.com>
Reviewed-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com>
---
v1->v2:
* No change

 MAINTAINERS | 1 +
 1 file changed, 1 insertion(+)

diff --git a/MAINTAINERS b/MAINTAINERS
index 2575f449139a..d9ebaf0c179b 100644
--- a/MAINTAINERS
+++ b/MAINTAINERS
@@ -10909,6 +10909,7 @@ F:	include/media/drv-intf/renesas-ceu.h
 
 MEDIA DRIVERS FOR RENESAS - DRIF
 M:	Ramesh Shanmugasundaram <rashanmu@gmail.com>
+M:	Fabrizio Castro <fabrizio.castro.jz@renesas.com>
 L:	linux-media@vger.kernel.org
 L:	linux-renesas-soc@vger.kernel.org
 S:	Supported
-- 
2.25.1

[PATCH v2 2/3] media: dt-bindings: media: renesas,drif: Convert to json-schema

[Fabrizio Castro]

Convert the Renesas DRIF bindings to DT schema and update
MAINTAINERS accordingly.

Signed-off-by: Fabrizio Castro <fabrizio.castro.jz@renesas.com>
Reviewed-by: Lad Prabhakar <prabhakar.mahadev-lad.rj@bp.renesas.com>
Reviewed-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com>
---
v1->v2:
* s/controller/Controller/ in the title of renesas,drif.yaml
  as suggested by Laurent.

 .../bindings/media/renesas,drif.txt           | 177 ------------
 .../bindings/media/renesas,drif.yaml          | 270 ++++++++++++++++++
 MAINTAINERS                                   |   2 +-
 3 files changed, 271 insertions(+), 178 deletions(-)
 delete mode 100644 Documentation/devicetree/bindings/media/renesas,drif.txt
 create mode 100644 Documentation/devicetree/bindings/media/renesas,drif.yaml

diff --git a/Documentation/devicetree/bindings/media/renesas,drif.txt b/Documentation/devicetree/bindings/media/renesas,drif.txt
deleted file mode 100644
index 0d8974aa8b38..000000000000
--- a/Documentation/devicetree/bindings/media/renesas,drif.txt
+++ /dev/null
@@ -1,177 +0,0 @@
-Renesas R-Car Gen3 Digital Radio Interface controller (DRIF)
-------------------------------------------------------------
-
-R-Car Gen3 DRIF is a SPI like receive only slave device. A general
-representation of DRIF interfacing with a master device is shown below.
-
-+---------------------+                +---------------------+
-|                     |-----SCK------->|CLK                  |
-|       Master        |-----SS-------->|SYNC  DRIFn (slave)  |
-|                     |-----SD0------->|D0                   |
-|                     |-----SD1------->|D1                   |
-+---------------------+                +---------------------+
-
-As per datasheet, each DRIF channel (drifn) is made up of two internal
-channels (drifn0 & drifn1). These two internal channels share the common
-CLK & SYNC. Each internal channel has its own dedicated resources like
-irq, dma channels, address space & clock. This internal split is not
-visible to the external master device.
-
-The device tree model represents each internal channel as a separate node.
-The internal channels sharing the CLK & SYNC are tied together by their
-phandles using a property called "renesas,bonding". For the rest of
-the documentation, unless explicitly stated, the word channel implies an
-internal channel.
-
-When both internal channels are enabled they need to be managed together
-as one (i.e.) they cannot operate alone as independent devices. Out of the
-two, one of them needs to act as a primary device that accepts common
-properties of both the internal channels. This channel is identified by a
-property called "renesas,primary-bond".
-
-To summarize,
-   - When both the internal channels that are bonded together are enabled,
-     the zeroth channel is selected as primary-bond. This channels accepts
-     properties common to all the members of the bond.
-   - When only one of the bonded channels need to be enabled, the property
-     "renesas,bonding" or "renesas,primary-bond" will have no effect. That
-     enabled channel can act alone as any other independent device.
-
-Required properties of an internal channel:
--------------------------------------------
-- compatible:	"renesas,r8a7795-drif" if DRIF controller is a part of R8A7795 SoC.
-		"renesas,r8a7796-drif" if DRIF controller is a part of R8A7796 SoC.
-		"renesas,rcar-gen3-drif" for a generic R-Car Gen3 compatible device.
-
-		When compatible with the generic version, nodes must list the
-		SoC-specific version corresponding to the platform first
-		followed by the generic version.
-
-- reg: offset and length of that channel.
-- interrupts: associated with that channel.
-- clocks: phandle and clock specifier of that channel.
-- clock-names: clock input name string: "fck".
-- dmas: phandles to the DMA channels.
-- dma-names: names of the DMA channel: "rx".
-- renesas,bonding: phandle to the other channel.
-
-Optional properties of an internal channel:
--------------------------------------------
-- power-domains: phandle to the respective power domain.
-
-Required properties of an internal channel when:
-	- It is the only enabled channel of the bond (or)
-	- If it acts as primary among enabled bonds
---------------------------------------------------------
-- pinctrl-0: pin control group to be used for this channel.
-- pinctrl-names: must be "default".
-- renesas,primary-bond: empty property indicating the channel acts as primary
-			among the bonded channels.
-- port: child port node corresponding to the data input, in accordance with
-	the video interface bindings defined in
-	Documentation/devicetree/bindings/media/video-interfaces.txt. The port
-	node must contain at least one endpoint.
-
-Optional endpoint property:
----------------------------
-- sync-active: Indicates sync signal polarity, 0/1 for low/high respectively.
-	       This property maps to SYNCAC bit in the hardware manual. The
-	       default is 1 (active high).
-
-Example:
---------
-
-(1) Both internal channels enabled:
------------------------------------
-
-When interfacing with a third party tuner device with two data pins as shown
-below.
-
-+---------------------+                +---------------------+
-|                     |-----SCK------->|CLK                  |
-|       Master        |-----SS-------->|SYNC  DRIFn (slave)  |
-|                     |-----SD0------->|D0                   |
-|                     |-----SD1------->|D1                   |
-+---------------------+                +---------------------+
-
-	drif00: rif@e6f40000 {
-		compatible = "renesas,r8a7795-drif",
-			     "renesas,rcar-gen3-drif";
-		reg = <0 0xe6f40000 0 0x64>;
-		interrupts = <GIC_SPI 12 IRQ_TYPE_LEVEL_HIGH>;
-		clocks = <&cpg CPG_MOD 515>;
-		clock-names = "fck";
-		dmas = <&dmac1 0x20>, <&dmac2 0x20>;
-		dma-names = "rx", "rx";
-		power-domains = <&sysc R8A7795_PD_ALWAYS_ON>;
-		renesas,bonding = <&drif01>;
-		renesas,primary-bond;
-		pinctrl-0 = <&drif0_pins>;
-		pinctrl-names = "default";
-		port {
-			drif0_ep: endpoint {
-			     remote-endpoint = <&tuner_ep>;
-			};
-		};
-	};
-
-	drif01: rif@e6f50000 {
-		compatible = "renesas,r8a7795-drif",
-			     "renesas,rcar-gen3-drif";
-		reg = <0 0xe6f50000 0 0x64>;
-		interrupts = <GIC_SPI 13 IRQ_TYPE_LEVEL_HIGH>;
-		clocks = <&cpg CPG_MOD 514>;
-		clock-names = "fck";
-		dmas = <&dmac1 0x22>, <&dmac2 0x22>;
-		dma-names = "rx", "rx";
-		power-domains = <&sysc R8A7795_PD_ALWAYS_ON>;
-		renesas,bonding = <&drif00>;
-	};
-
-
-(2) Internal channel 1 alone is enabled:
-----------------------------------------
-
-When interfacing with a third party tuner device with one data pin as shown
-below.
-
-+---------------------+                +---------------------+
-|                     |-----SCK------->|CLK                  |
-|       Master        |-----SS-------->|SYNC  DRIFn (slave)  |
-|                     |                |D0 (unused)          |
-|                     |-----SD-------->|D1                   |
-+---------------------+                +---------------------+
-
-	drif00: rif@e6f40000 {
-		compatible = "renesas,r8a7795-drif",
-			     "renesas,rcar-gen3-drif";
-		reg = <0 0xe6f40000 0 0x64>;
-		interrupts = <GIC_SPI 12 IRQ_TYPE_LEVEL_HIGH>;
-		clocks = <&cpg CPG_MOD 515>;
-		clock-names = "fck";
-		dmas = <&dmac1 0x20>, <&dmac2 0x20>;
-		dma-names = "rx", "rx";
-		power-domains = <&sysc R8A7795_PD_ALWAYS_ON>;
-		renesas,bonding = <&drif01>;
-	};
-
-	drif01: rif@e6f50000 {
-		compatible = "renesas,r8a7795-drif",
-			     "renesas,rcar-gen3-drif";
-		reg = <0 0xe6f50000 0 0x64>;
-		interrupts = <GIC_SPI 13 IRQ_TYPE_LEVEL_HIGH>;
-		clocks = <&cpg CPG_MOD 514>;
-		clock-names = "fck";
-		dmas = <&dmac1 0x22>, <&dmac2 0x22>;
-		dma-names = "rx", "rx";
-		power-domains = <&sysc R8A7795_PD_ALWAYS_ON>;
-		renesas,bonding = <&drif00>;
-		pinctrl-0 = <&drif0_pins>;
-		pinctrl-names = "default";
-		port {
-			drif0_ep: endpoint {
-			     remote-endpoint = <&tuner_ep>;
-			     sync-active = <0>;
-			};
-		};
-	};
diff --git a/Documentation/devicetree/bindings/media/renesas,drif.yaml b/Documentation/devicetree/bindings/media/renesas,drif.yaml
new file mode 100644
index 000000000000..4763a6009e8b
--- /dev/null
+++ b/Documentation/devicetree/bindings/media/renesas,drif.yaml
@@ -0,0 +1,270 @@
+# SPDX-License-Identifier: GPL-2.0-only OR BSD-2-Clause
+%YAML 1.2
+---
+$id: http://devicetree.org/schemas/media/renesas,drif.yaml#
+$schema: http://devicetree.org/meta-schemas/core.yaml#
+
+title: Renesas R-Car Gen3 Digital Radio Interface Controller (DRIF)
+
+maintainers:
+  - Ramesh Shanmugasundaram <rashanmu@gmail.com>
+  - Fabrizio Castro <fabrizio.castro.jz@renesas.com>
+
+description: |
+  R-Car Gen3 DRIF is a SPI like receive only slave device. A general
+  representation of DRIF interfacing with a master device is shown below.
+
+  +---------------------+                +---------------------+
+  |                     |-----SCK------->|CLK                  |
+  |       Master        |-----SS-------->|SYNC  DRIFn (slave)  |
+  |                     |-----SD0------->|D0                   |
+  |                     |-----SD1------->|D1                   |
+  +---------------------+                +---------------------+
+
+  As per datasheet, each DRIF channel (drifn) is made up of two internal
+  channels (drifn0 & drifn1). These two internal channels share the common
+  CLK & SYNC. Each internal channel has its own dedicated resources like
+  irq, dma channels, address space & clock. This internal split is not
+  visible to the external master device.
+
+  The device tree model represents each internal channel as a separate node.
+  The internal channels sharing the CLK & SYNC are tied together by their
+  phandles using a property called "renesas,bonding". For the rest of
+  the documentation, unless explicitly stated, the word channel implies an
+  internal channel.
+
+  When both internal channels are enabled they need to be managed together
+  as one (i.e.) they cannot operate alone as independent devices. Out of the
+  two, one of them needs to act as a primary device that accepts common
+  properties of both the internal channels. This channel is identified by a
+  property called "renesas,primary-bond".
+
+  To summarize,
+     * When both the internal channels that are bonded together are enabled,
+       the zeroth channel is selected as primary-bond. This channels accepts
+       properties common to all the members of the bond.
+     * When only one of the bonded channels need to be enabled, the property
+       "renesas,bonding" or "renesas,primary-bond" will have no effect. That
+       enabled channel can act alone as any other independent device.
+
+properties:
+  compatible:
+    items:
+      - enum:
+        - renesas,r8a7795-drif        # R-Car H3
+        - renesas,r8a7796-drif        # R-Car M3-W
+      - const: renesas,rcar-gen3-drif # Generic R-Car Gen3 compatible device
+
+  reg:
+    maxItems: 1
+
+  interrupts:
+    maxItems: 1
+
+  clocks:
+    maxItems: 1
+
+  clock-names:
+    maxItems: 1
+    items:
+      - const: fck
+
+  resets:
+    maxItems: 1
+
+  dmas:
+    minItems: 1
+    maxItems: 2
+
+  dma-names:
+    minItems: 1
+    maxItems: 2
+    items:
+      - const: rx
+      - const: rx
+
+  renesas,bonding:
+    $ref: /schemas/types.yaml#/definitions/phandle
+    description:
+      The phandle to the other internal channel of DRIF
+
+  power-domains:
+    maxItems: 1
+
+  pinctrl-0:
+    maxItems: 1
+
+  pinctrl-names:
+    maxItems: 1
+    items:
+      - const: default
+
+  renesas,primary-bond:
+    type: boolean
+    description:
+      Indicates that the channel acts as primary among the bonded channels.
+
+  port:
+    type: object
+    description:
+      Child port node corresponding to the data input, in accordance with the
+      video interface bindings defined in
+      Documentation/devicetree/bindings/media/video-interfaces.txt.
+      The port node must contain at least one endpoint.
+
+    properties:
+      endpoint:
+        type: object
+
+        properties:
+          remote-endpoint:
+            description:
+              A phandle to the remote tuner endpoint subnode in remote node
+              port.
+
+          sync-active:
+            enum: [0, 1]
+            description:
+              Indicates sync signal polarity, 0/1 for low/high respectively.
+              This property maps to SYNCAC bit in the hardware manual. The
+              default is 1 (active high).
+
+        additionalProperties: false
+
+required:
+  - compatible
+  - reg
+  - interrupts
+  - clocks
+  - clock-names
+  - resets
+  - dmas
+  - dma-names
+  - renesas,bonding
+
+if:
+  required:
+    - renesas,primary-bond
+then:
+  required:
+    - pinctrl-0
+    - pinctrl-names
+    - port
+
+additionalProperties: false
+
+examples:
+  # Example with both internal channels enabled.
+  #
+  # When interfacing with a third party tuner device with two data pins as shown
+  # below.
+  #
+  # +---------------------+                +---------------------+
+  # |                     |-----SCK------->|CLK                  |
+  # |       Master        |-----SS-------->|SYNC  DRIFn (slave)  |
+  # |                     |-----SD0------->|D0                   |
+  # |                     |-----SD1------->|D1                   |
+  # +---------------------+                +---------------------+
+  - |
+    #include <dt-bindings/clock/r8a7795-cpg-mssr.h>
+    #include <dt-bindings/interrupt-controller/arm-gic.h>
+    #include <dt-bindings/power/r8a7795-sysc.h>
+
+    soc {
+            #address-cells = <2>;
+            #size-cells = <2>;
+
+            drif00: rif@e6f40000 {
+                    compatible = "renesas,r8a7795-drif",
+                                 "renesas,rcar-gen3-drif";
+                    reg = <0 0xe6f40000 0 0x64>;
+                    interrupts = <GIC_SPI 12 IRQ_TYPE_LEVEL_HIGH>;
+                    clocks = <&cpg CPG_MOD 515>;
+                    clock-names = "fck";
+                    dmas = <&dmac1 0x20>, <&dmac2 0x20>;
+                    dma-names = "rx", "rx";
+                    power-domains = <&sysc R8A7795_PD_ALWAYS_ON>;
+                    renesas,bonding = <&drif01>;
+                    resets = <&cpg 515>;
+                    renesas,primary-bond;
+                    pinctrl-0 = <&drif0_pins>;
+                    pinctrl-names = "default";
+                    port {
+                            drif0_ep: endpoint {
+                                 remote-endpoint = <&tuner_ep>;
+                            };
+                    };
+            };
+
+            drif01: rif@e6f50000 {
+                    compatible = "renesas,r8a7795-drif",
+                                 "renesas,rcar-gen3-drif";
+                    reg = <0 0xe6f50000 0 0x64>;
+                    interrupts = <GIC_SPI 13 IRQ_TYPE_LEVEL_HIGH>;
+                    clocks = <&cpg CPG_MOD 514>;
+                    clock-names = "fck";
+                    dmas = <&dmac1 0x22>, <&dmac2 0x22>;
+                    dma-names = "rx", "rx";
+                    power-domains = <&sysc R8A7795_PD_ALWAYS_ON>;
+                    renesas,bonding = <&drif00>;
+                    resets = <&cpg 514>;
+            };
+    };
+
+  # Example with internal channel 1 alone enabled.
+  #
+  # When interfacing with a third party tuner device with one data pin as shown
+  # below.
+  #
+  # +---------------------+                +---------------------+
+  # |                     |-----SCK------->|CLK                  |
+  # |       Master        |-----SS-------->|SYNC  DRIFn (slave)  |
+  # |                     |                |D0 (unused)          |
+  # |                     |-----SD-------->|D1                   |
+  # +---------------------+                +---------------------+
+  - |
+    #include <dt-bindings/clock/r8a7795-cpg-mssr.h>
+    #include <dt-bindings/interrupt-controller/arm-gic.h>
+    #include <dt-bindings/power/r8a7795-sysc.h>
+
+    soc {
+            #address-cells = <2>;
+            #size-cells = <2>;
+
+            drif10: rif@e6f60000 {
+                    compatible = "renesas,r8a7795-drif",
+                                 "renesas,rcar-gen3-drif";
+                    reg = <0 0xe6f60000 0 0x64>;
+                    interrupts = <GIC_SPI 14 IRQ_TYPE_LEVEL_HIGH>;
+                    clocks = <&cpg CPG_MOD 513>;
+                    clock-names = "fck";
+                    dmas = <&dmac1 0x24>, <&dmac2 0x24>;
+                    dma-names = "rx", "rx";
+                    power-domains = <&sysc R8A7795_PD_ALWAYS_ON>;
+                    resets = <&cpg 513>;
+                    renesas,bonding = <&drif11>;
+            };
+
+            drif11: rif@e6f70000 {
+                    compatible = "renesas,r8a7795-drif",
+                                 "renesas,rcar-gen3-drif";
+                    reg = <0 0xe6f70000 0 0x64>;
+                    interrupts = <GIC_SPI 15 IRQ_TYPE_LEVEL_HIGH>;
+                    clocks = <&cpg CPG_MOD 512>;
+                    clock-names = "fck";
+                    dmas = <&dmac1 0x26>, <&dmac2 0x26>;
+                    dma-names = "rx", "rx";
+                    power-domains = <&sysc R8A7795_PD_ALWAYS_ON>;
+                    resets = <&cpg 512>;
+                    renesas,bonding = <&drif10>;
+                    pinctrl-0 = <&drif1_pins>;
+                    pinctrl-names = "default";
+                    port {
+                            drif1_ep: endpoint {
+                                 remote-endpoint = <&tuner_ep1>;
+                                 sync-active = <0>;
+                            };
+                    };
+            };
+    };
+...
diff --git a/MAINTAINERS b/MAINTAINERS
index d9ebaf0c179b..6b4989ad505e 100644
--- a/MAINTAINERS
+++ b/MAINTAINERS
@@ -10914,7 +10914,7 @@ L:	linux-media@vger.kernel.org
 L:	linux-renesas-soc@vger.kernel.org
 S:	Supported
 T:	git git://linuxtv.org/media_tree.git
-F:	Documentation/devicetree/bindings/media/renesas,drif.txt
+F:	Documentation/devicetree/bindings/media/renesas,drif.yaml
 F:	drivers/media/platform/rcar_drif.c
 
 MEDIA DRIVERS FOR RENESAS - FCP
-- 
2.25.1

[PATCH v2 3/3] media: dt-bindings: media: renesas,drif: Add r8a77990 support

[Fabrizio Castro]

The r8a77990 (a.k.a. R-Car E3) device tree schema is
compatible with R-Car H3 and M3-W schema.

Document r8a77990 support within renesas,drif.yaml.

Signed-off-by: Fabrizio Castro <fabrizio.castro.jz@renesas.com>
Reviewed-by: Geert Uytterhoeven <geert+renesas@glider.be>
Reviewed-by: Lad Prabhakar <prabhakar.mahadev-lad.rj@bp.renesas.com>
Reviewed-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com>
---
v1->v2:
* No change

 Documentation/devicetree/bindings/media/renesas,drif.yaml | 1 +
 1 file changed, 1 insertion(+)

diff --git a/Documentation/devicetree/bindings/media/renesas,drif.yaml b/Documentation/devicetree/bindings/media/renesas,drif.yaml
index 4763a6009e8b..2e12b353b395 100644
--- a/Documentation/devicetree/bindings/media/renesas,drif.yaml
+++ b/Documentation/devicetree/bindings/media/renesas,drif.yaml
@@ -53,6 +53,7 @@ properties:
       - enum:
         - renesas,r8a7795-drif        # R-Car H3
         - renesas,r8a7796-drif        # R-Car M3-W
+        - renesas,r8a77990-drif       # R-Car E3
       - const: renesas,rcar-gen3-drif # Generic R-Car Gen3 compatible device
 
   reg:
-- 
2.25.1

Re: [PATCH v2 0/3] Document r8a77990 DRIF support

[Laurent Pinchart]

Hi Fabrizio,

Thank you for the patches.

On Wed, Sep 16, 2020 at 11:59:46AM +0100, Fabrizio Castro wrote:
> Dear All,
> 
> this series documents DRIF support for the r8a77990
> (a.k.a. R-Car E3).

This looks good to me, but I'd like to give Rob an opportunity to review
the DT bindings. As we're already at v5.9-rc5, this will likely mean
missing the v5.10 merge window (the linux-media tree closes at -rc6). I
don't see this series being urgent, but please let me know if you
disagree.

> Fabrizio Castro (3):
>   MAINTAINERS: Add Fabrizio Castro to Renesas DRIF
>   media: dt-bindings: media: renesas,drif: Convert to json-schema
>   media: dt-bindings: media: renesas,drif: Add r8a77990 support
> 
>  .../bindings/media/renesas,drif.txt           | 177 ------------
>  .../bindings/media/renesas,drif.yaml          | 271 ++++++++++++++++++
>  MAINTAINERS                                   |   3 +-
>  3 files changed, 273 insertions(+), 178 deletions(-)
>  delete mode 100644 Documentation/devicetree/bindings/media/renesas,drif.txt
>  create mode 100644 Documentation/devicetree/bindings/media/renesas,drif.yaml

-- 
Regards,

Laurent Pinchart

RE: [PATCH v2 0/3] Document r8a77990 DRIF support

[Fabrizio Castro]

Hi Laurent,

Thank you for your feedback.

> From: Laurent Pinchart <laurent.pinchart@ideasonboard.com>
> Sent: 17 September 2020 01:55
>
> Hi Fabrizio,
>
> Thank you for the patches.
>
> On Wed, Sep 16, 2020 at 11:59:46AM +0100, Fabrizio Castro wrote:
> > Dear All,
> >
> > this series documents DRIF support for the r8a77990
> > (a.k.a. R-Car E3).
>
> This looks good to me, but I'd like to give Rob an opportunity to review
> the DT bindings. As we're already at v5.9-rc5, this will likely mean
> missing the v5.10 merge window (the linux-media tree closes at -rc6). I
> don't see this series being urgent, but please let me know if you
> disagree.

That's fine by me.

BR,
Fab

>
> > Fabrizio Castro (3):
> >   MAINTAINERS: Add Fabrizio Castro to Renesas DRIF
> >   media: dt-bindings: media: renesas,drif: Convert to json-schema
> >   media: dt-bindings: media: renesas,drif: Add r8a77990 support
> >
> >  .../bindings/media/renesas,drif.txt           | 177 ------------
> >  .../bindings/media/renesas,drif.yaml          | 271 ++++++++++++++++++
> >  MAINTAINERS                                   |   3 +-
> >  3 files changed, 273 insertions(+), 178 deletions(-)
> >  delete mode 100644
> Documentation/devicetree/bindings/media/renesas,drif.txt
> >  create mode 100644
> Documentation/devicetree/bindings/media/renesas,drif.yaml
>
> --
> Regards,
>
> Laurent Pinchart


Renesas Electronics Europe GmbH, Geschaeftsfuehrer/President: Carsten Jauch, Sitz der Gesellschaft/Registered office: Duesseldorf, Arcadiastrasse 10, 40472 Duesseldorf, Germany, Handelsregister/Commercial Register: Duesseldorf, HRB 3708 USt-IDNr./Tax identification no.: DE 119353406 WEEE-Reg.-Nr./WEEE reg. no.: DE 14978647

Re: [PATCH v2 1/3] MAINTAINERS: Add Fabrizio Castro to Renesas DRIF

[Ramesh Shanmugasundaram]

Hi Fabrizio,

>
> Renesas are expanding their DRIF support and offering,
> I'll be the internal maintainer for DRIF.
>
> Signed-off-by: Fabrizio Castro <fabrizio.castro.jz@renesas.com>
> Reviewed-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com>

Thank you for volunteering :-).

Reviewed-by: Ramesh Shanmugasundaram <rashanmu@gmail.com>

Please feel free to take my name off the maintainers list as I am not
spending time on this topic for a while now.

Thanks,
Ramesh

> ---
> v1->v2:
> * No change
>
>  MAINTAINERS | 1 +
>  1 file changed, 1 insertion(+)
>
> diff --git a/MAINTAINERS b/MAINTAINERS
> index 2575f449139a..d9ebaf0c179b 100644
> --- a/MAINTAINERS
> +++ b/MAINTAINERS
> @@ -10909,6 +10909,7 @@ F:      include/media/drv-intf/renesas-ceu.h
>
>  MEDIA DRIVERS FOR RENESAS - DRIF
>  M:     Ramesh Shanmugasundaram <rashanmu@gmail.com>
> +M:     Fabrizio Castro <fabrizio.castro.jz@renesas.com>
>  L:     linux-media@vger.kernel.org
>  L:     linux-renesas-soc@vger.kernel.org
>  S:     Supported
> --
> 2.25.1
>

Re: [PATCH v2 2/3] media: dt-bindings: media: renesas,drif: Convert to json-schema

[Geert Uytterhoeven]

Hi Fabrizio,

On Wed, Sep 16, 2020 at 1:00 PM Fabrizio Castro
<fabrizio.castro.jz@renesas.com> wrote:
> Convert the Renesas DRIF bindings to DT schema and update
> MAINTAINERS accordingly.
>
> Signed-off-by: Fabrizio Castro <fabrizio.castro.jz@renesas.com>
> Reviewed-by: Lad Prabhakar <prabhakar.mahadev-lad.rj@bp.renesas.com>
> Reviewed-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com>

Thanks for your patch!

> --- /dev/null
> +++ b/Documentation/devicetree/bindings/media/renesas,drif.yaml

> +properties:

> +  pinctrl-0:
> +    maxItems: 1
> +
> +  pinctrl-names:
> +    maxItems: 1
> +    items:
> +      - const: default

I think these are added automatically by the tooling, so there is no
need to list them explicitly.
Or do you need to list them here because of the required logic below?

> +required:
> +  - compatible
> +  - reg
> +  - interrupts
> +  - clocks
> +  - clock-names
> +  - resets
> +  - dmas
> +  - dma-names
> +  - renesas,bonding

Missing "power-domains".

> +
> +if:
> +  required:
> +    - renesas,primary-bond
> +then:
> +  required:
> +    - pinctrl-0
> +    - pinctrl-names
> +    - port

The last 3 properties must not be present for a secondary interface,
right?  To express that, I think you need to add:

    else:
      properties:
        - pinctrl-0: false
        - pinctrl-names: false
        - port: false

Gr{oetje,eeting}s,

                        Geert

-- 
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org

In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
                                -- Linus Torvalds

RE: [PATCH v2 2/3] media: dt-bindings: media: renesas,drif: Convert to json-schema

[Fabrizio Castro]

Hi Geert,

Thank you for your feedback!

> From: Geert Uytterhoeven <geert@linux-m68k.org>
> Sent: 23 September 2020 11:07
>
> Hi Fabrizio,
>
> On Wed, Sep 16, 2020 at 1:00 PM Fabrizio Castro
> <fabrizio.castro.jz@renesas.com> wrote:
> > Convert the Renesas DRIF bindings to DT schema and update
> > MAINTAINERS accordingly.
> >
> > Signed-off-by: Fabrizio Castro <fabrizio.castro.jz@renesas.com>
> > Reviewed-by: Lad Prabhakar <prabhakar.mahadev-
> lad.rj@bp.renesas.com>
> > Reviewed-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com>
>
> Thanks for your patch!
>
> > --- /dev/null
> > +++ b/Documentation/devicetree/bindings/media/renesas,drif.yaml
>
> > +properties:
>
> > +  pinctrl-0:
> > +    maxItems: 1
> > +
> > +  pinctrl-names:
> > +    maxItems: 1
> > +    items:
> > +      - const: default
>
> I think these are added automatically by the tooling, so there is no
> need to list them explicitly.
> Or do you need to list them here because of the required logic below?

I have now tried taking pinctrl-0 and pinctrl-names properties out, and things seem to be okay, I'll take them out in v3.

>
> > +required:
> > +  - compatible
> > +  - reg
> > +  - interrupts
> > +  - clocks
> > +  - clock-names
> > +  - resets
> > +  - dmas
> > +  - dma-names
> > +  - renesas,bonding
>
> Missing "power-domains".

I'll add it in v3

>
> > +
> > +if:
> > +  required:
> > +    - renesas,primary-bond
> > +then:
> > +  required:
> > +    - pinctrl-0
> > +    - pinctrl-names
> > +    - port
>
> The last 3 properties must not be present for a secondary interface,
> right?

If you have both channels enabled, then one of the two has to define properties:
* renesas,primary-bond, pinctrl-0, pinctrl-names, and port.

If only one channel is enabled, then the primary bond concept loses its value,
whether renesas,primary-bond is specified or not doesn’t matter anymore, but the
enabled node has to specify the pinctrl related properties and the port.

> To express that, I think you need to add:
>
>     else:
>       properties:
>         - pinctrl-0: false
>         - pinctrl-names: false
>         - port: false

If I went with this, we would not be able to allow those properties to be specified in the
only enabled node for single channels configurations.

Is there a better way to approach this?

I'll wait for this point to get sorted before sending v3 out.

Thanks,
Fab

>
> Gr{oetje,eeting}s,
>
>                         Geert
>
> --
> Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-
> m68k.org
>
> In personal conversations with technical people, I call myself a hacker. But
> when I'm talking to journalists I just say "programmer" or something like that.
>                                 -- Linus Torvalds


Renesas Electronics Europe GmbH, Geschaeftsfuehrer/President: Carsten Jauch, Sitz der Gesellschaft/Registered office: Duesseldorf, Arcadiastrasse 10, 40472 Duesseldorf, Germany, Handelsregister/Commercial Register: Duesseldorf, HRB 3708 USt-IDNr./Tax identification no.: DE 119353406 WEEE-Reg.-Nr./WEEE reg. no.: DE 14978647

Re: [PATCH v2 2/3] media: dt-bindings: media: renesas,drif: Convert to json-schema

[Geert Uytterhoeven]

Hi Fabrizio,

On Wed, Sep 23, 2020 at 1:55 PM Fabrizio Castro
<fabrizio.castro.jz@renesas.com> wrote:
> > From: Geert Uytterhoeven <geert@linux-m68k.org>
> > On Wed, Sep 16, 2020 at 1:00 PM Fabrizio Castro
> > <fabrizio.castro.jz@renesas.com> wrote:
> > > Convert the Renesas DRIF bindings to DT schema and update
> > > MAINTAINERS accordingly.
> > >
> > > Signed-off-by: Fabrizio Castro <fabrizio.castro.jz@renesas.com>

> > > +if:
> > > +  required:
> > > +    - renesas,primary-bond
> > > +then:
> > > +  required:
> > > +    - pinctrl-0
> > > +    - pinctrl-names
> > > +    - port
> >
> > The last 3 properties must not be present for a secondary interface,
> > right?
>
> If you have both channels enabled, then one of the two has to define properties:
> * renesas,primary-bond, pinctrl-0, pinctrl-names, and port.
>
> If only one channel is enabled, then the primary bond concept loses its value,
> whether renesas,primary-bond is specified or not doesn’t matter anymore, but the
> enabled node has to specify the pinctrl related properties and the port.
>
> > To express that, I think you need to add:
> >
> >     else:
> >       properties:
> >         - pinctrl-0: false
> >         - pinctrl-names: false
> >         - port: false
>
> If I went with this, we would not be able to allow those properties to be specified in the
> only enabled node for single channels configurations.
>
> Is there a better way to approach this?
>
> I'll wait for this point to get sorted before sending v3 out.

The old binding said:

    -Required properties of an internal channel when:
    -       - It is the only enabled channel of the bond (or)
    -       - If it acts as primary among enabled bonds

    -- renesas,primary-bond: empty property indicating the channel
acts as primary
    -                       among the bonded channels.

so renesas,primary-bond is required for the only enabled node for
single channels configurations anyway?

Gr{oetje,eeting}s,

                        Geert

-- 
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org

In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
                                -- Linus Torvalds

RE: [PATCH v2 2/3] media: dt-bindings: media: renesas,drif: Convert to json-schema

[Fabrizio Castro]

Hi Geert,

Thank you for getting back to me.

> From: Geert Uytterhoeven <geert@linux-m68k.org>
> Sent: 23 September 2020 14:33
>
> Hi Fabrizio,
>
> On Wed, Sep 23, 2020 at 1:55 PM Fabrizio Castro
> <fabrizio.castro.jz@renesas.com> wrote:
> > > From: Geert Uytterhoeven <geert@linux-m68k.org>
> > > On Wed, Sep 16, 2020 at 1:00 PM Fabrizio Castro
> > > <fabrizio.castro.jz@renesas.com> wrote:
> > > > Convert the Renesas DRIF bindings to DT schema and update
> > > > MAINTAINERS accordingly.
> > > >
> > > > Signed-off-by: Fabrizio Castro <fabrizio.castro.jz@renesas.com>
>
> > > > +if:
> > > > +  required:
> > > > +    - renesas,primary-bond
> > > > +then:
> > > > +  required:
> > > > +    - pinctrl-0
> > > > +    - pinctrl-names
> > > > +    - port
> > >
> > > The last 3 properties must not be present for a secondary interface,
> > > right?
> >
> > If you have both channels enabled, then one of the two has to define
> properties:
> > * renesas,primary-bond, pinctrl-0, pinctrl-names, and port.
> >
> > If only one channel is enabled, then the primary bond concept loses its
> value,
> > whether renesas,primary-bond is specified or not doesn’t matter anymore,
> but the
> > enabled node has to specify the pinctrl related properties and the port.
> >
> > > To express that, I think you need to add:
> > >
> > >     else:
> > >       properties:
> > >         - pinctrl-0: false
> > >         - pinctrl-names: false
> > >         - port: false
> >
> > If I went with this, we would not be able to allow those properties to be
> specified in the
> > only enabled node for single channels configurations.
> >
> > Is there a better way to approach this?
> >
> > I'll wait for this point to get sorted before sending v3 out.
>
> The old binding said:
>
>     -Required properties of an internal channel when:
>     -       - It is the only enabled channel of the bond (or)
>     -       - If it acts as primary among enabled bonds
>
>     -- renesas,primary-bond: empty property indicating the channel
> acts as primary
>     -                       among the bonded channels.
>
> so renesas,primary-bond is required for the only enabled node for
> single channels configurations anyway?

The old binding also said:
"
When only one of the bonded channels need to be enabled, the property
"renesas,bonding" or "renesas,primary-bond" will have no effect. That
enabled channel can act alone as any other independent device.
"

If you then look at the driver implementation, the renesas,primary-bond
property doesn’t get evaluated if you have only one channel enabled.

Thanks,
Fab

>
> Gr{oetje,eeting}s,
>
>                         Geert
>
> --
> Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-
> m68k.org
>
> In personal conversations with technical people, I call myself a hacker. But
> when I'm talking to journalists I just say "programmer" or something like that.
>                                 -- Linus Torvalds


Renesas Electronics Europe GmbH, Geschaeftsfuehrer/President: Carsten Jauch, Sitz der Gesellschaft/Registered office: Duesseldorf, Arcadiastrasse 10, 40472 Duesseldorf, Germany, Handelsregister/Commercial Register: Duesseldorf, HRB 3708 USt-IDNr./Tax identification no.: DE 119353406 WEEE-Reg.-Nr./WEEE reg. no.: DE 14978647

Re: [PATCH v2 3/3] media: dt-bindings: media: renesas,drif: Add r8a77990 support

[Rob Herring]

On Wed, 16 Sep 2020 11:59:49 +0100, Fabrizio Castro wrote:
> The r8a77990 (a.k.a. R-Car E3) device tree schema is
> compatible with R-Car H3 and M3-W schema.
> 
> Document r8a77990 support within renesas,drif.yaml.
> 
> Signed-off-by: Fabrizio Castro <fabrizio.castro.jz@renesas.com>
> Reviewed-by: Geert Uytterhoeven <geert+renesas@glider.be>
> Reviewed-by: Lad Prabhakar <prabhakar.mahadev-lad.rj@bp.renesas.com>
> Reviewed-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com>
> ---
> v1->v2:
> * No change
> 
>  Documentation/devicetree/bindings/media/renesas,drif.yaml | 1 +
>  1 file changed, 1 insertion(+)
> 

Acked-by: Rob Herring <robh@kernel.org>

Re: [PATCH v2 1/3] MAINTAINERS: Add Fabrizio Castro to Renesas DRIF

[Laurent Pinchart]

On Sun, Sep 20, 2020 at 12:22:14PM +0100, Ramesh Shanmugasundaram wrote:
> Hi Fabrizio,
> 
> >
> > Renesas are expanding their DRIF support and offering,
> > I'll be the internal maintainer for DRIF.
> >
> > Signed-off-by: Fabrizio Castro <fabrizio.castro.jz@renesas.com>
> > Reviewed-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com>
> 
> Thank you for volunteering :-).
> 
> Reviewed-by: Ramesh Shanmugasundaram <rashanmu@gmail.com>
> 
> Please feel free to take my name off the maintainers list as I am not
> spending time on this topic for a while now.

Fabrizio, would you like to send a v2 that removes Ramesh from the
maintainers list for DRIF ?

> > ---
> > v1->v2:
> > * No change
> >
> >  MAINTAINERS | 1 +
> >  1 file changed, 1 insertion(+)
> >
> > diff --git a/MAINTAINERS b/MAINTAINERS
> > index 2575f449139a..d9ebaf0c179b 100644
> > --- a/MAINTAINERS
> > +++ b/MAINTAINERS
> > @@ -10909,6 +10909,7 @@ F:      include/media/drv-intf/renesas-ceu.h
> >
> >  MEDIA DRIVERS FOR RENESAS - DRIF
> >  M:     Ramesh Shanmugasundaram <rashanmu@gmail.com>
> > +M:     Fabrizio Castro <fabrizio.castro.jz@renesas.com>
> >  L:     linux-media@vger.kernel.org
> >  L:     linux-renesas-soc@vger.kernel.org
> >  S:     Supported

-- 
Regards,

Laurent Pinchart

RE: [PATCH v2 1/3] MAINTAINERS: Add Fabrizio Castro to Renesas DRIF

[Fabrizio Castro]

Hi Laurent,

> From: Laurent Pinchart <laurent.pinchart@ideasonboard.com>
> Sent: 23 September 2020 17:02
> DRIF
>
> On Sun, Sep 20, 2020 at 12:22:14PM +0100, Ramesh Shanmugasundaram
> wrote:
> > Hi Fabrizio,
> >
> > >
> > > Renesas are expanding their DRIF support and offering,
> > > I'll be the internal maintainer for DRIF.
> > >
> > > Signed-off-by: Fabrizio Castro <fabrizio.castro.jz@renesas.com>
> > > Reviewed-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com>
> >
> > Thank you for volunteering :-).
> >
> > Reviewed-by: Ramesh Shanmugasundaram <rashanmu@gmail.com>
> >
> > Please feel free to take my name off the maintainers list as I am not
> > spending time on this topic for a while now.
>
> Fabrizio, would you like to send a v2 that removes Ramesh from the
> maintainers list for DRIF ?

Yes, I will remove Ramesh from the maintainers list for DRIF with the next
version of the series. I am waiting for a final feedback on the second
patch of the series before sending out v3.

Thanks,
Fab

>
> > > ---
> > > v1->v2:
> > > * No change
> > >
> > >  MAINTAINERS | 1 +
> > >  1 file changed, 1 insertion(+)
> > >
> > > diff --git a/MAINTAINERS b/MAINTAINERS
> > > index 2575f449139a..d9ebaf0c179b 100644
> > > --- a/MAINTAINERS
> > > +++ b/MAINTAINERS
> > > @@ -10909,6 +10909,7 @@ F:      include/media/drv-intf/renesas-ceu.h
> > >
> > >  MEDIA DRIVERS FOR RENESAS - DRIF
> > >  M:     Ramesh Shanmugasundaram <rashanmu@gmail.com>
> > > +M:     Fabrizio Castro <fabrizio.castro.jz@renesas.com>
> > >  L:     linux-media@vger.kernel.org
> > >  L:     linux-renesas-soc@vger.kernel.org
> > >  S:     Supported
>
> --
> Regards,
>
> Laurent Pinchart


Renesas Electronics Europe GmbH, Geschaeftsfuehrer/President: Carsten Jauch, Sitz der Gesellschaft/Registered office: Duesseldorf, Arcadiastrasse 10, 40472 Duesseldorf, Germany, Handelsregister/Commercial Register: Duesseldorf, HRB 3708 USt-IDNr./Tax identification no.: DE 119353406 WEEE-Reg.-Nr./WEEE reg. no.: DE 14978647