All of lore.kernel.org
 help / color / mirror / Atom feed
From: Mika Westerberg <mika.westerberg@linux.intel.com>
To: Hans de Goede <hdegoede@redhat.com>
Cc: Wolfram Sang <wsa@the-dreams.de>,
	Kai Heng Feng <kai.heng.feng@canonical.com>,
	linux-i2c@vger.kernel.org, linux-acpi@vger.kernel.org
Subject: Re: [PATCH] i2c: core: Call i2c_acpi_install_space_handler() before i2c_acpi_register_devices()
Date: Wed, 16 Sep 2020 19:04:13 +0300	[thread overview]
Message-ID: <20200916160413.GQ2495@lahna.fi.intel.com> (raw)
In-Reply-To: <b1c0b39f-8115-5c27-614f-a31a2731111f@redhat.com>

On Wed, Sep 16, 2020 at 05:56:54PM +0200, Hans de Goede wrote:
> Hi,
> 
> On 9/9/20 12:32 PM, Hans de Goede wrote:
> > Some ACPI i2c-devices _STA method (which is used to detect if the device
> > is present) use autodetection code which probes which device is present
> > over i2c. This requires the I2C ACPI OpRegion handler to be registered
> > before we enumerate i2c-clients under the i2c-adapter.
> > 
> > This fixes the i2c touchpad on the Lenovo ThinkBook 14-IIL and
> > ThinkBook 15 IIL not getting an i2c-client instantiated and thus not
> > working.
> > 
> > BugLink: https://bugzilla.redhat.com/show_bug.cgi?id=1842039
> > Signed-off-by: Hans de Goede <hdegoede@redhat.com>
> 
> Ping? This fixes a serious problem (non working touchpad on various
> laptop models) and is a pretty straight-forward fix.
> 
> Arguably it should even go to stable, but I'm not 100% sure about that
> because these sorta ACPI enumeration problems can sometimes by
> tricky. With that said in this case the fix does seem to be
> very straight forward and obviously correct.
> 
> Mika, since this deals with the ACPI bits of the i2c-core can
> you review this one please?

Sure, looks like the right thing to do:

Reviewed-by: Mika Westerberg <mika.westerberg@linux.intel.com>

  reply	other threads:[~2020-09-16 16:24 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-09-09 10:32 [PATCH] i2c: core: Call i2c_acpi_install_space_handler() before i2c_acpi_register_devices() Hans de Goede
2020-09-16 15:56 ` Hans de Goede
2020-09-16 16:04   ` Mika Westerberg [this message]
2020-09-17 21:18 ` Wolfram Sang

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20200916160413.GQ2495@lahna.fi.intel.com \
    --to=mika.westerberg@linux.intel.com \
    --cc=hdegoede@redhat.com \
    --cc=kai.heng.feng@canonical.com \
    --cc=linux-acpi@vger.kernel.org \
    --cc=linux-i2c@vger.kernel.org \
    --cc=wsa@the-dreams.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.